Commit Graph
11 Commits
Author SHA1 Message Date
dc55ad4583 test(autoe2e): generated E2E tests for #14027 (workflows-live-test-dispatch) (#14164)
Co-authored-by: Shrinath-O2 <214651540+Shrinath-O2@users.noreply.github.com>
Co-authored-by: Neha P <neha@openobserve.ai>
Co-authored-by: Neha P <144308844+neha00290@users.noreply.github.com>
2026-09-22 10:35:54 +00:00
3f6f97e25a test(autoe2e): generated E2E tests for #14577 (workflow-folders) (#14585)
Co-authored-by: Shrinath-O2 <214651540+Shrinath-O2@users.noreply.github.com>
Co-authored-by: Neha P <neha@openobserve.ai>
2026-09-21 13:40:11 +00:00
Bhargav 79c5d9ccb6 test: Workflows canvas branch connectors & control polish regression (o2-enterprise#2598) (#14434) 2026-09-18 09:20:17 +00:00
Neha P f3db1f5477 test(workflows): cover folders and folder-scoped RBAC [merge after o2-enterprise#2653] (#14577) 2026-09-17 12:18:23 +00:00
Neha P ac041fe597 test(workflows): cover Branch, draft lifecycle, node actions and the test drawer (#14446) 2026-09-12 04:41:29 +00:00
4f02b20d4a fix: workflow ux improvements - 2 (#14027)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ashish Kolhe <ashish.j.kolhe@gmail.com>
2026-09-03 10:16:24 +00:00
Neha P d7468650b0 test(workflows): cover conditions, the incident trigger, and destination delivery (#14065) 2026-09-01 10:52:10 +00:00
Neha P 5642284f4b test(workflows): un-skip the UI specs and fix the builder page object (#14048) 2026-09-01 05:51:54 +00:00
3e33b0e262 fix: workflow UX improvements (#13929)
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
Co-authored-by: Yashodhan Joshi <yjdoc2@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-08-27 12:29:14 +00:00
Shrinath RaoandClaude Opus 4.8 0e477f9918 test(workflows): de-flake K9 canary — log Save-intercept, don't hard-assert it (#13418)
## How this was found

The **Playwright E2E Crosscheck** bot (the ENT gate that runs
enterprise-only specs against OSS PRs) flagged a failing spec on an
unrelated logs PR ([#13414
comment](https://github.com/openobserve/openobserve/pull/13414#issuecomment-5058151842)):

> `Workflows/workflows-negative.spec.js` — *"enterprise-only e2e spec
failed against this PR … wouldn't show up in OSS CI."*

Digging showed it wasn't caused by that PR — the same test was **also
failing on #13413 and #13315**. It's a pre-existing **flake** in the ENT
gate, so this PR fixes it at the source.

## Evidence it's a flake, not a real break

The **same branch** produced both outcomes:

| ENT crosscheck run | PR | K9 test |
|---|---|---|
| 30005431754 | #13414 | ✅ passed (~50s, slow path) |
| 30008606974 | #13414 | ❌ failed |
| 30006996158 | #13315 | ❌ failed |
| 30006419247 | #13413 | ❌ failed |

## Root cause

`CT-19 K9` hard-asserted that a normal `.click()` on Save is intercepted
by a tooltip overlay:
```js
expect(await pm.workflowsPage.normalSaveClickIsIntercepted(4000)).toBe(true);
```
But the Save button has **no tooltip of its own** (`WorkflowEditor.vue`)
— the overlay that intercepts it is a **transient/adjacent tooltip**
that often never appears on a programmatic hover in headless CI. The
probe therefore conflates *"blocked by overlay"* with *"click landed"*,
and the assertion flips run to run. (A first attempt — waiting for the
overlay before probing — didn't help: the overlay simply isn't reliably
summoned.)

## Fix (test-only, no product/Vue changes)

- Treat interception as an **informational canary** —
`testLogger.info(...)` instead of a hard assert.
- Keep the **stable** assertion: the JS-click Save workaround still
reaches the app (`msg.length > 0`) — the adjacent trigger-only-save test
already exercises that same path and passes consistently.
- If K9 is ever genuinely fixed, the canary log shows
`intercepted:false` consistently — the signal to drop the JS-click
workaround.

This removes the flaky gate without losing meaningful coverage. Changes
are limited to the spec and its page object.

## Verification

`Workflows/*` are enterprise-only (skipped on OSS CI), so verified via
the **ENT gate against this OSS branch** (`e2e` label). The removed
assertion was the only flaky part; the retained assertion matches an
already-stable adjacent test.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-23 14:42:18 +00:00
Shrinath RaoandClaude Opus 4.8 b1604cc7b6 test(workflows): e2e + API tests for Workflows (#13318)
Adds automated test coverage for the Enterprise-only **Workflows**
feature (now merged to main). Clean branch off `main` — test files only,
no feature-code churn.

**UI (Playwright · `tests/ui-testing`)**
- `pages/workflowsPages/workflowsPage.js` — page object (verified
`data-test` selectors, Save-tooltip JS-click workaround, slow-list
waits, enterprise-availability probe).
- `playwright-tests/Workflows/workflows-crud.spec.js` — build/name
validation, list + search.
- `playwright-tests/Workflows/workflows-negative.spec.js` — negative +
NFR sweep (long/unicode/emoji names, list latency, console/network
hygiene).
- `pages/page-manager.js`, `pages/apiCleanup.js` (`cleanupWorkflows()` +
cascade), `playwright-tests/cleanup.spec.js` (`wf_auto_*` prefixes).
- `.github/workflows/playwright.yml` — `Workflows` testfolder in the
matrix.

**API (pytest · `tests/api-testing`)**
- `tests/workflows/test_workflows.py` — full REST surface
(create/list/update/enable/test/history/errors/retry/delete) +
validation, auth (401), cross-org.

**Behaviour**: Enterprise-gated (skips on OSS where the feature is off);
self-cleaning (`wf_auto_*`). Verified live: **11 Playwright + 13 pytest
passing**. Paired with the ENT matrix PR.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-21 12:26:52 +00:00