mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-05 08:09:22 +00:00
## Summary
Comprehensive rework of the `tests/api-testing/` suite. 30+ commits
implementing all 6 phases of the [revamp
plan](../../tests/ui-testing/MD_Files/api%20tests%20revamp/API_TESTS_REVAMP.md).
**Before → After:**
| | Baseline | Final | Δ |
|---|---|---|---|
| passed | 421 | **443** | **+22 ✓** |
| failed | 3 | **2** | -1 (only same pre-existing) |
| skipped | 53 | 39 | -14 (unskipped dead tests now run) |
| xfailed | 1 | 2 | +1 (new visible backend-bug signal) |
| runtime | 588s | **387s** | **-201s (34% faster)** |
**Zero tests that passed in baseline are now failing.** The 2 remaining
failures are the exact pre-existing ones
(`test_enrichment_table_join.py` backend panic + `test_workflow.py` SMTP
env-miss).
## What's in the diff
- **New `support/` framework** — `OpenObserveClient`, endpoint wrappers
(`alerts`, `dashboards`, `streams`, `search`, etc.), `wait_until()`,
payload factories, pytest fixtures, SSE parser. 14 framework selfcheck
tests.
- **16 of 16 OLD-tier test files rewritten** — using the new framework,
unique-suffix names, body validation, `wait_until` instead of
`time.sleep`, parametrize where appropriate.
- **29 files moved into 12 feature folders** mirroring the UI suite
layout
(`tests/{alerts,dashboards,ingest,orgs,pipelines,regression,rum,search,streams,users,workflow}/`).
- **−6,500 LOC net** (copy-paste + dead code removal; new framework adds
back ~1,500).
- **Ruff config** in pyproject.toml: T201 ban on `print()`, PT pytest
rules, B bugbear, UP pyupgrade.
## CI workflow changes
- New job `api_regression_tests`: `strategy.matrix` over the 4 env-flag
combinations (UTF8_VIEW × JOIN_MATCH_ONE) — now runs in parallel instead
of as 4 sequential server reboots in the main job.
- New job `api_fuzz_tests`: schemathesis OpenAPI-driven fuzz against
`/api-doc/openapi.json` (214 endpoints tested). Informational
(`continue-on-error: true`). Each run surfaces **7–10 distinct 5xx
panics** (e.g., empty `sql` body returning 500 instead of 400, traces
endpoints crashing on unescaped path params that get interpolated into
SQL). Filed to backend team for separate triage.
- Server `o2_*.log` files uploaded as artifacts on failure (was:
silently lost).
- `api_tests_summary` now requires BOTH integration + regression to
pass.
### CI infrastructure fixes
A short hardening pass landed after the initial CI run surfaced several
issues:
- **pytest-sugar count inflation** — dropped `--force-sugar` from both
pytest invocations. The flag double-registered sugar on top of the
auto-loaded entry point, inflating the CI test counter ~3x (display
showed 1364 when collection was 486). Counter is now honest.
- **schemathesis 4.x flag migration** — `--base-url` → `-u`,
`--hypothesis-max-examples` → `-n`, `--hypothesis-deadline` →
`--request-timeout`, `--data-generation-method` → `-m`, dropped
`--auth-type basic`. The fuzz job was failing immediately on flag-parse
before this.
- **Regression matrix binary path** — used `${{ github.workspace
}}/target/debug/openobserve` so the absolute path resolves correctly
under `working-directory: tests/api-testing/` (was: every matrix job
failed with "No such file or directory").
- **`permissions: contents: read`** added to all 4 workflow jobs —
closes CodeQL alert #369.
- **Removed redundant server boot** in `api_integration_tests` (leftover
from main's structure after the regression matrix split; was silently
failing to bind to :5080 and getting masked by the first server).
## Backend bugs surfaced (for backend team to track)
The rework uncovered and visibly flagged these as `xfail`/documented
test comments:
1. `DELETE /api/organizations/{id}` returns 404 unconditionally even for
just-created orgs — endpoint appears unimplemented.
2. `test_dashboard_missing_required_fields` triggers backend panic
(returns 500 instead of 400/422).
3. JS `getEnrichmentTableData()` restricted to `_meta` org AND not
exposed in the `/functions/test` endpoint runtime — `ReferenceError`
even with explicit `enrichment_tables: [...]`.
4. Bulk API silently sanitizes invalid `_index` values (`****` → `_`)
without flagging — user data lands in unexpected index.
5. `AVG` of a single value drifts by ~1e-14 (likely float reduction
order; documented tolerance in `test_advanced_sql.py`).
6. Org name validation rejects hyphens (only
`A-Z/a-z/0-9/spaces/underscores`) — not in spec.
Plus 7–10 additional 5xx panics surfaced per fuzz run (input validation
gaps — separate triage list in fuzz job logs).
## Test bugs uncovered + fixed
- `test_pipeline.py`: had two function definitions named
`test_pipeline_creation_and_action_with_schedule` — Python's last-wins
meant the first test's body never executed for years.
- `test_alertsV2.py`: `assert alert_disabled == "False"` was indented
inside an `else:` branch that never executed because the response is
always a dict; AND `enabled` is a bool, not the string `"False"`. Two
layers of broken.
- `test_bulk.py`: variable typo (`valid_bulk_payload` reused on the POST
call) made the invalid-index test silently duplicate the valid case.
- `test_organisations.py`: `test_create_organization` used pre-pytest-4
`yield`-style fixtures — silently ignored by pytest 8.
- `test_js_result_array.py`: 8 tests skipped with `"Temporarily disabled
- failing test"` — the actual cause was that JS functions are restricted
to `_meta` org. One-line fix unskipped all 8.
- `test_fuzzy.py`: 4 tests `@pytest.mark.skip`-ed because they used a
1-minute time window against older static test data → 0 hits → flake →
skip. Wider window unskips them.
- 547 LOC of zombie commented-out test blocks deleted (15 commented `#
def test_` definitions, including one orphan case where the `def` was
commented but the indented body wasn't).
## Folder layout
```
tests/api-testing/
├── support/ # NEW framework
│ ├── client.py # OpenObserveClient
│ ├── endpoints/ # 7 per-resource wrappers
│ ├── factories.py # unique_name, time_window, *_payload
│ ├── wait.py # wait_until + WaitTimeout
│ ├── sse.py # read_sse_response
│ └── fixtures.py # client, temp_user_email, temp_stream_name, ...
├── helpers/ # Non-test shared code (was scattered in tests/)
│ ├── sourcemap_helpers.py
│ └── workflow/ # workflow chain + pages/ live here now
├── fixtures/
│ └── rum/ # Standalone RUM ingest scripts (was in tests/)
└── tests/
├── alerts/ # 3 files
├── dashboards/ # 4 files
├── ingest/ # 4 files
├── orgs/ # 2 files
├── pipelines/ # 10 files
├── regression/ # 2 files (env-flag matrix targets)
├── rum/ # 3 files
├── search/ # 8 files
├── streams/ # 1 file
├── users/ # 1 file
├── workflow/ # 3 files
├── conftest.py
└── test_framework_selfcheck.py
```
## Test plan
- [x] `rye run pytest --collect-only` — 486 tests discovered
- [x] Full default-set run (`--ignore=tests/regression`) — 443 pass / 2
fail / 39 skip / 2 xfail in 387s
- [x] `rye run pytest -m framework` — 14/14 selfcheck tests pass
- [x] `rye run ruff check support/ tests/test_framework_selfcheck.py` —
clean
- [x] CI run on this PR — `api_integration_tests` + all 4
`api_regression_tests` matrix jobs green
- [x] CI run — `api_fuzz_tests` runs cleanly (informational; surfaces
7–10 unique 5xx panics per run)
## Note on test count
The `test_streaming.py` rewrite folded 7 "tests" (`test_ingest_data`,
`test_ingest_join`, `test_disable_streaming`,
`test_update_max_query_range`, `test_enable_streaming`,
`test_delete_stream`, `test_delete_stream_join`) into pytest fixtures.
Each only checked `status_code == 200` of a setup/teardown operation —
they were imperative steps masquerading as tests. The fixtures still
perform the same operations and assert their success; they're just no
longer counted as discrete pytest items. **Functional coverage is
identical.**
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
211 lines
11 KiB
Python
211 lines
11 KiB
Python
import random
|
|
import time
|
|
from requests.auth import HTTPBasicAuth
|
|
|
|
class TemplatePage:
|
|
Unique_value_temp = f"d4m21_{random.randint(100000, 999999)}" # Class variable
|
|
|
|
def __init__(self, session, base_url, org_id):
|
|
self.session = session
|
|
self.base_url = base_url
|
|
self.org_id = org_id
|
|
|
|
def create_template_webhook(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Create a Webhook template."""
|
|
headers = {"Content-Type": "application/json", "Custom-Header": "value"}
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
payload = {
|
|
"name": template_name,
|
|
"body": '{\n \"text\": \"{alert_name} is active\"\n}',
|
|
"type": "http",
|
|
"title": ""
|
|
}
|
|
response = session.post(f"{base_url}api/{org_id}/alerts/templates", json=payload, headers=headers)
|
|
assert response.status_code == 200, f"Failed to create template: {response.content}"
|
|
return response
|
|
|
|
def create_template_email(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Create an Email template."""
|
|
headers = {"Content-Type": "application/json", "Custom-Header": "value"}
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
payload = {
|
|
"name": template_name,
|
|
"body": '{"text": "For stream {stream_name} of organization {org} alert {alert_name} of type {alert_type} is active"}',
|
|
"type": "email",
|
|
"title": "email_title"
|
|
}
|
|
response = session.post(f"{base_url}api/{org_id}/alerts/templates", json=payload, headers=headers)
|
|
assert response.status_code == 200, f"Failed to create template: {response.content}"
|
|
return response
|
|
|
|
def retrieve_templates_webhook(self, session, base_url, user_email, user_password, org_id):
|
|
"""Retrieve templates and extract information about all templates matching the specified criteria."""
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
response = session.get(f"{base_url}api/{org_id}/alerts/templates")
|
|
assert response.status_code == 200, f"Failed to validate templates: {response.content}"
|
|
|
|
# Parse the JSON response
|
|
templates = response.json()
|
|
assert len(templates) > 0, "No templates found"
|
|
|
|
# Filter templates that contain 'template_webhook' and match the expected name
|
|
webhook_templates = [template for template in templates
|
|
if "template_webhook" in template["name"]
|
|
and template["name"].startswith(f"template_webhook_{TemplatePage.Unique_value_temp}")]
|
|
|
|
# Assert that there are templates matching the criteria
|
|
assert len(webhook_templates) > 0, f"No templates found containing 'template_webhook' with title 'template_webhook_{TemplatePage.Unique_value_temp}'"
|
|
|
|
# Return structured data
|
|
return {
|
|
"count": len(webhook_templates),
|
|
"templates": webhook_templates
|
|
}
|
|
|
|
def retrieve_template_webhook(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Retrieve the template webhook and assert the body."""
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
response = session.get(f"{base_url}api/{org_id}/alerts/templates/{template_name}")
|
|
assert response.status_code == 200, f"Failed to validate template: {response.content}"
|
|
|
|
template_webhook = response.json() # Assuming the response is a single template, not a list.
|
|
|
|
# Assert that the response is a valid template object
|
|
assert isinstance(template_webhook, dict), "Response is not a valid template object"
|
|
|
|
return {
|
|
"name_template_webhook": template_webhook["name"],
|
|
"body_template_webhook": template_webhook["body"]
|
|
}
|
|
|
|
def retrieve_templates_email(self, session, base_url, user_email, user_password, org_id):
|
|
"""Retrieve templates and extract the first template name containing 'template_email' with title 'email_title'."""
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
response = session.get(f"{base_url}api/{org_id}/alerts/templates")
|
|
assert response.status_code == 200, f"Failed to validate templates: {response.content}"
|
|
|
|
templates = response.json()
|
|
assert len(templates) > 0, "No templates found"
|
|
|
|
|
|
email_templates = [
|
|
template for template in templates
|
|
if template["name"].startswith(f"template_email_{TemplatePage.Unique_value_temp}")
|
|
]
|
|
|
|
# Assert that there are templates matching the criteria
|
|
assert len(email_templates) > 0, f"No templates found containing 'template_email' with title 'template_email_{TemplatePage.Unique_value_temp}'"
|
|
|
|
# Return structured data
|
|
return {
|
|
"count": len(email_templates),
|
|
"templates": email_templates
|
|
}
|
|
|
|
def retrieve_template_email(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Retrieve the template email and assert the title."""
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
response = session.get(f"{base_url}api/{org_id}/alerts/templates/{template_name}")
|
|
assert response.status_code == 200, f"Failed to validate template: {response.content}"
|
|
|
|
template_email = response.json() # Assuming the response is a single template, not a list.
|
|
assert isinstance(template_email, dict), "Response is not a valid template object"
|
|
|
|
|
|
return {
|
|
"name_template_email": template_email["name"],
|
|
"title_template_email": template_email["title"]
|
|
}
|
|
|
|
def update_template_webhook(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Update an Webhook template."""
|
|
headers = {"Content-Type": "application/json", "Custom-Header": "value"}
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
payload = {
|
|
"name": template_name,
|
|
"body": '{"text": "For stream {stream_name} of organization {org} alert {alert_name} of type {alert_type} is active"}',
|
|
"type": "http",
|
|
"title": ""
|
|
}
|
|
response = session.put(f"{base_url}api/{org_id}/alerts/templates/{template_name}", json=payload, headers=headers)
|
|
assert response.status_code == 200, f"Failed to update template: {response.content}"
|
|
template_webhook = response.json()
|
|
assert isinstance(template_webhook, dict), "Response is not a valid template object"
|
|
|
|
def update_template_email(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Update an Email template."""
|
|
headers = {"Content-Type": "application/json", "Custom-Header": "value"}
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
payload = {
|
|
"name": template_name,
|
|
"body": '{"text": "For stream {stream_name} of organization {org} alert {alert_name} of type {alert_type} is active"}',
|
|
"type": "email",
|
|
"title": "email_title_updated"
|
|
}
|
|
response = session.put(f"{base_url}api/{org_id}/alerts/templates/{template_name}", json=payload, headers=headers)
|
|
assert response.status_code == 200, f"Failed to update template: {response.content}"
|
|
template_email = response.json()
|
|
assert isinstance(template_email, dict), "Response is not a valid template object"
|
|
|
|
def delete_template(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Delete templates of a specified type."""
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
|
|
resp_delete_template = session.delete(f"{base_url}api/{org_id}/alerts/templates/{template_name}")
|
|
assert resp_delete_template.status_code == 200, f"Failed to delete template {template_name}: {resp_delete_template.content}"
|
|
|
|
# Wait for a few seconds to allow the data to be deleted
|
|
time.sleep(10) # Increase this time if necessary
|
|
|
|
# Verify deletion
|
|
resp_ver_template = session.get(f"{base_url}api/{org_id}/alerts/templates/{template_name}")
|
|
assert resp_ver_template.status_code == 404, f"Expected 404 for {template_name}, but got {resp_ver_template.status_code}"
|
|
|
|
return resp_delete_template # Return the list of deleted template names for verification if needed
|
|
|
|
def validate_deleted_template_webhook(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Running an E2E test for validating deleted templates in SC."""
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
# Retrieve all templates
|
|
response = session.get(f"{base_url}api/{org_id}/alerts/templates")
|
|
assert response.status_code == 200, f"Failed to retrieve templates: {response.content}"
|
|
|
|
templates = response.json()
|
|
|
|
# Filter templates that contain 'template_webhook' and match the expected name
|
|
webhook_templates = [template for template in templates
|
|
if "template_webhook" in template["name"]
|
|
and template["name"].startswith(f"template_webhook_{TemplatePage.Unique_value_temp}")]
|
|
|
|
# Check if any templates of the specified type exist
|
|
if len(webhook_templates) == 0:
|
|
print(f"No templates found of type '{template_name}'")
|
|
else:
|
|
print(f"Templates found of type '{template_name}': {[template['name'] for template in webhook_templates]}")
|
|
return webhook_templates
|
|
|
|
def validate_deleted_template_email(self, session, base_url, user_email, user_password, org_id, template_name):
|
|
"""Running an E2E test for validating deleted templates in SC."""
|
|
session.auth = HTTPBasicAuth(user_email, user_password)
|
|
# Retrieve all templates
|
|
response = session.get(f"{base_url}api/{org_id}/alerts/templates")
|
|
assert response.status_code == 200, f"Failed to retrieve templates: {response.content}"
|
|
|
|
templates = response.json()
|
|
|
|
# Filter templates that contain 'template_email' and match the expected name
|
|
email_templates = [template for template in templates
|
|
if "template_email" in template["name"]
|
|
and template["name"].startswith(f"template_email_{TemplatePage.Unique_value_temp}")]
|
|
|
|
# Check if any templates of the specified type exist
|
|
if len(email_templates) == 0:
|
|
print(f"No templates found of type '{template_name}'")
|
|
# Optionally, you can choose to skip the assertion or handle it differently
|
|
else:
|
|
assert len(email_templates) > 0, f"No templates found of type '{template_name}'"
|
|
print(f"Templates found of type '{template_name}': {[template['name'] for template in email_templates]}")
|
|
|
|
return email_templates
|
|
|