mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 00:08:55 +00:00
Shrinath RaoandClaude Opus 4.8
51cb2c4ff4
## What Heals the two GeneralTests specs that fail in the ENT playwright matrix (ENT PR #2047, `test/ent-matrix-sync-missing-specs`) but are **skipped on OSS**. Both cover **enterprise-only** features (Regex Patterns, AI Toolsets / CrossLink). Their `beforeEach` probes for the feature route and `test.skip()`s when absent — so on the OSS binary they never run. ENT PR #2047 adds them to the ENT matrix, running them against the enterprise build for the first time and exposing two assertions that were never actually exercised. Not regressions — untested assertions finally hitting a real enterprise build. ## Fixes 1. **regex-patterns-form-validation** — `AddRegexPattern.vue`'s ODrawer has no `:primary-button-disabled` binding, so the Create button stays enabled on an empty form (validation runs on submit via the OForm schema). Assert `toBeEnabled()` and trigger the required-field errors by submitting. 2. **ai-toolsets-form-validation (CrossLink)** — the streams page defaults to the "logs" type filter (`LogStream.vue selectedStreamType=ref("logs")`), so the traces stream named `default` never renders a row and `log-stream-schema-btn` is unreachable. Point the suite at `e2e_automate` (the logs stream global ingestion always creates; cross-linking is logs-only and gated by `ZO_ENABLE_CROSS_LINKING=true`, which CI sets). ## Verification Reproduced both failures and verified the fixes on a local **enterprise** build (`build_type=enterprise`, v0.91.0-rc2): - regex-patterns: all 4 tests pass. - CrossLink: stream-detail step (original failure point) now passes; the tab additionally needs `ZO_ENABLE_CROSS_LINKING=true` (off on local dev binary, on in CI). ## Note Branch name matches the ENT branch `test/ent-matrix-sync-missing-specs` so the ENT CI tree-merge picks up these fixes for PR #2047. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>