mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
Loakesh Indiran
53fdf3d04b
- fix: disable write to cache in cache handler if req is streaming (#7379) - fix: histogram interval for http2 streaming (#7389) ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Add `is_http2_streaming` flag to cache searches - Skip result caching for streaming requests - Update cache search signature and logic - Enhance cache miss logs with query info ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><details><summary>7 files</summary><table> <tr> <td><strong>mod.rs</strong><dd><code>Add streaming flag to gRPC search cache call</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-8dcdb10340635be8bb58d45a815569026877f6fdbb3b69a773a30698b91674b0">+1/-0</a> </td> </tr> <tr> <td><strong>mod.rs</strong><dd><code>Add streaming flag to HTTP search cache call</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-96630a0dbb6dd7b2b0248fa325c7c7041ce31340c32826675a4a70772e9d29f6">+2/-0</a> </td> </tr> <tr> <td><strong>multi_streams.rs</strong><dd><code>Pass streaming flag to multi-stream search</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-c3233cdf1e68cb2455f91457719b9c2f477e735ee16546fdfe111e76768bd054">+1/-0</a> </td> </tr> <tr> <td><strong>search_inspector.rs</strong><dd><code>Add streaming flag to inspector search calls</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-f818db4ca10b411c3559cc2a2659c49a59a45ecde0e4a22f9ef023da0bf4a009">+1/-0</a> </td> </tr> <tr> <td><strong>mod.rs</strong><dd><code>Add HTTP2 streaming check before caching</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-f07bfacc0501b9c234e64b16c1dd8eb0ae8fcbe231f90c81fed72bcc94946f74">+2/-0</a> </td> </tr> <tr> <td><strong>search_stream.rs</strong><dd><code>Pass streaming flag to streaming cache search</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-b952a89375f2745a0daa273f1bdefc80c22997759a9b17a8fccbc70ae294e8e4">+1/-0</a> </td> </tr> <tr> <td><strong>search.rs</strong><dd><code>Pass streaming flag to websocket search cache</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-13476631e2e604b75e2dfdd8fb7b7a91c46dcd85faa50813afa0b87583bcdb26">+1/-0</a> </td> </tr> </table></details></td></tr><tr><td><strong>Enhancement</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>multi.rs</strong><dd><code>Enhance cache miss logging details</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7392/files#diff-7eb49bf810eab33aedff3aa5af2f03dfef49c27d62dcaf85d182e8dad10b66d8">+6/-4</a> </td> </tr> </table></details></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details>