Files
openobserve/.github/scripts/build-ci-matrix.js
T

409 lines
18 KiB
JavaScript

#!/usr/bin/env node
/**
* build-ci-matrix.js — single source of truth for the Playwright UI shard matrix.
*
* Prints a GitHub Actions matrix object: {"include":[ {testfolder,actual_folder,browser,run_files}, ... ]}
* consumed by `strategy.matrix: ${{ fromJSON(needs.generate_matrix.outputs.matrix) }}`.
*
* Usage:
* node build-ci-matrix.js <base.json> # OSS: base manifest verbatim
* node build-ci-matrix.js <base.json> <overlay.json> # ENT: base + enterprise overlay
* ... --select-for-changes <changed-files.txt> # PR smoke: emit only the shards
* owning the changed files — via run_files (specs), their test folder, the shared
* folder_paths map in smoke_config.json (keyed by actual_folder), or optional
* per-shard "paths" extras. A changed file matching a
* global_paths glob emits the FULL matrix; a file matching nothing pulls in the
* core_shards cross-section (never zero shards) — safe because merge_group always
* runs the full matrix before anything lands. Without the flag the full matrix is
* emitted. With an overlay manifest, a sibling smoke_config.ent.json (same dir as
* the overlay) refines selection for ENT shards — folder_paths and path lists
* concatenate onto the base smoke config, core_shards/always_run replace it.
*
* The base (OSS tests/ui-testing/ci-matrix/ci_matrix.json) is the ONLY place shared shards are
* listed. ENT never re-lists shared specs — its overlay (ci_matrix.ent.json) carries
* only the delta, so a spec added to OSS flows into ENT automatically:
* { "append": { "<testfolder>": ["extra.spec.js", ...] }, // add ENT-only specs to a shared shard
* "shards": [ {testfolder,actual_folder,browser,run_files} ], // whole ENT-only shards (Workflows, SDR…)
* "disabled": { "<testfolder>": [{file,reason}, ...] } } // ENT-only specs turned off (doc only)
*
* DISABLING A SPEC (JSON has no // comments): don't delete it — move it into a
* shard's "disabled": [{ "file": "x.spec.js", "reason": "why" }] array. Disabled
* entries are documentation only: this script never emits them, so they don't run,
* but the record + reason survive. "_comment" (or any _-prefixed key) is also ignored.
*
* Every caller gets the same validation: unique testfolders, no empty shard, no spec
* listed twice (within a shard or across two shards), no spec both active and disabled,
* and no run_files entry without a file on disk.
*
* This lives in OSS so ENT can reuse it from its tree-merged OSS checkout.
*/
const fs = require("fs");
const path = require("path");
function die(msg) {
process.stderr.write(`build-ci-matrix: ${msg}\n`);
process.exit(1);
}
function log(msg) {
// stderr, because stdout must stay pure matrix JSON for $GITHUB_OUTPUT.
process.stderr.write(`build-ci-matrix: ${msg}\n`);
}
const globCache = new Map();
function globToRegExp(glob) {
const cached = globCache.get(glob);
if (cached) return cached;
// Only * and ** are supported; fail loud so ?/{}/[] syntax can't silently never match.
const unsupported = glob.match(/[?{}[\]]/);
if (unsupported) die(`unsupported glob syntax "${unsupported[0]}" in "${glob}" (only * and ** work)`);
let re = "";
for (let i = 0; i < glob.length; i++) {
const c = glob[i];
if (c === "*") {
if (glob[i + 1] === "*") {
re += ".*";
i++;
if (glob[i + 1] === "/") i++;
} else {
re += "[^/]*";
}
} else if (".+^$()|\\".includes(c)) {
re += "\\" + c;
} else {
re += c;
}
}
const compiled = new RegExp("^" + re + "$");
globCache.set(glob, compiled);
return compiled;
}
function matchesAny(file, globs) {
return (globs || []).some((g) => globToRegExp(g).test(file));
}
// Globs owning a shard: its folder's shared list plus optional per-shard extras.
function shardGlobs(shard, config) {
return [...(config.folder_paths[shard.actual_folder] || []), ...(shard.paths || [])];
}
// Validated on EVERY selection run, so a PR that breaks the config fails its own CI
// instead of merging green (via the full-matrix path) and detonating on the next PR.
function validateSmokeConfig(shards, config) {
if (!Array.isArray(config.core_shards) || config.core_shards.length === 0) {
die("smoke_config.json must define a non-empty core_shards list");
}
for (const folder of [...config.core_shards, ...(config.always_run || [])]) {
if (!shards.some((s) => s.testfolder === folder)) {
die(`smoke_config core_shards/always_run names unknown shard "${folder}"`);
}
}
if (typeof config.folder_paths !== "object" || config.folder_paths === null) {
die("smoke_config.json must define a folder_paths map keyed by actual_folder");
}
for (const s of shards) {
if (shardGlobs(s, config).length === 0) {
die(`shard "${s.testfolder}" (folder "${s.actual_folder}") has no folder_paths entry and no paths — it would be unreachable by source changes`);
}
}
for (const globs of [
config.always_ignore_paths,
config.global_paths,
config.ignore_paths,
...Object.values(config.folder_paths),
...shards.map((s) => s.paths),
]) {
(globs || []).forEach(globToRegExp);
}
}
// Decide which shards a PR needs. Returns null to mean "run the full matrix".
// Mapped files select their shards; anything unmapped pulls in core_shards — a fixed
// cross-section — instead of the full matrix, because the merge queue always runs
// every shard before anything lands. Only global_paths (shared code and the smoke
// machinery itself) still force full on the PR.
function selectShards(shards, config, changedFiles) {
if (changedFiles.length === 0) {
// An empty list means the upstream diff broke, not that nothing changed — fail safe.
log("full matrix: changed-files list is empty (upstream diff produced nothing)");
return null;
}
const wanted = new Set();
let needCore = false;
for (const file of changedFiles) {
// always_ignore_paths beats global_paths: unit specs/snapshots under web/src are
// never bundled into the app, so they can't affect e2e no matter where they live.
if (matchesAny(file, config.always_ignore_paths)) continue;
// global_paths outranks ignore_paths so files like playwright.yml can't be
// ignored away by a broad ignore glob.
if (matchesAny(file, config.global_paths)) {
log(`full matrix: "${file}" matches global_paths`);
return null;
}
if (matchesAny(file, config.ignore_paths)) continue;
// A spec listed in run_files routes to exactly its owning shard.
const specMatch = file.match(/^tests\/ui-testing\/playwright-tests\/([^/]+)\/([^/]+)$/);
if (specMatch) {
const specOwners = shards.filter(
(s) => s.actual_folder === specMatch[1] && s.run_files.includes(specMatch[2])
);
if (specOwners.length > 0) {
specOwners.forEach((s) => wanted.add(s.testfolder));
continue;
}
}
// Union of folder ownership (a shard implicitly owns its test folder — new specs and
// shard-local helpers) and glob ownership, so cross-folder imports still route.
const owners = new Set();
const folderMatch = file.match(/^tests\/ui-testing\/playwright-tests\/([^/]+)\//);
if (folderMatch) {
shards.filter((s) => s.actual_folder === folderMatch[1]).forEach((s) => owners.add(s));
}
shards.filter((s) => matchesAny(file, shardGlobs(s, config))).forEach((s) => owners.add(s));
if (owners.size === 0) {
log(`core fallback: "${file}" matches no shard's globs`);
needCore = true;
continue;
}
owners.forEach((s) => wanted.add(s.testfolder));
}
if (wanted.size === 0 && !needCore) {
log("core fallback: no selectable changes (only ignored files)");
needCore = true;
}
if (needCore) config.core_shards.forEach((f) => wanted.add(f));
(config.always_run || []).forEach((f) => wanted.add(f));
return shards.filter((s) => wanted.has(s.testfolder));
}
function readJson(path) {
try {
return JSON.parse(fs.readFileSync(path, "utf8"));
} catch (e) {
die(`cannot read/parse ${path}: ${e.message}`);
}
}
const args = process.argv.slice(2);
const selectIdx = args.indexOf("--select-for-changes");
let changedFilesPath = null;
if (selectIdx !== -1) {
changedFilesPath = args[selectIdx + 1];
if (!changedFilesPath) die("--select-for-changes requires a path to a changed-files list");
args.splice(selectIdx, 2);
}
const [basePath, overlayPath] = args;
if (!basePath) {
die("usage: build-ci-matrix.js <base.json> [overlay.json] [--select-for-changes <changed.txt>]");
}
const base = readJson(basePath);
if (!Array.isArray(base)) die(`base ${basePath} must be a JSON array of shards`);
// Deep-copy base so we never mutate the parsed source objects.
const include = base.map((s) => ({ ...s, run_files: [...(s.run_files || [])] }));
const byFolder = new Map(include.map((s) => [s.testfolder, s]));
if (overlayPath) {
const overlay = readJson(overlayPath);
// append: add enterprise-only specs to an EXISTING shared shard.
for (const [folder, specs] of Object.entries(overlay.append || {})) {
const shard = byFolder.get(folder);
if (!shard) {
die(`overlay append targets unknown folder "${folder}" — it must exist in the base manifest`);
}
for (const spec of specs) {
if (shard.run_files.includes(spec)) {
die(`overlay append: "${spec}" already in base shard "${folder}" — remove it from the overlay`);
}
shard.run_files.push(spec);
}
}
// shards: whole enterprise-only shards (Workflows, SDR-Logs, SDR-Traces, …).
for (const shard of overlay.shards || []) {
if (byFolder.has(shard.testfolder)) {
die(`overlay shard "${shard.testfolder}" collides with a base shard — use "append" instead`);
}
const copy = { browser: "chrome", ...shard, run_files: [...(shard.run_files || [])] };
include.push(copy);
byFolder.set(copy.testfolder, copy);
}
// disabled: enterprise-only turned-off specs, recorded against a shard for docs only.
for (const [folder, entries] of Object.entries(overlay.disabled || {})) {
const shard = byFolder.get(folder);
if (!shard) die(`overlay disabled targets unknown folder "${folder}"`);
shard.disabled = [...(shard.disabled || []), ...entries];
}
}
// Sanity: unique testfolders, no empty shards, no dup specs (within a shard OR across
// shards), no spec both active and disabled, and no spec that does not exist on disk.
const seen = new Set();
const specOwner = new Map();
const docOnly = [];
for (const s of include) {
if (!s.testfolder) die(`shard missing testfolder: ${JSON.stringify(s)}`);
if (seen.has(s.testfolder)) die(`duplicate testfolder "${s.testfolder}"`);
seen.add(s.testfolder);
if (!s.actual_folder) s.actual_folder = s.testfolder;
// A documentation-only entry carries no run_files and exists purely to record, in its
// "disabled" array, why a whole module stays off this suite — there is no shard to hang
// those verdicts on otherwise. It is dropped from the emitted matrix below, so it never
// becomes a job. An entry with neither run_files nor disabled records nothing and runs
// nothing, which is a manifest bug.
if (!s.run_files || s.run_files.length === 0) {
if (!(s.disabled || []).length) {
die(`shard "${s.testfolder}" has no run_files and no disabled entries — it records nothing and runs nothing`);
}
docOnly.push(s.testfolder);
continue;
}
if (new Set(s.run_files).size !== s.run_files.length) {
die(`shard "${s.testfolder}" has duplicate run_files`);
}
for (const d of s.disabled || []) {
if (s.run_files.includes(d.file)) {
die(`shard "${s.testfolder}": "${d.file}" is in both run_files and disabled`);
}
}
// Across shards: two shards listing the same spec run it twice, which no one asks for
// on purpose — it happens when two PRs register the same new spec in different shards.
for (const spec of s.run_files) {
const key = `${s.actual_folder}/${spec}`;
const owner = specOwner.get(key);
if (owner) die(`"${key}" is listed in both "${owner}" and "${s.testfolder}" — keep one`);
specOwner.set(key, s.testfolder);
}
}
// A run_files entry that no longer exists on disk is the one failure mode a green CI run
// cannot show you: playwright_alpha1.yml skips missing paths with a warning, and a
// Playwright path argument that matches nothing simply selects no tests. So a spec that
// was renamed or split stops running and the shard stays green. Resolve every entry
// against the specs tree that sits beside the manifest and fail here instead.
const specsRoot = path.resolve(path.dirname(basePath), "..", "playwright-tests");
if (fs.existsSync(specsRoot)) {
const missing = [];
for (const s of include) {
for (const spec of s.run_files) {
if (!fs.existsSync(path.join(specsRoot, s.actual_folder, spec))) {
missing.push(`${s.testfolder} → ${s.actual_folder}/${spec}`);
}
}
}
if (missing.length) {
die(`run_files entries with no file on disk (renamed, split or deleted):\n ${missing.join("\n ")}`);
}
} else {
log(`specs tree ${specsRoot} not present — skipping the spec-exists check`);
}
// Everything downstream — smoke selection included — sees only shards that actually run,
// so a documentation-only entry can never be selected, validated against smoke_config or
// emitted as a job with an empty run_files.
const runnable = include.filter((s) => (s.run_files || []).length);
if (docOnly.length) log(`documentation-only (never run): ${docOnly.join(", ")}`);
let emitted = runnable;
if (changedFilesPath) {
// Selection only exists for pull_request; merge_group/push must always get the full matrix.
const event = process.env.GITHUB_EVENT_NAME;
if (event && event !== "pull_request") {
die(`--select-for-changes is pull_request-only (GITHUB_EVENT_NAME=${event})`);
}
const config = readJson(path.join(path.dirname(basePath), "smoke_config.json"));
// With a manifest overlay (ENT), a sibling smoke_config.ent.json refines selection for
// enterprise shards: folder_paths/path lists concatenate, core_shards/always_run replace.
if (overlayPath) {
const entConfigPath = path.join(path.dirname(overlayPath), "smoke_config.ent.json");
if (fs.existsSync(entConfigPath)) {
const ent = readJson(entConfigPath);
for (const key of ["always_ignore_paths", "global_paths", "ignore_paths"]) {
if (ent[key]) config[key] = [...(config[key] || []), ...ent[key]];
}
for (const [folder, globs] of Object.entries(ent.folder_paths || {})) {
config.folder_paths[folder] = [...(config.folder_paths[folder] || []), ...globs];
}
if (ent.core_shards) config.core_shards = ent.core_shards;
if (ent.always_run) config.always_run = ent.always_run;
log(`merged smoke config overlay ${entConfigPath}`);
}
}
validateSmokeConfig(runnable, config);
let raw;
try {
raw = fs.readFileSync(changedFilesPath, "utf8");
} catch (e) {
die(`cannot read changed-files list ${changedFilesPath}: ${e.message}`);
}
const changedFiles = raw
.split("\n")
.map((l) => l.trim())
.filter(Boolean);
const selected = selectShards(runnable, config, changedFiles);
if (selected) {
emitted = selected;
log(
`smoke: ${emitted.length}/${runnable.length} shards — ${emitted
.map((s) => s.testfolder)
.join(", ")}`
);
} else {
log(`smoke: falling back to full matrix (${runnable.length} shards)`);
}
}
// Emit ONLY the fields the CI matrix consumes — disabled/_comment/notes are stripped,
// so turned-off specs never reach `npx playwright test`.
//
// quick_mode_enabled is always emitted (defaulting to "false") so every shard
// carries the key: the workflow feeds it to ZO_QUICK_MODE_ENABLED when starting
// that shard's OpenObserve process. The flag is read once at server start, so it
// cannot vary per test — a shard is the smallest unit that can change it.
//
// ingest_allowed_upto follows the same rule and for the same reason. It is how
// far back (HOURS) ingestion accepts a record; the workflow default is 5, which
// silently DROPS older rows while still returning a success-shaped response. A
// suite that seeds history — SLOs measure a rolling 7-day window — needs a wider
// one, and scoping it to those shards keeps every other shard on the default.
//
// slo_backfill_chunk_secs follows the same rule for the same class of reason:
// it's how much history one SLO backfill chunk covers, read once at server
// start. The workflow default (86400 = 1 day) makes a 7-day-window test SLO
// backfill in 7 sequential chunks under ZO_SCHEDULER_SLO_BACKFILL_CONCURRENCY=1;
// SLO-Measurement widens it to the full window so its 3 backfilled SLOs don't
// pay 21 chunks serially.
const matrix = emitted.map((s) => ({
testfolder: s.testfolder,
actual_folder: s.actual_folder,
browser: s.browser || "chrome",
run_files: s.run_files,
quick_mode_enabled:
s.quick_mode_enabled === true || s.quick_mode_enabled === "true" ? "true" : "false",
ingest_allowed_upto:
s.ingest_allowed_upto === undefined || s.ingest_allowed_upto === null
? ""
: String(s.ingest_allowed_upto),
slo_backfill_chunk_secs:
s.slo_backfill_chunk_secs === undefined || s.slo_backfill_chunk_secs === null
? ""
: String(s.slo_backfill_chunk_secs),
// Per-shard worker count. Empty = use playwright.config.js (5 in CI).
//
// `fullyParallel` runs separate spec FILES concurrently, and
// `test.describe.configure({mode:'serial'})` only orders tests inside one file.
// A shard whose specs contend for a shared server-side resource therefore has
// to pin workers to 1 — otherwise the files race each other, which is not
// something the specs themselves can express.
workers: s.workers === undefined || s.workers === null ? "" : String(s.workers),
}));
process.stdout.write(JSON.stringify({ include: matrix }));