mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 08:09:27 +00:00
Shrinath Rao
6fc540cd25
### **User description** Updated logs page, Updated playwright yml file, Updated all files containing references of logs page, added folder structure to logs, updated locators for failing test cases ___ ### **PR Type** Tests, Enhancement ___ ### **Description** - Introduce `LogsPage` POM class with locators and methods - Refactor log specs to use new POM classes - Add `LogsQueryPage` for query filtering logic - Rename `selectStream` helper across tests ___ ### **Changes diagram** ```mermaid flowchart LR A["LogsPage POM"] --> B["logspage.spec.js"] A --> C["logsqueries.spec.js"] A --> D["logshistogram.spec.js"] A --> E["logsQueryPage POM"] F["Stream Helper"] --> G["indexquery.spec.js"] ``` ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><details><summary>2 files</summary><table> <tr> <td><strong>logsPage.js</strong><dd><code>Add comprehensive `LogsPage` POM class</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-8045b343491d8943869c1af74cdafab204dc49c02a70294417e73f47d35e0b59">+1563/-0</a></td> </tr> <tr> <td><strong>logsQueryPage.js</strong><dd><code>Add `LogsQueryPage` for query filter tests</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-d4b122abaad43a49fa5d670610274e876342177176360077492e2e094dbc2cba">[link]</a> </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>7 files</summary><table> <tr> <td><strong>logspage.spec.js</strong><dd><code>Add `logspage.spec.js` using `LogsPage` POM</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-b1a64252adae01c5e8f7e758e3c820f5476260f60c44a4a57b4f15a05a59a85a">+509/-0</a> </td> </tr> <tr> <td><strong>logsqueries.spec.js</strong><dd><code>Refactor `logsqueries.spec.js` to use `LogsPage`</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-c2055f6cef1580b15c5f94f5c8c2e496a6e921332b48bad943bb7c0630846a65">+136/-127</a></td> </tr> <tr> <td><strong>logshistogram.spec.js</strong><dd><code>Refactor `logshistogram.spec.js` for POM usage</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-d01da1c5a03b1d1c1c74e11f6e4ebe879def1ce87e407aa9a1afc8473040f4bc">+74/-63</a> </td> </tr> <tr> <td><strong>indexquery.spec.js</strong><dd><code>Rename and use `selectStream` helper</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-0fdb3410e34d127b97b20feda5f1c5f244f23af2d2d88c331ab753a1f434d3b1">+2/-2</a> </td> </tr> <tr> <td><strong>region.spec.js</strong><dd><code>Rename `selectStream` in region tests</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-b90cf78e7ef83f1fa7e5b8ebb9639604d26888afaa0b2083381de89131063ec8">+2/-2</a> </td> </tr> <tr> <td><strong>enrichment.spec.js</strong><dd><code>Update import path to `logsPages/logsPage.js`</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-1c26b9ac51f49e25aa8fe1ad6ae5376da50d27be032579c4194b62e5e798a76b">+3/-3</a> </td> </tr> <tr> <td><strong>sanity.spec.js</strong><dd><code>Update `LogsPage` import and stream selection</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-53b3ede269fef5199fbaea935f79134b50ba4db51edc517e4b1701f2cbcc5130">+2/-2</a> </td> </tr> </table></details></td></tr><tr><td><strong>Additional files</strong></td><td><details><summary>23 files</summary><table> <tr> <td><strong>playwright.yml</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+4/-4</a> </td> </tr> <tr> <td><strong>logsPage.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-6af0f73f0523e6fccd38532cb454dc58c4ef1fe4ef5bc5a135ef3f0ee5371ef6">+0/-830</a> </td> </tr> <tr> <td><strong>streamsPage.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-792df584eb1625d35fd1e33a5a37aa3ada28f15ec1e77a1921f1c56e50bf70d2">+1/-1</a> </td> </tr> <tr> <td><strong>logsquickmode.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-81f2f36450c07435f1b0f3c33462c7dac98c0798250913ae5ed928f57ad82cdf">+58/-92</a> </td> </tr> <tr> <td><strong>changeOrg.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-607c77ca637716a5b8d37ec25dbaf7dc91cddd7d981b72f9c460f54498d14351">+1/-1</a> </td> </tr> <tr> <td><strong>dashboard-folder.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-bdb8f953e350e378f4196ea1b74fa60961dbe7e87ea34b77e551e77983ab0360">+1/-1</a> </td> </tr> <tr> <td><strong>dashboardtype.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-40ee9b1480e11efe6a8fcbdd9c28e2881ef564783b43e12aaa86f2b3cc7d8bc6">+2/-2</a> </td> </tr> <tr> <td><strong>visualization-vrl.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-4bfe28b08994ca0333edbe51bc99d3ddf05525387e90932d88681028e1947db4">+2/-2</a> </td> </tr> <tr> <td><strong>visualize.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-d144f23552ec150db375c89e52c3a53ede9ff3fa5dcd6092694fbe0a308d22ec">+2/-2</a> </td> </tr> <tr> <td><strong>join.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-e039a16bb79192216b3fb8ecfc745db63f48c43e73a9305ed6adb54c4a9dd683">+1/-1</a> </td> </tr> <tr> <td><strong>logspage.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-950a38f6d66dbcf4f7cb39dc366ab25f533044718edee8199d7f819c5b06efe3">+0/-582</a> </td> </tr> <tr> <td><strong>multiselect-stream.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-e2eb0d6de0ad04a42b73cce92a1c86e68213fed79bd7507ea00abfe18a2633c7">+2/-2</a> </td> </tr> <tr> <td><strong>pagination.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-5e44451149ef320c6c78668ff2a42a152fdc7b0565838c8d7f7385f5d4809cb5">+1/-1</a> </td> </tr> <tr> <td><strong>pipeline-core.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-e6249b045437e7f087b825dc0ee2d8ccebed0894d10c84b7bc9b12dca7a25754">+2/-2</a> </td> </tr> <tr> <td><strong>pipelines.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-9b48f5edc53f2413789549b189d4a80f134a320dd5beebf96d738069eb43033a">+2/-2</a> </td> </tr> <tr> <td><strong>remotepipeline.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-3b5a97115bd312e7490580fa00af21077ea5050915995bd133a7f5fd913e5394">+2/-2</a> </td> </tr> <tr> <td><strong>sanity2.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-f1ab4c6d536ebc3b8ea7ff17d2954d86ef56b660dcfaa1bb39f8213a5bf92e22">+2/-2</a> </td> </tr> <tr> <td><strong>schema.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-1212ad9c33ea14a5a660923b20c162380c9d8c27ffa64993ddfc827e4d82a208">+2/-2</a> </td> </tr> <tr> <td><strong>schemaload.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-768d758450ec41815b1330503394239673698045f5c29e46fc05d7b475c037ea">+1/-1</a> </td> </tr> <tr> <td><strong>searchpartition.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-557a8fcb7159dd28b9a8fd9c0657b5882297c650ef4f22a2d2213211a42b17ea">+2/-2</a> </td> </tr> <tr> <td><strong>secondsPrecisionAdded.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-bd92ad86063b90d67a50098a8ba722ef9b232f950a7c53604ae898043af7abfb">+1/-1</a> </td> </tr> <tr> <td><strong>unflattened.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-a5e0a62966202ad510f4be2cd89e91c1d34eaf48d179e5725d532f1d7fb92b4e">+2/-2</a> </td> </tr> <tr> <td><strong>websocket.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7490/files#diff-1f356bcfb18ed299a284a4c81893d73612faf9bac3941430f30d7c1b2d105540">+1/-1</a> </td> </tr> </table></details></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details>