mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
ktx-akshay
1ee98654ca
### **PR Type**
Bug fix, Tests
___
### **Description**
- Stabilize dashboard chart rendering waits
- Replace network idle with canvas detection
- Add explicit chart render wait helper
- Adjust workflow Node action version
___
### Diagram Walkthrough
```mermaid
flowchart LR
Tests["Dashboard tests"] -- "add render waits" --> Transpose["Transpose spec"]
Tests -- "replace networkidle with selector" --> DashboardSpec["Dashboard spec"]
CI["Playwright workflow"] -- "use setup-node v4" --> NodeSetup["Node action updated"]
```
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>dashboard-transpose.spec.js</strong><dd><code>Add
explicit chart render wait in transpose test</code>
</dd></summary>
<hr>
tests/ui-testing/playwright-tests/dashboards/dashboard-transpose.spec.js
<ul><li>Wait for chart render after apply<br> <li> Update comments to
reflect rendering wait</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8840/files#diff-da631007cea76a4bc59e4acd1195b59ae4131cd5208d21a9c1f94d3913911dc4">+3/-2</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>dashboard.spec.js</strong><dd><code>Use canvas-based
wait to reduce flakiness</code>
</dd></summary>
<hr>
tests/ui-testing/playwright-tests/dashboards/dashboard.spec.js
<ul><li>Replace networkidle waits with canvas selector<br> <li> Add
targeted wait for chart canvas attachment<br> <li> Remove redundant
networkidle wait</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8840/files#diff-d0fa0042783dc109334b05266edce228bad97adcb568dd1e447920596238e9b4">+5/-3</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Configuration
changes</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>playwright.yml</strong><dd><code>Update GitHub Action
setup-node to v4</code>
</dd></summary>
<hr>
.github/workflows/playwright.yml
<ul><li>Downgrade actions/setup-node from v5 to v4<br> <li> Keep Node.js
version at 22</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8840/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+1/-1</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___