mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-06 08:09:24 +00:00
## What changed
Naming an alert, panel, workflow, pipeline or function meant inventing a
name up front in a form field before anything else could be configured.
Two pieces replace that.
**Inline rename** — the page title *is* the input. `OInlineEdit` /
`OFormInlineEdit` (`web/src/lib/forms/InlineEdit`): click to rename,
Enter or blur commits, Escape restores the pre-edit value. A `#trail`
slot carries the "Auto" badge in display mode only.
**Auto-generated names** — `utils/autoName.ts` builds the name,
`composables/useAutoName.ts` decides when it's allowed to win. A name is
AUTO until the user types, then it's theirs for good; clearing the field
and blurring re-arms auto. The generators describe only what is actually
configured, so a half-built panel yields a shorter name rather than a
speculative one, and an empty string when there is nothing to say.
- Panel names read as prose — `Avg of duration by service`, `Record
count`, `k8s_logs overview`. Both live panel-field shapes are handled
(builder `functionName` + `args`, and legacy flat `column` +
`aggregationFunction`); the time column is read from
`zoConfig.timestamp_column` rather than hardcoded. Hand-written queries
fall back to the stream, since naming a panel after `x_axis_1` is worse
than saying nothing.
- Alert names are identifiers — `anomaly_k8s_logs`,
`k8s_logs_status_gte_500` — built to survive the backend's
`RE_OFGA_UNSUPPORTED_NAME` rule, with operators spelled out and a
`slugify` backstop. A leading underscore is preserved so internal
streams (`_rumdata`) keep their names.
### Supporting library changes
| Component | Change |
| --- | --- |
| `OPageHeader` / `OPageLayout` | New `titleOverflow="visible"` — the
`<h1>`'s `truncate` clips an interactive title's focus ring and the
error message it floats below itself |
| `OSelect` | New `appearance="inline"` — borderless, no fixed height,
sized to content, for a value that reads as a word inside running text
("Add Alert **in KTX**") |
All new strings go through i18n (`common.inlineEdit.*`,
`dashboard.autoName.*`, `alerts.autoName.*`, per-module `renameHint`).
Interpolated identifiers — column names, SQL functions, stream names —
stay verbatim.
## Wired into
AddPanel, AddAlert (+ `useAlertForm`), WorkflowEditor, PipelineEditor,
Functions / FunctionsToolbar, IncidentDetailDrawer,
InlineSelectFolderDropdown.
## Tested
244 unit tests across the 5 affected suites, all passing — including new
specs for `OInlineEdit`, `useAutoName`, and `autoName`.
One pre-existing expectation in `autoName.spec.ts` was updated: it
asserted `Avg of duration, max of duration +1 more`, capitalising only
the first word of a multi-measure name. `measureLabel` capitalises per
measure by design, so the expectation now reads `Avg of duration, Max of
duration +1 more`.
---------
Co-authored-by: ktx-vaidehi <134508096+ktx-vaidehi@users.noreply.github.com>
Co-authored-by: ktx-vaidehi <vaidehi.akhani@kiara.tech>
337 lines
15 KiB
JavaScript
337 lines
15 KiB
JavaScript
// Copyright 2026 OpenObserve Inc.
|
|
|
|
const { expect } = require('@playwright/test');
|
|
const testLogger = require('../../playwright-tests/utils/test-logger.js');
|
|
|
|
class FunctionsFormValidationPage {
|
|
constructor(page) {
|
|
this.page = page;
|
|
|
|
// ==================== AddFunction / FunctionsToolbar locators ====================
|
|
|
|
// Name is an inline-edited title (OFormInlineEdit): a display trigger swaps
|
|
// to an input on click; -error is the validation message.
|
|
this.functionNameTrigger = page.locator('[data-test="add-function-name-input-trigger"]');
|
|
this.functionNameField = page.locator('[data-test="add-function-name-input-input"]');
|
|
this.functionNameError = page.locator('[data-test="add-function-name-input-error"]');
|
|
|
|
// VRL editor wrapper
|
|
this.functionEditor = page.locator('[data-test="logs-vrl-function-editor"]');
|
|
|
|
// Action buttons
|
|
this.saveButton = page.locator('[data-test="add-function-save-btn"]');
|
|
this.cancelButton = page.locator('[data-test="add-function-cancel-btn"]');
|
|
this.backButton = page.locator('[data-test="add-function-back-btn"]');
|
|
|
|
// Toast notifications
|
|
this.toastSuccess = page.locator('[data-test-variant="success"]');
|
|
this.toastError = page.locator('[data-test-variant="error"]');
|
|
|
|
// ==================== AddEnrichmentTable locators ====================
|
|
|
|
// Add form root
|
|
this.enrichmentPage = page.locator('[data-test="add-enrichment-table-page"]');
|
|
|
|
// Name field (OInput)
|
|
this.enrichmentNameField = page.locator('[data-test="add-enrichment-table-name-field"]');
|
|
this.enrichmentNameError = page.locator('[data-test="add-enrichment-table-name-error"]');
|
|
|
|
// File upload (OFile — derives -field automatically; -error for validation msg)
|
|
this.enrichmentFileField = page.locator('[data-test="add-enrichment-table-file-field"]');
|
|
this.enrichmentFileError = page.locator('[data-test="add-enrichment-table-file-error"]');
|
|
|
|
// URL field (OInput for URL source)
|
|
this.enrichmentUrlField = page.locator('[data-test="add-enrichment-table-url-field"]');
|
|
this.enrichmentUrlError = page.locator('[data-test="add-enrichment-table-url-error"]');
|
|
|
|
// Source toggle (OOptionGroup — file vs url)
|
|
this.enrichmentSourceGroup = page.locator('[data-test="add-enrichment-table-source"]');
|
|
|
|
// Footer buttons
|
|
this.enrichmentSaveButton = page.locator('[data-test="add-enrichment-table-save-btn"]');
|
|
this.enrichmentCancelButton = page.locator('[data-test="add-enrichment-table-cancel-btn"]');
|
|
this.enrichmentBackButton = page.locator('[data-test="add-enrichment-table-back-btn"]');
|
|
|
|
// Add enrichment button on list page
|
|
this.enrichmentAddButton = page.locator('[data-test="enrichment-tables-add-btn"]');
|
|
|
|
// Pipeline / enrichment navigation
|
|
this.enrichmentTableTab = page.locator('[data-test="pipeline-section-tab-enrichmentTables"]');
|
|
|
|
// Add function button on functions list
|
|
this.addFunctionButton = page.locator('[data-test="function-list-add-function-btn"]');
|
|
|
|
// ==================== FunctionsToolbar locators ====================
|
|
|
|
// VRL / JS transform type radios
|
|
this.vrlRadio = page.locator('[data-test="function-transform-type-vrl-radio"]');
|
|
this.jsRadio = page.locator('[data-test="function-transform-type-js-radio"]');
|
|
|
|
// ==================== StreamRouting locators ====================
|
|
|
|
// StreamRouting panel root
|
|
this.streamRoutingSection = page.locator('[data-test="add-stream-routing-section"]');
|
|
|
|
// Close icon
|
|
this.streamRoutingCloseBtn = page.locator('[data-test="stream-routing-close-dialog-btn"]');
|
|
|
|
// Destination name input (OInput — derives -field and -error)
|
|
this.streamRoutingDestNameField = page.locator('[data-test="stream-routing-destination-name-input-field"]');
|
|
this.streamRoutingDestNameError = page.locator('[data-test="stream-routing-destination-name-input-error"]');
|
|
|
|
// Stream type select (OSelect — derives -error)
|
|
this.streamRoutingStreamTypeError = page.locator('[data-test="add-alert-stream-type-select-error"]');
|
|
|
|
// Stream name select (OSelect — derives -error)
|
|
this.streamRoutingStreamNameError = page.locator('[data-test="add-alert-stream-select-error"]');
|
|
|
|
// Save / Cancel buttons
|
|
this.streamRoutingSaveBtn = page.locator('[data-test="add-report-save-btn"]');
|
|
this.streamRoutingCancelBtn = page.locator('[data-test="add-report-cancel-btn"]');
|
|
|
|
// Pipeline add-routing button (if available in the pipeline view)
|
|
this.addStreamRoutingButton = page.locator('[data-test="pipeline-add-stream-routing-btn"]');
|
|
}
|
|
|
|
// ==================== Navigation ====================
|
|
|
|
async navigateToFunctions(org) {
|
|
const targetOrg = org || process.env.ORGID;
|
|
testLogger.info(`Navigating to functions page for org: ${targetOrg}`);
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/functions?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
}
|
|
|
|
async navigateToEnrichmentTables(org) {
|
|
const targetOrg = org || process.env.ORGID;
|
|
testLogger.info(`Navigating to enrichment tables for org: ${targetOrg}`);
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/functions?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
await this.enrichmentTableTab.waitFor({ state: 'visible', timeout: 15000 });
|
|
await this.enrichmentTableTab.click();
|
|
await this.page.waitForLoadState('networkidle', { timeout: 10000 }).catch(() => {});
|
|
}
|
|
|
|
// ==================== Add Function actions ====================
|
|
|
|
async openAddFunctionForm(org) {
|
|
await this.navigateToFunctions(org);
|
|
await this.addFunctionButton.waitFor({ state: 'visible', timeout: 15000 });
|
|
await this.addFunctionButton.click();
|
|
// The name trigger is what renders in display mode (the input only appears
|
|
// once the trigger is clicked) — wait on it as the form-open signal.
|
|
await this.functionNameTrigger.waitFor({ state: 'visible', timeout: 15000 });
|
|
testLogger.info('Add Function form opened');
|
|
}
|
|
|
|
async fillFunctionName(name) {
|
|
testLogger.info(`Filling function name: ${name}`);
|
|
// Open the inline editor, then fill the revealed input.
|
|
await this.functionNameTrigger.waitFor({ state: 'visible' });
|
|
await this.functionNameTrigger.click();
|
|
await this.functionNameField.waitFor({ state: 'visible' });
|
|
await this.functionNameField.fill(name);
|
|
}
|
|
|
|
async clickSave() {
|
|
testLogger.info('Clicking Save button');
|
|
await this.saveButton.waitFor({ state: 'visible' });
|
|
await this.saveButton.click();
|
|
}
|
|
|
|
async expectFunctionNameError(message) {
|
|
testLogger.info(`Expecting function name error: ${message}`);
|
|
await this.functionNameError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.functionNameError).toBeVisible();
|
|
if (message) {
|
|
await expect(this.functionNameError).toContainText(message);
|
|
}
|
|
}
|
|
|
|
async expectFunctionNameErrorVisible() {
|
|
testLogger.info('Expecting function name error to be visible');
|
|
await this.functionNameError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.functionNameError).toBeVisible();
|
|
}
|
|
|
|
async typeInVrlEditor(code) {
|
|
testLogger.info('Typing VRL code into editor');
|
|
await this.functionEditor.waitFor({ state: 'visible', timeout: 15000 });
|
|
// Focus the editor. Monaco is a lazy-loaded async chunk, so the wrapper
|
|
// (data-test element) renders BEFORE the Monaco instance is registered.
|
|
await this.functionEditor.click();
|
|
|
|
const editorSelector = '[data-test="logs-vrl-function-editor"]';
|
|
|
|
// Poll until Monaco has loaded AND the function editor is registered. The
|
|
// page also mounts a separate Query editor, so scope the match to this
|
|
// container. This replaces a fixed 300ms sleep that raced Monaco's load on
|
|
// slow CI runners — a miss left the editor empty, submitting an empty
|
|
// function body (backend 400 "Function body cannot be empty", no success toast).
|
|
await this.page.waitForFunction((sel) => {
|
|
const editors = window.monaco?.editor?.getEditors?.();
|
|
const container = document.querySelector(sel);
|
|
return !!(container && editors?.some(e => container.contains(e.getContainerDomNode())));
|
|
}, editorSelector, { timeout: 15000 });
|
|
|
|
// Type the content as a real user via Monaco's textarea. This is deliberate:
|
|
// executeEdits() sets the model value but does NOT drive the editor's
|
|
// onDidChangeModelContent listener that syncs @update:query → formData.function,
|
|
// so a save afterwards submits an empty function body (backend 400
|
|
// "Function body cannot be empty", no success toast). Real keystrokes fire it.
|
|
// Click the VISIBLE editor surface (.view-lines) to focus Monaco — its
|
|
// <textarea.inputarea> is a 1px hidden input Playwright refuses to click.
|
|
await this.functionEditor.locator('.view-lines').first().click();
|
|
await this.page.keyboard.type(code, { delay: 20 });
|
|
|
|
// Confirm the content actually landed in the Monaco model.
|
|
await this.page.waitForFunction(({ sel, vrlCode }) => {
|
|
const editors = window.monaco?.editor?.getEditors?.();
|
|
const container = document.querySelector(sel);
|
|
const targetEditor = editors?.find(e => container?.contains(e.getContainerDomNode()));
|
|
return targetEditor?.getModel()?.getValue() === vrlCode;
|
|
}, { sel: editorSelector, vrlCode: code }, { timeout: 5000 });
|
|
|
|
// The editor's @update:query emit is DEBOUNCED (500ms) and flushed on blur.
|
|
// Blur the editor (focus the name field) so formData.function updates
|
|
// immediately — deterministic instead of racing the debounce timer. Clicking
|
|
// the inline-edit trigger moves focus off Monaco (and opens the name editor).
|
|
await this.functionNameTrigger.click();
|
|
await this.page.waitForTimeout(200);
|
|
}
|
|
|
|
async expectSuccessToast() {
|
|
testLogger.info('Waiting for success toast');
|
|
await this.toastSuccess.waitFor({ state: 'visible', timeout: 15000 });
|
|
await expect(this.toastSuccess).toBeVisible();
|
|
}
|
|
|
|
// ==================== Add Enrichment Table actions ====================
|
|
|
|
async openAddEnrichmentTableForm(org) {
|
|
await this.navigateToEnrichmentTables(org);
|
|
await this.enrichmentAddButton.waitFor({ state: 'visible', timeout: 15000 });
|
|
await this.enrichmentAddButton.click();
|
|
await this.enrichmentPage.waitFor({ state: 'visible', timeout: 15000 });
|
|
testLogger.info('Add Enrichment Table form opened');
|
|
}
|
|
|
|
async fillEnrichmentName(name) {
|
|
testLogger.info(`Filling enrichment table name: ${name}`);
|
|
await this.enrichmentNameField.waitFor({ state: 'visible' });
|
|
await this.enrichmentNameField.fill(name);
|
|
}
|
|
|
|
async clickEnrichmentSave() {
|
|
testLogger.info('Clicking enrichment table Save button');
|
|
await this.enrichmentSaveButton.waitFor({ state: 'visible' });
|
|
await this.enrichmentSaveButton.click();
|
|
}
|
|
|
|
async expectEnrichmentNameError(message) {
|
|
testLogger.info(`Expecting enrichment name error: ${message}`);
|
|
await this.enrichmentNameError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.enrichmentNameError).toBeVisible();
|
|
if (message) {
|
|
await expect(this.enrichmentNameError).toContainText(message);
|
|
}
|
|
}
|
|
|
|
async expectEnrichmentFileError(message) {
|
|
testLogger.info(`Expecting enrichment file error: ${message}`);
|
|
await this.enrichmentFileError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.enrichmentFileError).toBeVisible();
|
|
if (message) {
|
|
await expect(this.enrichmentFileError).toContainText(message);
|
|
}
|
|
}
|
|
|
|
// ==================== FunctionsToolbar assertion helpers ====================
|
|
|
|
async assertVrlRadioSelected() {
|
|
testLogger.info('Asserting VRL radio is checked');
|
|
await this.vrlRadio.waitFor({ state: 'visible', timeout: 10000 });
|
|
// ORadio renders a native input — check aria-checked or checked attribute
|
|
const checked = await this.vrlRadio.evaluate(el => {
|
|
const input = el.querySelector('input[type="radio"]') || el.closest('[role="radio"]') || el;
|
|
return input.checked || el.getAttribute('aria-checked') === 'true' || el.getAttribute('data-state') === 'checked';
|
|
});
|
|
expect(checked).toBe(true);
|
|
}
|
|
|
|
// ==================== StreamRouting actions ====================
|
|
|
|
async openStreamRoutingForm(org) {
|
|
const targetOrg = org || process.env.ORGID;
|
|
testLogger.info('Opening StreamRouting form via pipeline page');
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/functions?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
// Attempt to open routing panel; fall back gracefully if not available in env
|
|
const routingBtn = this.addStreamRoutingButton;
|
|
const btnVisible = await routingBtn.isVisible({ timeout: 5000 }).catch(() => false);
|
|
if (btnVisible) {
|
|
await routingBtn.click();
|
|
await this.streamRoutingSection.waitFor({ state: 'visible', timeout: 10000 });
|
|
testLogger.info('StreamRouting panel opened via button');
|
|
} else {
|
|
// Navigate directly to routing view if the button is not available
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/stream-routing?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
await this.streamRoutingSection.waitFor({ state: 'visible', timeout: 15000 });
|
|
testLogger.info('StreamRouting panel opened via direct URL');
|
|
}
|
|
}
|
|
|
|
async fillStreamRoutingDestName(name) {
|
|
testLogger.info(`Filling stream routing destination name: ${name}`);
|
|
await this.streamRoutingDestNameField.waitFor({ state: 'visible', timeout: 10000 });
|
|
await this.streamRoutingDestNameField.fill(name);
|
|
await this.streamRoutingDestNameField.dispatchEvent('blur');
|
|
}
|
|
|
|
async clickStreamRoutingSave() {
|
|
testLogger.info('Clicking StreamRouting Save button');
|
|
await this.streamRoutingSaveBtn.waitFor({ state: 'visible' });
|
|
await this.streamRoutingSaveBtn.click();
|
|
}
|
|
|
|
async clickStreamRoutingClose() {
|
|
testLogger.info('Clicking StreamRouting close icon');
|
|
await this.streamRoutingCloseBtn.waitFor({ state: 'visible' });
|
|
await this.streamRoutingCloseBtn.click();
|
|
}
|
|
|
|
async assertStreamRoutingNameErrorVisible() {
|
|
testLogger.info('Asserting stream routing destination name error visible');
|
|
await expect(this.streamRoutingDestNameError).toBeVisible({ timeout: 5000 });
|
|
}
|
|
|
|
async assertStreamRoutingStreamTypeErrorVisible() {
|
|
testLogger.info('Asserting stream routing stream type error visible');
|
|
await expect(this.streamRoutingStreamTypeError).toBeVisible({ timeout: 5000 });
|
|
}
|
|
|
|
async selectUrlSource() {
|
|
testLogger.info('Selecting URL data source');
|
|
// OOptionGroup renders each option — click the "url" option
|
|
const urlOption = this.enrichmentSourceGroup.locator('[data-value="url"], [value="url"]').first();
|
|
// Fallback: click by visible text
|
|
const urlBtn = this.enrichmentSourceGroup.getByText('From URL').first();
|
|
await urlBtn.waitFor({ state: 'visible', timeout: 5000 }).catch(async () => {
|
|
await urlOption.click();
|
|
});
|
|
await urlBtn.click().catch(() => urlOption.click());
|
|
testLogger.info('URL source selected');
|
|
}
|
|
}
|
|
|
|
module.exports = FunctionsFormValidationPage;
|