Abhay Padamani
fad1692855
### **User description** fix #8565 ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Block SELECT * queries in visualization - Respect SQL vs builder modes for query source - Display user-friendly error notification - Guarded by quick mode configuration flag ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Toggle visualization"] -- "determine query source" --> B["Build or read SQL"] B -- "quick mode enabled?" --> C["Check SELECT * pattern"] C -- "is SELECT *" --> D["Show error notification"] C -- "not SELECT *" --> E["Proceed to extract fields"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>Index.vue</strong><dd><code>Add guard against SELECT * for visualization</code> </dd></summary> <hr> web/src/plugins/logs/Index.vue <ul><li>Determine SQL from builder or raw mode.<br> <li> Detect simple SELECT * queries in quick mode.<br> <li> Block visualization and notify on invalid query.</ul> </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/8568/files#diff-0323c3da69b369843c5d72bf4df5b00ca6b5147192a213baf331659ecf92af62">+21/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> </details> ___
web
This template should help get you started developing with Vue 3 in Vite.
Recommended IDE Setup
VSCode + Volar (and disable Vetur) + TypeScript Vue Plugin (Volar).
Type Support for .vue Imports in TS
TypeScript cannot handle type information for .vue imports by default, so we replace the tsc CLI with vue-tsc for type checking. In editors, we need TypeScript Vue Plugin (Volar) to make the TypeScript language service aware of .vue types.
If the standalone TypeScript plugin doesn't feel fast enough to you, Volar has also implemented a Take Over Mode that is more performant. You can enable it by the following steps:
- Disable the built-in TypeScript Extension
- Run
Extensions: Show Built-in Extensionsfrom VSCode's command palette - Find
TypeScript and JavaScript Language Features, right click and selectDisable (Workspace)
- Run
- Reload the VSCode window by running
Developer: Reload Windowfrom the command palette.
Customize configuration
See Vite Configuration Reference.
Project Setup
npm install
Compile and Hot-Reload for Development
For stand-alone UI development environment, create .env file and which contains below environment variable
VITE_OPENOBSERVE_ENDPOINT=http://localhost:5080/
npm run dev
Type-Check, Compile and Minify for Production
npm run build
Run Unit Tests with Vitest
npm run test:unit
Run End-to-End Tests with Cypress
npm run test:e2e:dev
This runs the end-to-end tests against the Vite development server. It is much faster than the production build.
But it's still recommended to test the production build with test:e2e before deploying (e.g. in CI environments):
npm run build
npm run test:e2e
Lint with ESLint
npm run lint