starred/openobserve

Fork 0

mirror of https://github.com/openobserve/openobserve.git synced 2026-11-04 00:08:55 +00:00

Files

T

History

e9266c4510 fix: restore retry guard in enrichment table URL validation (#12218 )

Fixes https://github.com/openobserve/o2-enterprise/issues/1796 (item 1:
"Reload Existing URLs" returns error).

## Summary

Commit
[`85d261b5d0`](https://github.com/openobserve/openobserve/commit/85d261b5d0e4b68dbc79ca18b844fc53e2368ee9)
(vulnerability scan fixes, Apr 14 2026) removed the `!retry` guard from
enrichment table URL validation. This broke the **reload** update mode
because the frontend sends an empty URL when retrying/reprocessing
existing URLs — the backend already has them stored and just needs to
re-trigger processing.

## Root Cause

Before the breaking commit, URL validation was guarded by `!retry`:
```rust
if !retry && let Err(err_msg) = validate_enrichment_url(&request_body.url) {
    return MetaHttpResponse::bad_request(err_msg);
}
```

The security fix removed the guard under the assumption that skipping
validation on retry was an SSRF bypass vector. However, the retry flow
sends `url=""` intentionally — the existing URLs are in the database.

## Fix

Re-adds the `!retry` guard around URL validation. In retry mode, URL
validation is skipped entirely (the URLs come from DB). All other modes
(create, append, replace, replace_failed) still require a non-empty,
valid URL with full SSRF protection.

## Test Plan

- [ ] Create enrichment table from URL
- [ ] Edit table → Reload existing URLs → Should succeed (no "URL cannot
be empty")
- [ ] Edit table → Add new URL → Should still validate URL format
- [ ] Edit table → Replace all URLs → Should still validate URL format
- [ ] Edit table → Replace failed URL → Should still validate URL format

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: Subhradeep Chakraborty <chakrabortysubhradeep556@gmail.com>

2026-05-25 17:00:13 +00:00

fixtures/sourcemaps

test: add E2E tests for RUM sourcemap feature (#11014 )

2026-03-28 20:57:48 +05:30

src

feat: integrate API integration testing using pytest (#2250 )

2023-12-27 16:59:41 +01:00

tests

fix: restore retry guard in enrichment table URL validation (#12218 )

2026-05-25 17:00:13 +00:00

.gitignore

test: match_all_camelcase_tests (#9345 )

2025-11-27 15:04:13 +05:30

.python-version

refactor: API Integration Tests workflow (#2324 )

2023-12-29 07:39:09 +01:00

env.sh

fix: payload limit (#10021 )

2026-01-14 16:54:35 +08:00

Makefile

feat: integrate API integration testing using pytest (#2250 )

2023-12-27 16:59:41 +01:00

pyproject.toml

perf: pushdown plan (#7778 )

2025-07-31 14:31:33 +08:00

README.md

fix: payload limit (#10021 )

2026-01-14 16:54:35 +08:00

requirements-dev.lock

fix: payload limit (#10021 )

2026-01-14 16:54:35 +08:00

requirements.lock

fix: payload limit (#10021 )

2026-01-14 16:54:35 +08:00

README.md

pytest-openobserve

This is a repo to test openobserve API endpoints.

Introduction:

The tests are running using pytest against alpha1 for now. Idea is to parametrize it for the other endpoints like production as well.

Getting Started

We use rye to manage the python version and environment - https://github.com/mitsuhiko/rye
Once installed, simply run the following steps:
- rye sync
- rye run pytest

TODOS:

Parametrize tests to run against different environments
Run the tests as cron-job every few hours or daily etc. for different environments
Send slack-notification ( use github-actions ) in case something fails on alpha1 or production endpoints.