mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-05 08:09:22 +00:00
Simha G
07e7637a13
### **User description**
# PR Type
Fix
# Description
Default config values of query recommendations generate far too few
updates. Current change will generate a recommendation every one hour
for the last one hour's usage.
___
### **PR Type**
Bug fix, Documentation
___
### **Description**
- Correct interval unit for recommendations
- Clarify duration unit with comment
- Keep hourly analysis intent intact
___
### Diagram Walkthrough
```mermaid
flowchart LR
cfg["config.rs Limits"] -- "add unit comments" --> dur["ZO_QUERY_RECOMMENDATION_DURATION"]
cfg -- "fix interval units" --> intv["ZO_QUERY_RECOMMENDATION_INTERVAL"]
```
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Bug
fix</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>config.rs</strong><dd><code>Fix recommendation interval
default and document units</code> </dd></summary>
<hr>
src/config/src/config.rs
<ul><li>Added unit comment to
<code>ZO_QUERY_RECOMMENDATION_DURATION</code> (microseconds).<br> <li>
Changed <code>ZO_QUERY_RECOMMENDATION_INTERVAL</code> default from
3600000000 to <br>3600 (seconds).<br> <li> Added unit comment to
<code>ZO_QUERY_RECOMMENDATION_INTERVAL</code> (seconds).</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8817/files#diff-9aeee4a74c0520daa40f9b81c7016f5b6b3254375b968dd7598e745630980d62">+2/-2</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___