mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-05 08:09:22 +00:00
### **PR Type**
Tests, Enhancement
___
### **Description**
- Add comprehensive org CRUD Playwright tests
- Implement org delete via API and UI
- Add helper to extract org identifier
- Fix verifyOrgNotExists usage and CI suite
___
### Diagram Walkthrough
```mermaid
flowchart LR
Tests["New Playwright org tests"] -- "uses" --> CreateOrgPage["CreateOrgPage page object"]
CreateOrgPage -- "adds" --> DeleteAPI["deleteOrgViaAPI()"]
CreateOrgPage -- "adds" --> DeleteUI["deleteOrgViaUI()"]
CreateOrgPage -- "adds" --> GetIdentifier["getOrgIdentifierFromTable()"]
Workflow["GitHub Actions workflow"] -- "runs" --> Tests
```
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>createOrgPage.js</strong><dd><code>Enhance
CreateOrgPage with delete and identifier utilities</code></dd></summary>
<hr>
tests/ui-testing/pages/generalPages/createOrgPage.js
<ul><li>Import Playwright <code>expect</code>.<br> <li> Remove param
from <code>verifyOrgNotExists</code>.<br> <li> Add
<code>deleteOrgViaAPI</code> with Basic Auth DELETE call.<br> <li> Add
<code>deleteOrgViaUI</code> with fallback selectors and confirm
flow.<br> <li> Add <code>getOrgIdentifierFromTable</code> utility
parsing table cells.</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8362/files#diff-e3ff7268323b35f1798acb81fcd3541e0d2ee7c283124a064854ac9f6e67beb8">+113/-3</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Tests</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>org.spec.js</strong><dd><code>New Playwright org
management E2E tests</code>
</dd></summary>
<hr>
tests/ui-testing/playwright-tests/GeneralTests/org.spec.js
<ul><li>Add full CRUD and validation test suite.<br> <li> Cover API/UI
creation, search, negatives, special chars.<br> <li> Implement cleanup
via API with UI fallback.<br> <li> Use test logger and base navigation
setup.</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8362/files#diff-ab00b9371adadcb16226e3afb422dcab9e6fb0b99a3b43766d4bdda6b12f4378">+556/-0</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>usersOrg.spec.js</strong><dd><code>Fix
verifyOrgNotExists usage in user-org tests</code>
</dd></summary>
<hr>
tests/ui-testing/playwright-tests/GeneralTests/usersOrg.spec.js
<ul><li>Update <code>verifyOrgNotExists</code> call signature.<br> <li>
Remove redundant <code>expect</code> argument.</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8362/files#diff-0bf40521e88d2cf427617e49affa14d4ebe469b6da4ea4aeef4fe3e246eb24c7">+1/-1</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Configuration
changes</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>playwright.yml</strong><dd><code>Run organization tests
in CI workflow</code>
</dd></summary>
<hr>
.github/workflows/playwright.yml
<ul><li>Add <code>org.spec.js</code> to CI run files.<br> <li> Ensure
org tests run in workflow.</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8362/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+1/-0</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___
312 lines
14 KiB
JavaScript
312 lines
14 KiB
JavaScript
const { test, expect, navigateToBase } = require('../utils/enhanced-baseFixtures.js');
|
|
const PageManager = require('../../pages/page-manager.js');
|
|
const testLogger = require('../utils/test-logger.js');
|
|
|
|
test.describe.configure({ mode: 'parallel' });
|
|
|
|
test.describe("Users and Organizations", () => {
|
|
let pageManager;
|
|
|
|
test("Error Message displayed if Email Blank", async ({ page }, testInfo) => {
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser("");
|
|
await pageManager.userPage.userCreate();
|
|
await pageManager.userPage.verifySuccessMessage('Please enter a valid email address');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("Error Message displayed if Add user with missing role", async ({ page }, testInfo) => {
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.userCreate();
|
|
await pageManager.userPage.verifySuccessMessage('Field is required');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User created with password and first name and last name", async ({ page }, testInfo) => {
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.addUserPassword(process.env["ZO_ROOT_USER_PASSWORD"]);
|
|
await pageManager.userPage.addUserFirstLast('a', 'b');
|
|
await pageManager.userPage.userCreate();
|
|
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.verifySuccessMessage('User added successfully.');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User not created if Email already exists", async ({ page }, testInfo) => {
|
|
const duplicateEmail = `duplicate${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(duplicateEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.addUserPassword(process.env["ZO_ROOT_USER_PASSWORD"]);
|
|
await pageManager.userPage.addUserFirstLast('a', 'b');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await pageManager.userPage.verifySuccessMessage('User added successfully.');
|
|
await page.waitForLoadState('networkidle');
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(duplicateEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await pageManager.userPage.userCreate();
|
|
await pageManager.userPage.verifySuccessMessage('User is already part of the organization');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User not created if Cancel clicked on first Add User Page", async ({ page }, testInfo) => {
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await page.locator('[data-test="cancel-user-button"]').click();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.searchUser(uniqueEmail);
|
|
await pageManager.userPage.verifyUserNotExists();
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User not created if Cancel clicked on second Add User Page", async ({ page }, testInfo) => {
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.addUserPassword(process.env["ZO_ROOT_USER_PASSWORD"]);
|
|
await pageManager.userPage.addUserFirstLast('a', 'b');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await page.locator('[data-test="cancel-user-button"]').click();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.searchUser(uniqueEmail);
|
|
await pageManager.userPage.verifyUserNotExists();
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User Created and deleted", async ({ page }, testInfo) => {
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.addUserPassword(process.env["ZO_ROOT_USER_PASSWORD"]);
|
|
await pageManager.userPage.addUserFirstLast('a', 'b');
|
|
await pageManager.userPage.userCreate();
|
|
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.verifySuccessMessage('User added successfully.');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.deleteUser(uniqueEmail);
|
|
await pageManager.userPage.verifySuccessMessage('User deleted successfully.');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User Created and not deleted if cancel clicked", async ({ page }, testInfo) => {
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.addUserPassword(process.env["ZO_ROOT_USER_PASSWORD"]);
|
|
await pageManager.userPage.addUserFirstLast('a', 'b');
|
|
await pageManager.userPage.userCreate();
|
|
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.verifySuccessMessage('User added successfully.');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.deleteUserCancel(uniqueEmail);
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.searchUser(uniqueEmail);
|
|
await pageManager.userPage.verifyUserExists(uniqueEmail);
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User Created and updated First Name and Last Name", async ({ page }, testInfo) => {
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.addUserPassword(process.env["ZO_ROOT_USER_PASSWORD"]);
|
|
await pageManager.userPage.addUserFirstLast('a', 'b');
|
|
await pageManager.userPage.userCreate();
|
|
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.verifySuccessMessage('User added successfully.');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.editUser(uniqueEmail);
|
|
await pageManager.userPage.addUserFirstLast('c', 'd');
|
|
await pageManager.userPage.userCreate();
|
|
await pageManager.userPage.verifySuccessMessage('User updated successfully.');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test("User Created and updated Password", async ({ page }, testInfo) => {
|
|
const uniqueEmail = `email${Date.now()}_${Math.floor(Math.random() * 10000)}@gmail.com`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.addUser(uniqueEmail);
|
|
await pageManager.userPage.selectUserRole('Admin');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.userCreate();
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.addUserPassword(process.env["ZO_ROOT_USER_PASSWORD"]);
|
|
await pageManager.userPage.addUserFirstLast('a', 'b');
|
|
await pageManager.userPage.userCreate();
|
|
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.verifySuccessMessage('User added successfully.');
|
|
await page.waitForLoadState('domcontentloaded');
|
|
await pageManager.userPage.gotoIamPage();
|
|
await pageManager.userPage.editUser(uniqueEmail);
|
|
await pageManager.userPage.addNewPassword('1234567890');
|
|
await pageManager.userPage.userCreate();
|
|
await pageManager.userPage.verifySuccessMessage('User updated successfully.');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test('Add Organization Successfully', async ({ page }, testInfo) => {
|
|
const uniqueOrgName = `Org${Date.now()}_${Math.floor(Math.random() * 10000)}`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.createOrgPage.navigateToOrg();
|
|
await pageManager.createOrgPage.clickAddOrg();
|
|
await pageManager.createOrgPage.fillOrgName(uniqueOrgName);
|
|
await pageManager.createOrgPage.clickSaveOrg();
|
|
await pageManager.userPage.verifySuccessMessage('Organization added successfully.');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test('Save button disabled if Add Organization with Empty Name', async ({ page }, testInfo) => {
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.createOrgPage.navigateToOrg();
|
|
await pageManager.createOrgPage.clickAddOrg();
|
|
await pageManager.createOrgPage.fillOrgName('');
|
|
await pageManager.createOrgPage.checkSaveEnabled();
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test('Organization not added if Cancel clicked', async ({ page }, testInfo) => {
|
|
const uniqueOrgName = `Org${Date.now()}_${Math.floor(Math.random() * 10000)}`;
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.createOrgPage.navigateToOrg();
|
|
await pageManager.createOrgPage.clickAddOrg();
|
|
await pageManager.createOrgPage.fillOrgName(uniqueOrgName);
|
|
await pageManager.createOrgPage.clickCancelButton();
|
|
await pageManager.createOrgPage.navigateToOrg();
|
|
await pageManager.createOrgPage.searchOrg(uniqueOrgName);
|
|
await pageManager.createOrgPage.verifyOrgNotExists();
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
|
|
test('Error Message displayed if Add Organization is blank', async ({ page }, testInfo) => {
|
|
testLogger.testStart(testInfo.title, testInfo.file);
|
|
|
|
await navigateToBase(page);
|
|
pageManager = new PageManager(page);
|
|
|
|
await pageManager.createOrgPage.navigateToOrg();
|
|
await pageManager.createOrgPage.clickAddOrg();
|
|
await pageManager.createOrgPage.fillOrgName('');
|
|
await page.locator('.q-field__bottom').click();
|
|
await pageManager.userPage.verifySuccessMessage('Name is required');
|
|
|
|
testLogger.info('Test completed successfully');
|
|
});
|
|
});
|