mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
Sai Nikhilandomkark06
5a51e28c85
### **PR Type**
Bug fix
___
### **Description**
- Show parent when children visible
- Filter rows by show before render
- Update empty/loading checks to filtered rows
- Limit items-size and rows to filtered data
___
### Diagram Walkthrough
```mermaid
flowchart LR
EditRole["EditRole.vue: set permission.show when children exist"]
PermissionsTable["PermissionsTable.vue: compute filtered rows"]
UI["UI: render/empty states use filtered rows"]
EditRole -- "propagate show to parent" --> PermissionsTable
PermissionsTable -- "use getFilteredRows" --> UI
```
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Bug
fix</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>EditRole.vue</strong><dd><code>Ensure parent permission
shows when children visible</code>
</dd></summary>
<hr>
web/src/components/iam/roles/EditRole.vue
<ul><li>Set <code>permission.show = true</code> when
<code>filteredEntities</code> exist<br> <li> Move show assignment before
entity slicing<br> <li> Preserve entity slicing for specific
permissions<br> <li> Clear temporary <code>filteredEntities</code> after
processing</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8644/files#diff-263b6bc7d29fdf8358c8437cd637f1350aa3733cc2706eae8ff00028686cc0f5">+4/-4</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>PermissionsTable.vue</strong><dd><code>Render only
visible rows via computed filter</code>
</dd></summary>
<hr>
web/src/components/iam/roles/PermissionsTable.vue
<ul><li>Add <code>getFilteredRows</code> computed to filter by
<code>row.show</code><br> <li> Replace <code>rows</code> with
<code>getFilteredRows</code> across template<br> <li> Update empty and
resource messages to use filtered length<br> <li> Import
<code>computed</code> and <code>defineEmits</code></ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8644/files#diff-609d4d7245b7309cf30cc45c22c996c6b068ebc042a9673e75ee3bbd2aa00a2a">+11/-7</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___
---------
Co-authored-by: omkark06 <omkar@zinclabs.io>
web
This template should help get you started developing with Vue 3 in Vite.
Recommended IDE Setup
VSCode + Volar (and disable Vetur) + TypeScript Vue Plugin (Volar).
Type Support for .vue Imports in TS
TypeScript cannot handle type information for .vue imports by default, so we replace the tsc CLI with vue-tsc for type checking. In editors, we need TypeScript Vue Plugin (Volar) to make the TypeScript language service aware of .vue types.
If the standalone TypeScript plugin doesn't feel fast enough to you, Volar has also implemented a Take Over Mode that is more performant. You can enable it by the following steps:
- Disable the built-in TypeScript Extension
- Run
Extensions: Show Built-in Extensionsfrom VSCode's command palette - Find
TypeScript and JavaScript Language Features, right click and selectDisable (Workspace)
- Run
- Reload the VSCode window by running
Developer: Reload Windowfrom the command palette.
Customize configuration
See Vite Configuration Reference.
Project Setup
npm install
Compile and Hot-Reload for Development
For stand-alone UI development environment, create .env file and which contains below environment variable
VITE_OPENOBSERVE_ENDPOINT=http://localhost:5080/
npm run dev
Type-Check, Compile and Minify for Production
npm run build
Run Unit Tests with Vitest
npm run test:unit
Run End-to-End Tests with Cypress
npm run test:e2e:dev
This runs the end-to-end tests against the Vite development server. It is much faster than the production build.
But it's still recommended to test the production build with test:e2e before deploying (e.g. in CI environments):
npm run build
npm run test:e2e
Lint with ESLint
npm run lint