mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
Sai Nikhil
c61975bbc8
### **PR Type**
Enhancement
___
### **Description**
- Add view-mode toggle between Alerts and Incidents
- Conditionally render alerts/incidents views with search
- Revamp IncidentList: server-side pagination and actions
- Support keyword search in incidents API service
___
### Diagram Walkthrough
```mermaid
flowchart LR
A["View Mode Toggle"] --> B["Alerts View"]
A --> C["Incidents View"]
```
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>incidents.ts</strong><dd><code>Support keyword search
in incidents API</code>
</dd></summary>
<hr>
web/src/services/incidents.ts
<ul><li>Add optional <code>keyword</code> parameter to <code>list</code>
method<br> <li> Append <code>&keyword=encodeURIComponent(keyword)</code>
when provided</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/9723/files#diff-ff3182e820c3a01b1ba243b2bccc18f5d9e2dfffc0ec3431742bf74ec499f05c">+5/-1</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>AlertList.vue</strong><dd><code>Add alerts/incidents
view toggle and UI</code>
</dd></summary>
<hr>
web/src/components/alerts/AlertList.vue
<ul><li>Add view-mode toggle UI and dynamic page title<br> <li>
Conditionally render Alerts view (folders, tabs, search) and Incidents
<br>view<br> <li> Manage <code>viewMode</code> state and sync with URL
query parameters<br> <li> Introduce incident search input and remove
incidents tab in alerts<br> <li> Add CSS for
<code>.view-mode-tabs</code>, <code>.page-title</code>, and dark
mode</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/9723/files#diff-be3e41b823e163b226ffc270d95cc4981e59c600851e4e0d10ee5e4ee994ac8e">+183/-17</a></td>
</tr>
<tr>
<td>
<details>
<summary><strong>IncidentList.vue</strong><dd><code>Revamp IncidentList
component UI and logic</code>
</dd></summary>
<hr>
web/src/components/alerts/IncidentList.vue
<ul><li>Rewrite incidents table with new columns and clickable rows<br>
<li> Implement server-side pagination, keyword search, and loading
state<br> <li> Add action buttons: acknowledge, resolve, reopen
incidents<br> <li> Integrate <code>NoData</code> component for empty
state<br> <li> Remove client-side filters in favor of server
support</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/9723/files#diff-953ad015996758a8c86e489499cd3b0a614501b99b0c9c5c242a299e34c24ff2">+174/-258</a></td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___
web
This template should help get you started developing with Vue 3 in Vite.
Recommended IDE Setup
VSCode + Volar (and disable Vetur) + TypeScript Vue Plugin (Volar).
Type Support for .vue Imports in TS
TypeScript cannot handle type information for .vue imports by default, so we replace the tsc CLI with vue-tsc for type checking. In editors, we need TypeScript Vue Plugin (Volar) to make the TypeScript language service aware of .vue types.
If the standalone TypeScript plugin doesn't feel fast enough to you, Volar has also implemented a Take Over Mode that is more performant. You can enable it by the following steps:
- Disable the built-in TypeScript Extension
- Run
Extensions: Show Built-in Extensionsfrom VSCode's command palette - Find
TypeScript and JavaScript Language Features, right click and selectDisable (Workspace)
- Run
- Reload the VSCode window by running
Developer: Reload Windowfrom the command palette.
Customize configuration
See Vite Configuration Reference.
Project Setup
npm install
Compile and Hot-Reload for Development
For stand-alone UI development environment, create .env file and which contains below environment variable
VITE_OPENOBSERVE_ENDPOINT=http://localhost:5080/
npm run dev
Type-Check, Compile and Minify for Production
npm run build
Run Unit Tests with Vitest
npm run test:unit
Run End-to-End Tests with Cypress
npm run test:e2e:dev
This runs the end-to-end tests against the Vite development server. It is much faster than the production build.
But it's still recommended to test the production build with test:e2e before deploying (e.g. in CI environments):
npm run build
npm run test:e2e
Lint with ESLint
npm run lint