mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
Neha PandClaude Opus 4.7
7ad182b167
Consolidated OSS-side changes for the vision preprocessor rollout. Two things bundled here — both small, both OSS-only, related by "unblocks test-assist real-issue verification." ## Change 1 — Caller filter fix (originally in #12972, now closed) **One-line fix** for `.github/workflows/test-assist-caller.yml`: ```yaml # BEFORE — broken (silently skipped every /verify-bug comment on real issues) github.event.issue.pull_request == null # AFTER — truthy negation, evaluates correctly for undefined fields !github.event.issue.pull_request ``` Yesterday: 5 `/verify-bug` comments on real issues (#12452, #12647, #12603, #12820, #11700 — all by @neha00290, MEMBER association) produced 5 caller runs with `conclusion: skipped` and empty steps arrays. Root cause: `== null` compared against an *undefined* field in GHA expression context returns unexpected results → the entire OR short-circuited to false. The council caller uses the truthy check in the opposite direction (`github.event.issue.pull_request` alone → *requires* a PR). We use the negation of the same pattern — proven, works. ## Change 2 — Vision preprocessor fixture (`bug-002-image-attachment.json`) Adds fixture #90002 whose repro info lives **entirely in an image attachment**: - body has `Steps to Reproduce: _No response_` - body embeds a stable github.com/user-attachments/... permalink (streams-page screenshot from real bug #11700) Pairs with the ENT-side vision preprocessor PR (adds extract-attachments + describe-via-GLM-4.6V-Flash steps before Analyst). Success = pipeline extracts the image, GLM describes it, Analyst uses the description → produces `area: Streams` + `testability >= MEDIUM` instead of skipping for "no repro steps." `expected-verdicts.json` updated with the pipeline-signal expectations for #90002. ## Why bundled Both changes unblock real-bug verification. The caller fix means `/verify-bug` starts dispatching; the fixture proves the vision preprocessor works on visual-only bugs. Reviewing them together is faster than in isolation. ## Test plan - [x] YAML parses; fixture JSON valid; expected-verdicts JSON valid - [ ] After merge (this + ENT PR): comment `/verify-bug` on any Needs-Testing issue → expect caller job to RUN (not skip) → engine dispatched - [ ] After merge: dispatch fixture 90002 via workflow_dispatch → confirm vision preprocessor produces non-empty `bug-90002-attachments.md` → confirm Analyst produces `area: Streams` + non-SKIP testability Closes #12972. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>