mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
### **User description** ## Summary - Fix destination import test locator in `verifyDestinationCountMessage()` - Move inline locators to constructor in alertsPage.js and alertTemplatesPage.js - Update alerts spec files for Alerts 2.0 wizard flow ## Test plan - [x] Run `npx playwright test playwright-tests/Alerts/` - all tests pass - [x] Sentinel audit passed with no critical issues ___ ### **PR Type** Tests, Enhancement ___ ### **Description** - Enhance AlertsPage for 2.0 wizard UI (create/update/pause/resume) - Add import success and count verifications in AlertDestinationsPage - Centralize locators in AlertTemplatesPage - Update specs to use new page methods and clearAndFillQueryEditor ___ <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><details><summary>7 files</summary><table> <tr> <td><strong>alertDestinationsPage.js</strong><dd><code>Add import success and count verification methods</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/9705/files#diff-57e5c53b4ef998b3d8708149620ff94dcc46807927f1a3a9e9f28ed3ebe25b0a">+30/-0</a> </td> </tr> <tr> <td><strong>alertTemplatesPage.js</strong><dd><code>Move inline locators into constructor</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/9705/files#diff-f4ebd248b2140051e74dbbbd1aabe344f01c80704ce5857e9c28a04350e018f3">+12/-7</a> </td> </tr> <tr> <td><strong>alertsPage.js</strong><dd><code>Refactor for Alerts 2.0 wizard UI and new actions</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/9705/files#diff-79ee01d6d7f145f19207b93b87143b545a1188cfc6a82bc8c45fecfbf68f8a1d">+537/-155</a></td> </tr> <tr> <td><strong>dashboard-folder.js</strong><dd><code>Use data-test locator for folder visibility</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/9705/files#diff-2c20ba97d8e487482cb8fafab72dc6ac96b8a8935ca7e16383afb6173372082e">+4/-1</a> </td> </tr> <tr> <td><strong>alerts-import.spec.js</strong><dd><code>Use new page methods for import verifications</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/9705/files#diff-62b6ec4818685eacc0a934d68aaadfd73b512ef4f4be25fcd5135b97c2844912">+4/-4</a> </td> </tr> <tr> <td><strong>alerts-ui-operations.spec.js</strong><dd><code>Replace raw locators with page object validations</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/9705/files#diff-c9b523b5f5dea834b69abdf20f4acef361bdf37b1585c450e10238b1d1984f2e">+3/-3</a> </td> </tr> <tr> <td><strong>logs-regression.spec.js</strong><dd><code>Replace editor calls with clearAndFillQueryEditor</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/9705/files#diff-99da86ede55fa5f2e3d3fbef897ba7aaa5a7db702a0135f66ac4c888fc7311b6">+4/-6</a> </td> </tr> </table></details></td></tr></tr></tbody></table> </details> ___