mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
ktx-kirtanandktx-abhay
cd470855ec
### **PR Type** Bug fix, Enhancement ___ ### **Description** - Clear component refs on unmount - Dispose Monaco editors and providers - Remove event listeners on teardown - Disable dashboards route keepAlive ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>PanelSchemaRenderer.vue</strong><dd><code>Cleanup dashboard panel refs on unmount</code> </dd></summary> <hr> web/src/components/dashboards/PanelSchemaRenderer.vue <li>Added onUnmounted hook for cleanup<br> <li> Cleared chart, drilldown, annotation, table refs </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7166/files#diff-e5376e7e77bf3aaf6590c2522d8c2dbffcc95a8006ae0d6dc0040a37825367d6">+8/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>DashboardQueryEditor.vue</strong><dd><code>Cleanup QueryEditor refs on unmount</code> </dd></summary> <hr> web/src/components/dashboards/addPanel/DashboardQueryEditor.vue <li>Removed resize listener on unmount<br> <li> Cleared queryEditorRef and vrlFnEditorRef </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7166/files#diff-68bf1b319223d103f1b99e0b681764e4eb76942399397779c81c2cd18f6485ff">+5/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>MonacoHTMLEditor.vue</strong><dd><code>Dispose and clear Monaco HTML editor refs</code> </dd></summary> <hr> web/src/components/dashboards/addPanel/MonacoHTMLEditor.vue <li>Disposed editorObj and provider on unmount<br> <li> Reset editorObj, provider, editorRef to null </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7166/files#diff-ceffb7bda954a9e66f97c1bf28b92ba4ce00bc650f1b24b50997f9745b3ddc5c">+12/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>MonacoMarkdownEditor.vue</strong><dd><code>Dispose and clear Monaco Markdown editor refs</code> </dd></summary> <hr> web/src/components/dashboards/addPanel/MonacoMarkdownEditor.vue <li>Disposed editorObj and provider on unmount<br> <li> Reset editorObj, provider, editorRef to null </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7166/files#diff-387421c070b513acdb939e69b2ba73a47b990a0a10b00a937fa4dc06f984a3dc">+12/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>AddPanel.vue</strong><dd><code>Clear datePicker ref on unmount</code> </dd></summary> <hr> web/src/views/Dashboards/addPanel/AddPanel.vue - Cleared dateTimePickerRef on unmount </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7166/files#diff-c9632db1ad95af95aba10161bcbc7c5608318919f228637bdafae3f3a31267e8">+3/-0</a> </td> </tr> </table></td></tr><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>router.ts</strong><dd><code>Disable keepAlive on dashboards route</code> </dd></summary> <hr> web/src/composables/shared/router.ts - Disabled keepAlive for dashboards route </details> </td> <td><a href="https://github.com/openobserve/openobserve/pull/7166/files#diff-a1827956e5a817edc7efb5f4516e7cc4d453e15ea9e9d970aafb8360b09fc78e">+1/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details> --------- Co-authored-by: ktx-abhay <abhay.padamani@kiara.tech>
web
This template should help get you started developing with Vue 3 in Vite.
Recommended IDE Setup
VSCode + Volar (and disable Vetur) + TypeScript Vue Plugin (Volar).
Type Support for .vue Imports in TS
TypeScript cannot handle type information for .vue imports by default, so we replace the tsc CLI with vue-tsc for type checking. In editors, we need TypeScript Vue Plugin (Volar) to make the TypeScript language service aware of .vue types.
If the standalone TypeScript plugin doesn't feel fast enough to you, Volar has also implemented a Take Over Mode that is more performant. You can enable it by the following steps:
- Disable the built-in TypeScript Extension
- Run
Extensions: Show Built-in Extensionsfrom VSCode's command palette - Find
TypeScript and JavaScript Language Features, right click and selectDisable (Workspace)
- Run
- Reload the VSCode window by running
Developer: Reload Windowfrom the command palette.
Customize configuration
See Vite Configuration Reference.
Project Setup
npm install
Compile and Hot-Reload for Development
For stand-alone UI development environment, create .env file and which contains below environment variable
VITE_OPENOBSERVE_ENDPOINT=http://localhost:5080/
npm run dev
Type-Check, Compile and Minify for Production
npm run build
Run Unit Tests with Vitest
npm run test:unit
Run End-to-End Tests with Cypress
npm run test:e2e:dev
This runs the end-to-end tests against the Vite development server. It is much faster than the production build.
But it's still recommended to test the production build with test:e2e before deploying (e.g. in CI environments):
npm run build
npm run test:e2e
Lint with ESLint
npm run lint