mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
Shrinath RaoandClaude Opus 4.5
d8c08e7b68
## Summary E2E test automation for multiple bug fixes and features: - Bug #9217 (Favicon missing) - Bug #9724 (Log detail sidebar default tab) - Bug #9901 (Scheduled pipeline validation) - includes cherry-picked fixes - Feature #9484 (Manual Alert Trigger via UI) --- ## Bug Fixes Automated ### Bug #9217 - Favicon icon missing on main branch - **Issue:** https://github.com/openobserve/openobserve/issues/9217 - **Fix PR:** https://github.com/openobserve/openobserve/pull/9189 - **Test:** Verifies favicon is present in DOM and loads via HTTP 200 - **Location:** `tests/ui-testing/playwright-tests/RegressionSet/ui-regression.spec.js` ### Bug #9724 - Log detail sidebar opens with JSON tab by default - **Issue:** https://github.com/openobserve/openobserve/issues/9724 - **Fix PR:** https://github.com/openobserve/openobserve/pull/9703 - **Test:** Verifies JSON tab is selected by default when opening log detail sidebar - **Location:** `tests/ui-testing/playwright-tests/RegressionSet/logs-regression.spec.js` ### Bug #9901 - Scheduled pipeline not validating on selected stream type - **Issue:** https://github.com/openobserve/openobserve/issues/9901 - **Fix PR:** https://github.com/openobserve/openobserve/pull/9897 (cherry-picked) - **Tests:** 4 regression tests covering: 1. Metrics stream type validation (not hardcoded "logs") 2. Traces stream type validation (not hardcoded "logs") 3. Quick click on "Validate and Close" without blur interference 4. Quick click on "Cancel" without blur interference - **Location:** `tests/ui-testing/playwright-tests/RegressionSet/pipeline-regression.spec.js` **Cherry-picked fixes from PR #9897:** - `f2a211cf2`: Use selected stream type for validating SQL query - `b1bf7e658`: Add @mousedown.prevent to prevent blur/click race condition ### Feature #9484 - Manual Alert Trigger via UI - **Issue:** https://github.com/openobserve/openobserve/issues/9484 - **Test:** Verifies manual alert trigger button works via kebab menu - **Location:** `tests/ui-testing/playwright-tests/Alerts/alerts-ui-operations.spec.js` --- ## New Page Object Methods Added ### pipelinesPage.js - `ingestMetricsData(streamName, recordCount)` - Ingest metrics via `/api/{org}/ingest/metrics/_json` - `ingestTracesData(serviceName, spanCount, streamName)` - Ingest traces via OTLP `/api/{org}/v1/traces` - Supports custom stream name via `stream-name` header (configurable via `ZO_GRPC_STREAM_HEADER_KEY`) - Proper nested parent-child span timing for waterfall visualization - `clickValidateAndClose()`, `focusSqlEditor()`, `isDiscardChangesDialogVisible()` - `expectDiscardDialogNotVisible()`, `cleanupPipelineCreation()` ### logsPage.js - Log detail sidebar selectors and verification methods - Replaced `waitForTimeout(500)` with element waits (3 places) - Replaced `throw new Error()` with `expect()` assertions (3 places) ### homePage.js - `verifyFavicon()` - Verify favicon presence and HTTP load - Fixed `domValid` boolean cast with `includes()` ### alertManagement.js - Manual alert trigger method via kebab menu --- ## Files Changed | File | Changes | |------|---------| | `tests/ui-testing/pages/pipelinesPages/pipelinesPage.js` | Metrics/traces ingestion, scheduled pipeline validation methods | | `tests/ui-testing/pages/logsPages/logsPage.js` | Log detail sidebar + PR review fixes | | `tests/ui-testing/pages/generalPages/homePage.js` | Favicon verification + review fix | | `tests/ui-testing/pages/alertsPages/alertManagement.js` | Manual alert trigger method | | `tests/ui-testing/playwright-tests/RegressionSet/pipeline-regression.spec.js` | **NEW** - 4 tests for #9901 | | `tests/ui-testing/playwright-tests/RegressionSet/ui-regression.spec.js` | Favicon test | | `tests/ui-testing/playwright-tests/RegressionSet/logs-regression.spec.js` | Log detail sidebar test | | `tests/ui-testing/playwright-tests/Alerts/alerts-ui-operations.spec.js` | Manual alert trigger test | | `tests/ui-testing/playwright-tests/cleanup.spec.js` | Cleanup patterns for test streams | | `.github/workflows/playwright.yml` | Added pipeline-regression.spec.js to CI | | `web/src/components/pipeline/...` | Cherry-picked validation fixes | --- ## Test Plan - [x] Bug #9217 test passes locally - [x] Bug #9724 test passes locally - [x] Bug #9901 tests pass locally (4 tests, ~3.9 min) - [x] Feature #9484 test passes locally - [x] Cleanup patterns added for test streams --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>