mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-05 16:10:43 +00:00
Shrinath Rao
e2f9e799f9
### **User description** … page, removed redundant old alert module code files, updated playwright yml file ___ ### **PR Type** Enhancement, Tests ___ ### **Description** - Refactor AlertsPage with unified locator methods - Restructure alert tests into modular suites - Enhance AlertTemplatesPage with robust flows - Tweak scroll logic and update workflow ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><details><summary>3 files</summary><table> <tr> <td><strong>alertsPage.js</strong><dd><code>Rewrite AlertsPage with unified locator methods</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-c5fc79c6d2dcc83e20d69c46fdcf69449dade50c3e7cd5bf65d88369f5083cce">+593/-316</a></td> </tr> <tr> <td><strong>alertTemplatesPage.js</strong><dd><code>Enhance AlertTemplatesPage navigation and flows</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-85075c8512133f05cc1a149872574c9e498613329c17e36521a0dfbff1d83e2e">+76/-21</a> </td> </tr> <tr> <td><strong>commonActions.js</strong><dd><code>Adjust scroll behaviour and add delays</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-4d726dd2bdb34b2c90a31798ff49b6df5bc952bd049b7c38bebb18b6db0076e2">+5/-4</a> </td> </tr> </table></details></td></tr><tr><td><strong>Tests</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>alerts.spec.js</strong><dd><code>Restructure alert tests into modular suites</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-a51e6bab2ebb7ff9069a707fd7da5bb3e0948db8013765b4a934ba594c1bcf57">+306/-176</a></td> </tr> </table></details></td></tr><tr><td><strong>Configuration changes</strong></td><td><details><summary>1 files</summary><table> <tr> <td><strong>playwright.yml</strong><dd><code>Update workflow alert spec filename</code> </dd></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+1/-1</a> </td> </tr> </table></details></td></tr><tr><td><strong>Additional files</strong></td><td><details><summary>6 files</summary><table> <tr> <td><strong>alertDestination.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-f41f8d6b2aee510dccda3dc62f6b3601a737e2e214338389a156e1f97dc93c2c">+0/-94</a> </td> </tr> <tr> <td><strong>alertTemplate.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-bd0d61b026c09ab61a5fe5848002f3055c2d18f267c178da468c9536734c4308">+0/-76</a> </td> </tr> <tr> <td><strong>alertsNew.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-e30d87f85be81e5bfe97cd508ee6f357ca0d8c07510781a6af1b1e1ddb1108e3">+0/-597</a> </td> </tr> <tr> <td><strong>alertImportTDA.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-002bc3f0dc90790836282141f166106796f25dfa5ba1198a4817e334e9fbe60c">+0/-433</a> </td> </tr> <tr> <td><strong>alertsNew.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-1ee99432f0206c9da5686514ac4b941aedb70f75a75539488ed0e2aeb01071e3">+0/-344</a> </td> </tr> <tr> <td><strong>alertsfolders.spec.js</strong></td> <td><a href="https://github.com/openobserve/openobserve/pull/7199/files#diff-8fe0cba8c6c487d2a0cf8309769adaebddcfc1932080d4cbb4a448902d14123a">+0/-312</a> </td> </tr> </table></details></td></tr></tr></tbody></table> ___ > <details> <summary> Need help?</summary><li>Type <code>/help how to ...</code> in the comments thread for any questions about PR-Agent usage.</li><li>Check out the <a href="https://qodo-merge-docs.qodo.ai/usage-guide/">documentation</a> for more information.</li></details>