Ashish Kolhe bafc2be4f0 fix(correlation): P0/P1 fixes from service-streams correlation review (#13668) ...

## Summary

OSS half of the correlation P0/P1 fix set from the line-by-line review
(`docs/ak_review/correlation-line-by-line-review-2026-08-06.md`).
Companion enterprise PR: same branch name in o2-enterprise (required for
CI manifest pairing).

### Fixes (by review finding)

| Finding | Fix |
|---|---|
| **F14** | `StreamInfo.dropped_dimensions` contract field
(`#[serde(default, skip_serializing_if)]`, backward-compatible wire
format) + TS type |
| **F8** | Shared coverage-based identity-set ranking
(`resolve_best_set_by_coverage`) in `config::meta::correlation` — full
coverage > ratio > count, declaration-order ties; ingest and read now
rank identically |
| **F10** | `save_identity_config` purges rows of removed/changed sets
(`obsolete_set_ids`) + cache clear + org reload event |
| **F6** | `_reset` routes through enterprise
`ServiceStorage::delete_all` (cache clear + super-cluster replication)
and emits an org-scope reload; super-cluster Delete consumer emits org
reload instead of per-service delete |
| **F19** | `infra::table::service_streams::put`/`delete_subset_orphans`
return deleted orphan disambiguations so callers can evict cache keys |
| **F2** | `config::utils::sql::validate_where_fragment` (sqlparser)
applied to the `filter` param at both `traces/latest*` interpolation
sites — statement smuggling and comment-truncation payloads → 400 |
| **F2/F38** | FE: shared
`quoteSqlIdentifier`/`quoteSqlLiteral`/`buildSqlCondition` adopted by
all six SQL builders (two trace paths were fully unescaped) |
| **F35** | `applyFilterOverlay`: filter edits resolve per-stream via
semantic groups instead of literal key identity; dead
`removeFilter`/`resetFilters` removed; `semanticGroups` threaded to
`CorrelatedLogsTable` parents |
| **F36** | `applyDimensionEditsToFilters`: dimension-bar edits work in
both key spaces (raw-field and semantic-ID), case-insensitive shared
field→group map |
| **F31** | `mergeSubjectOverrides`: subject overrides replace the
same-group key (never union two aliases into contradictory WHERE),
schema-less field guessing removed |
| F14 (FE) | Warning banner shipped, then removed by reviewer decision
(`dropped_dimensions` stays in the API) |

### Verification

- `cargo test -p config` correlation/service_streams/sql: 121 tests
green; enterprise-feature and OSS-only cfg builds both compile
- FE: 263 vitest tests green across the correlation suites; vue-tsc
clean
- **Live-verified** against a local build (fresh DB): 19/19 API checks
(raw-value emission, set filing, obsolete-set purge, reset cache
invalidation, orphan eviction, filter validation) plus browser checks
(escaped SQL on the wire: `"environment" = 'Prod-EU'`)

Deliberately out of scope (per review decision): F15, F17/F37, F9.

2026-08-06 11:49:39 +00:00

..

alerts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

contextProviders

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

dashboard

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

flow

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

iam

feat(ui): calm-signal pass over IAM and Synthetics Monitors (#13568)

2026-08-03 08:54:15 +00:00

metrics

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

rum

feat: Issue ent 2289 mobile rum sdk error tracking v2 (#13645)

2026-08-05 12:18:13 +00:00

shared

chore(traces): make Service Graph and Services their own routes (#13659)

2026-08-06 10:30:03 +00:00

synthetics

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

traces

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useLogs

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

fieldValueDB.spec.ts

build: add UI code quality checks and enhance linting processe (#13174)

2026-07-21 12:47:06 +00:00

fieldValueDB.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

fieldValueStore.serverFetch.spec.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

fieldValueStore.spec.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

fieldValueStore.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

router.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

router.ts

fix: add AI Observability checks (#12668)

2026-06-15 14:59:55 +00:00

useActions.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useActions.ts

feat: ux improvement main (#11838)

2026-05-28 11:00:49 +00:00

useAiChat.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useAiChat.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useAiDashboardEvents.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useAiIcon.ts

refactor: design token migration + CI guards (#13173)

2026-07-20 18:06:21 +00:00

useAlertForm.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useAlertInsights.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useAlertInsights.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useAutoName.spec.ts

feat(web): inline-rename page titles with auto-generated default names (#13520)

2026-07-31 08:50:19 +00:00

useAutoName.ts

feat(web): inline-rename page titles with auto-generated default names (#13520)

2026-07-31 08:50:19 +00:00

useChatHistory.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useChatHistory.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useChunkedContent.spec.ts

chore: update copyright year to 2026 (#11166)

2026-04-07 09:57:53 +08:00

useChunkedContent.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useConfirmDialog.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useCorrelatedLogs.spec.ts

fix(correlation): P0/P1 fixes from service-streams correlation review (#13668)

2026-08-06 11:49:39 +00:00

useCorrelatedLogs.ts

fix(correlation): P0/P1 fixes from service-streams correlation review (#13668)

2026-08-06 11:49:39 +00:00

useCorrelationDefaultSlug.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useCorrelationDefaultSlug.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useDashboardPanel.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useDimensionSelector.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useDimensionSelector.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useDragHandle.ts

fix: dashboard builder redesign (#13419)

2026-07-28 10:59:27 +00:00

useDurationPercentiles.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useDurationPercentiles.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useErrorTracking.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useErrorTracking.ts

chore: update copyright year to 2026 (#11166)

2026-04-07 09:57:53 +08:00

useEventFormatters.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useEventFormatters.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useExternalColumnToggle.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useFavoriteDashboards.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useFavoriteDashboards.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useFieldGrouping.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useFieldValuesStream.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useFieldValuesStream.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

useFunctions.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useFunctions.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useHomeDashboard.spec.ts

fix(dashboards): keep Home pin in sync on move/delete (o2-enterprise#2139, #2140) (#13121)

2026-07-10 06:12:52 +05:30

useHomeDashboard.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useIngestion.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useIngestion.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useIsMetaOrg.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useIsMetaOrg.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useJumpToLatestData.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useLatencyInsightsAnalysis.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useLatencyInsightsAnalysis.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useLatencyInsightsDashboard.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useLoading.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useLoading.ts

feat: ux improvement main (#11838)

2026-05-28 11:00:49 +00:00

useLogs.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useLogs.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useLogsHighlighter.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useLogsHighlighter.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useMcpCredential.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useMetrics.spec.ts

chore: update copyright year to 2026 (#11166)

2026-04-07 09:57:53 +08:00

useMetrics.ts

build: add UI code quality checks and enhance linting processe (#13174)

2026-07-21 12:47:06 +00:00

useMetricsCorrelationDashboard.spec.ts

fix(correlation): P0/P1 fixes from service-streams correlation review (#13668)

2026-08-06 11:49:39 +00:00

useMetricsCorrelationDashboard.ts

fix(correlation): P0/P1 fixes from service-streams correlation review (#13668)

2026-08-06 11:49:39 +00:00

useMetricsExplorer.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useMetricsExplorer.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useMetricSubjectButtons.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useNLQuery.spec.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

useNLQuery.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

useNotifications.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useNotifications.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useParser.spec.ts

build: add UI code quality checks and enhance linting processe (#13174)

2026-07-21 12:47:06 +00:00

useParser.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

usePipelines.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

usePipelines.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

usePrebuiltDestinations.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

usePrebuiltDestinations.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

usePredefinedThemes.spec.ts

chore: update copyright year to 2026 (#11166)

2026-04-07 09:57:53 +08:00

usePredefinedThemes.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

usePromqlSuggestions.spec.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

usePromqlSuggestions.streamSources.spec.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

usePromqlSuggestions.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

useQuery.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useQuery.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useQueryError.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useRateLimiter.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useRateLimiter.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useResizer.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useRoutePrefetch.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useRoutePrefetch.ts

feat: Revamp metrics explorer (#13144)

2026-07-14 07:50:56 +00:00

useSearchInputUsingRegex.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useSearchInputUsingRegex.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useSearchWebSocket.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useSearchWebSocket.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useSelectAutocomplete.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useSelectAutocomplete.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useServiceCorrelation.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useServiceCorrelation.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useServiceGraphTree.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useSessionActivity.ts

feat: Mobile rum sdk v2 (#13503)

2026-07-28 07:58:21 +00:00

useSessionReplay.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useSessionReplay.ts

feat: Mobile rum sdk v2 (#13503)

2026-07-28 07:58:21 +00:00

useSloFormat.ts

feat: per-group and per-series alerting, and SLO measurement (#13547)

2026-07-31 07:23:22 +00:00

useSqlEditorDiagnostics.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useStickyColumns.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useStickyColumns.ts

build: add UI code quality checks and enhance linting processe (#13174)

2026-07-21 12:47:06 +00:00

useStreamingSearch.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useStreamingSearch.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useStreams.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useStreams.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useSuggestions.serverCatalog.spec.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

useSuggestions.spec.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

useSuggestions.ts

feat(editor): rebuild query autocomplete, and fix the value path behind it (#13586)

2026-08-03 22:29:04 +00:00

useSyntheticEvidence.spec.ts

fix: redesign the step editor and the run evidence surfaces (#13582)

2026-08-03 12:45:16 +08:00

useSyntheticEvidence.ts

fix: redesign the step editor and the run evidence surfaces (#13582)

2026-08-03 12:45:16 +08:00

useSyntheticResults.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useSyntheticResults.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useSyntheticsRecorder.spec.ts

fix(synthetics): stop a browser replay without stranding a step in progress (#13592)

2026-08-03 11:04:22 +00:00

useSyntheticsRecorder.ts

fix(synthetics): stop a browser replay without stranding a step in progress (#13592)

2026-08-03 11:04:22 +00:00

useTextHighlighter.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useTextHighlighter.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useTheme.ts

refactor: design token migration + CI guards (#13173)

2026-07-20 18:06:21 +00:00

useThemeCustomizer.spec.ts

chore: update copyright year to 2026 (#11166)

2026-04-07 09:57:53 +08:00

useThemeCustomizer.ts

fix: traces, alert insights charts render issue (#8977)

2025-11-06 18:38:13 +08:00

useToolbarPins.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useToolbarPins.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useToolbarResponsive.ts

fix: Fix/layout exp1 (#12521)

2026-06-09 16:28:08 +00:00

useTracePatternTree.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useTracePatternTree.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useTraces.spec.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useTraces.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useTreeInteraction.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useTreeVisualization.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useTreeVisualization.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useUnauthorizedErrorGrouper.ts

fix: i18n lint enforcement (#13439)

2026-08-05 10:16:00 +00:00

useVrlPlaceholder.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useWebSocket.spec.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useWebSocket.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useWidenRange.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00

useWorker.spec.ts

chore: update copyright year to 2026 (#11166)

2026-04-07 09:57:53 +08:00

useWorker.ts

build: FE code format check for improved maintainability (#13351)

2026-07-24 07:11:39 +00:00