mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-05 08:09:22 +00:00
ktx-akshay
e145c355b9
### **PR Type**
Enhancement, Tests
___
### **Description**
- Add helper to change variable and monitor dependencies
- Refactor dependency tests to use helper function
- Migrate variable-helpers.js to ES module exports
- Enable dependency tests in CI workflow
___
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>dashboard-variables-scoped.js</strong><dd><code>Add
changeVariableValueAndMonitorDependencies helper</code>
</dd></summary>
<hr>
tests/ui-testing/pages/dashboardPages/dashboard-variables-scoped.js
<ul><li>Added <code>changeVariableValueAndMonitorDependencies</code>
method<br> <li> Dynamically import and use
<code>monitorVariableAPICalls</code><br> <li> Sequence dropdown
interaction and API monitoring<br> <li> Error handling for missing
options and load failures</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/10200/files#diff-86abb9f90fabd982dedfdd9a21a052a47b6984edc7bd29a51ee104c8c473aec4">+101/-0</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Tests</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>dashboard-variables-dependency.spec.js</strong><dd><code>Refactor
tests to use new dependency helper</code>
</dd></summary>
<hr>
tests/ui-testing/playwright-tests/Dashboards/dashboard-variables-dependency.spec.js
<ul><li>Replaced manual API monitor and dropdown logic with helper<br>
<li> Updated <code>expectedAPICalls</code> and assertion on
<code>result.success</code><br> <li> Skipped unstable error state test
(<code>test.skip</code>)<br> <li> Extended timeouts and stabilized
selectors</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/10200/files#diff-ad5a7685fbf4477a81657949b7dd4aa4ada6e66a4576d0c61bacb388095d0b52">+53/-157</a></td>
</tr>
</table></td></tr><tr><td><strong>Refactoring</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>variable-helpers.js</strong><dd><code>Migrate
variable-helpers to ES module</code>
</dd></summary>
<hr>
tests/ui-testing/playwright-tests/utils/variable-helpers.js
<ul><li>Converted CommonJS require to ES <code>import</code><br> <li>
Removed <code>module.exports</code> in favor of named exports</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/10200/files#diff-2e2771d2582ab60dfcbaeef480226887677e58b881edbb244e0ffa4396ffbb5c">+1/-15</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Configuration
changes</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>playwright.yml</strong><dd><code>Enable dependency
tests in CI workflow</code>
</dd></summary>
<hr>
.github/workflows/playwright.yml
<ul><li>Uncommented <code>Dashboards-Variables-Dependency</code>
testfolder<br> <li> Enabled dependency spec in CI Chrome job</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/10200/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+6/-6</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___