mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
The Add Function header selected VRL vs JavaScript with a radio group and a single info icon. That icon only ever described the ALREADY-SELECTED language, so learning what the other one was for meant switching to it first. - Radio group -> OFormToggleGroup segmented control with a sliding indicator, each option carrying a language mark (V / JS). The badge variants match the transType column in FunctionList so VRL/JS read the same everywhere. - Give EACH option its own info icon and static tooltip, so both languages are readable without selecting either. Forced-language hosts (workflow function nodes are JS-only) hide the toggle, so the locked language's tip moves to a standalone icon. - Add a pipe divider between the two options, and one between the function-name title and the toggle. data-test renames `...-vrl-radio` -> `...-vrl-option` (same for js): "radio" described the old implementation. E2E page objects would have broken on this change regardless of naming -- toggle items expose data-state="on|off", not the radio group's "checked|unchecked". Verified: FunctionsToolbar.spec.ts 18/18 pass, vue-tsc clean. ESLint could not be run locally (@intlify/eslint-plugin-vue-i18n missing from node_modules).
334 lines
15 KiB
JavaScript
334 lines
15 KiB
JavaScript
// Copyright 2026 OpenObserve Inc.
|
|
|
|
const { expect } = require('@playwright/test');
|
|
const testLogger = require('../../playwright-tests/utils/test-logger.js');
|
|
|
|
class FunctionsFormValidationPage {
|
|
constructor(page) {
|
|
this.page = page;
|
|
|
|
// ==================== AddFunction / FunctionsToolbar locators ====================
|
|
|
|
// Name is an inline-edited title (OFormInlineEdit): a display trigger swaps
|
|
// to an input on click; -error is the validation message.
|
|
this.functionNameTrigger = page.locator('[data-test="add-function-name-input-trigger"]');
|
|
this.functionNameField = page.locator('[data-test="add-function-name-input-input"]');
|
|
this.functionNameError = page.locator('[data-test="add-function-name-input-error"]');
|
|
|
|
// VRL editor wrapper
|
|
this.functionEditor = page.locator('[data-test="logs-vrl-function-editor"]');
|
|
|
|
// Action buttons
|
|
this.saveButton = page.locator('[data-test="add-function-save-btn"]');
|
|
this.cancelButton = page.locator('[data-test="add-function-cancel-btn"]');
|
|
this.backButton = page.locator('[data-test="add-function-back-btn"]');
|
|
|
|
// Toast notifications
|
|
this.toastSuccess = page.locator('[data-test-variant="success"]');
|
|
this.toastError = page.locator('[data-test-variant="error"]');
|
|
|
|
// ==================== AddEnrichmentTable locators ====================
|
|
|
|
// Add form root
|
|
this.enrichmentPage = page.locator('[data-test="add-enrichment-table-page"]');
|
|
|
|
// Name field (OInput)
|
|
this.enrichmentNameField = page.locator('[data-test="add-enrichment-table-name-field"]');
|
|
this.enrichmentNameError = page.locator('[data-test="add-enrichment-table-name-error"]');
|
|
|
|
// File upload (OFile — derives -field automatically; -error for validation msg)
|
|
this.enrichmentFileField = page.locator('[data-test="add-enrichment-table-file-field"]');
|
|
this.enrichmentFileError = page.locator('[data-test="add-enrichment-table-file-error"]');
|
|
|
|
// URL field (OInput for URL source)
|
|
this.enrichmentUrlField = page.locator('[data-test="add-enrichment-table-url-field"]');
|
|
this.enrichmentUrlError = page.locator('[data-test="add-enrichment-table-url-error"]');
|
|
|
|
// Source toggle (OOptionGroup — file vs url)
|
|
this.enrichmentSourceGroup = page.locator('[data-test="add-enrichment-table-source"]');
|
|
|
|
// Footer buttons
|
|
this.enrichmentSaveButton = page.locator('[data-test="add-enrichment-table-save-btn"]');
|
|
this.enrichmentCancelButton = page.locator('[data-test="add-enrichment-table-cancel-btn"]');
|
|
this.enrichmentBackButton = page.locator('[data-test="add-enrichment-table-back-btn"]');
|
|
|
|
// Add enrichment button on list page
|
|
this.enrichmentAddButton = page.locator('[data-test="enrichment-tables-add-btn"]');
|
|
|
|
// Pipeline / enrichment navigation
|
|
this.enrichmentTableTab = page.locator('[data-test="pipeline-section-tab-enrichmentTables"]');
|
|
|
|
// Add function button on functions list
|
|
this.addFunctionButton = page.locator('[data-test="function-list-add-function-btn"]');
|
|
|
|
// ==================== FunctionsToolbar locators ====================
|
|
|
|
// VRL / JS language toggle (OToggleGroup items)
|
|
this.vrlOption = page.locator('[data-test="function-transform-type-vrl-option"]');
|
|
this.jsOption = page.locator('[data-test="function-transform-type-js-option"]');
|
|
|
|
// ==================== StreamRouting locators ====================
|
|
|
|
// StreamRouting panel root
|
|
this.streamRoutingSection = page.locator('[data-test="add-stream-routing-section"]');
|
|
|
|
// Close icon
|
|
this.streamRoutingCloseBtn = page.locator('[data-test="stream-routing-close-dialog-btn"]');
|
|
|
|
// Destination name input (OInput — derives -field and -error)
|
|
this.streamRoutingDestNameField = page.locator('[data-test="stream-routing-destination-name-input-field"]');
|
|
this.streamRoutingDestNameError = page.locator('[data-test="stream-routing-destination-name-input-error"]');
|
|
|
|
// Stream type select (OSelect — derives -error)
|
|
this.streamRoutingStreamTypeError = page.locator('[data-test="add-alert-stream-type-select-error"]');
|
|
|
|
// Stream name select (OSelect — derives -error)
|
|
this.streamRoutingStreamNameError = page.locator('[data-test="add-alert-stream-select-error"]');
|
|
|
|
// Save / Cancel buttons
|
|
this.streamRoutingSaveBtn = page.locator('[data-test="add-report-save-btn"]');
|
|
this.streamRoutingCancelBtn = page.locator('[data-test="add-report-cancel-btn"]');
|
|
|
|
// Pipeline add-routing button (if available in the pipeline view)
|
|
this.addStreamRoutingButton = page.locator('[data-test="pipeline-add-stream-routing-btn"]');
|
|
}
|
|
|
|
// ==================== Navigation ====================
|
|
|
|
async navigateToFunctions(org) {
|
|
const targetOrg = org || process.env.ORGID;
|
|
testLogger.info(`Navigating to functions page for org: ${targetOrg}`);
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/functions?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
}
|
|
|
|
async navigateToEnrichmentTables(org) {
|
|
const targetOrg = org || process.env.ORGID;
|
|
testLogger.info(`Navigating to enrichment tables for org: ${targetOrg}`);
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/functions?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
await this.enrichmentTableTab.waitFor({ state: 'visible', timeout: 15000 });
|
|
await this.enrichmentTableTab.click();
|
|
await this.page.waitForLoadState('networkidle', { timeout: 10000 }).catch(() => {});
|
|
}
|
|
|
|
// ==================== Add Function actions ====================
|
|
|
|
async openAddFunctionForm(org) {
|
|
await this.navigateToFunctions(org);
|
|
await this.addFunctionButton.waitFor({ state: 'visible', timeout: 15000 });
|
|
await this.addFunctionButton.click();
|
|
// The name trigger is what renders in display mode (the input only appears
|
|
// once the trigger is clicked) — wait on it as the form-open signal.
|
|
await this.functionNameTrigger.waitFor({ state: 'visible', timeout: 15000 });
|
|
testLogger.info('Add Function form opened');
|
|
}
|
|
|
|
async fillFunctionName(name) {
|
|
testLogger.info(`Filling function name: ${name}`);
|
|
// Open the inline editor, then fill the revealed input.
|
|
await this.functionNameTrigger.waitFor({ state: 'visible' });
|
|
await this.functionNameTrigger.click();
|
|
await this.functionNameField.waitFor({ state: 'visible' });
|
|
await this.functionNameField.fill(name);
|
|
}
|
|
|
|
async clickSave() {
|
|
testLogger.info('Clicking Save button');
|
|
await this.saveButton.waitFor({ state: 'visible' });
|
|
await this.saveButton.click();
|
|
}
|
|
|
|
async expectFunctionNameError(message) {
|
|
testLogger.info(`Expecting function name error: ${message}`);
|
|
await this.functionNameError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.functionNameError).toBeVisible();
|
|
if (message) {
|
|
await expect(this.functionNameError).toContainText(message);
|
|
}
|
|
}
|
|
|
|
async expectFunctionNameErrorVisible() {
|
|
testLogger.info('Expecting function name error to be visible');
|
|
await this.functionNameError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.functionNameError).toBeVisible();
|
|
}
|
|
|
|
async typeInVrlEditor(code) {
|
|
testLogger.info('Typing VRL code into editor');
|
|
await this.functionEditor.waitFor({ state: 'visible', timeout: 15000 });
|
|
// Focus the editor. Monaco is a lazy-loaded async chunk, so the wrapper
|
|
// (data-test element) renders BEFORE the Monaco instance is registered.
|
|
await this.functionEditor.click();
|
|
|
|
const editorSelector = '[data-test="logs-vrl-function-editor"]';
|
|
|
|
// Poll until Monaco has loaded AND the function editor is registered. The
|
|
// page also mounts a separate Query editor, so scope the match to this
|
|
// container. This replaces a fixed 300ms sleep that raced Monaco's load on
|
|
// slow CI runners — a miss left the editor empty, submitting an empty
|
|
// function body (backend 400 "Function body cannot be empty", no success toast).
|
|
await this.page.waitForFunction((sel) => {
|
|
const editors = window.monaco?.editor?.getEditors?.();
|
|
const container = document.querySelector(sel);
|
|
return !!(container && editors?.some(e => container.contains(e.getContainerDomNode())));
|
|
}, editorSelector, { timeout: 15000 });
|
|
|
|
// Type the content as a real user via Monaco's textarea. This is deliberate:
|
|
// executeEdits() sets the model value but does NOT drive the editor's
|
|
// onDidChangeModelContent listener that syncs @update:query → formData.function,
|
|
// so a save afterwards submits an empty function body (backend 400
|
|
// "Function body cannot be empty", no success toast). Real keystrokes fire it.
|
|
// Click the VISIBLE editor surface (.view-lines) to focus Monaco — its
|
|
// <textarea.inputarea> is a 1px hidden input Playwright refuses to click.
|
|
await this.functionEditor.locator('.view-lines').first().click();
|
|
await this.page.keyboard.type(code, { delay: 20 });
|
|
|
|
// Confirm the content actually landed in the Monaco model.
|
|
await this.page.waitForFunction(({ sel, vrlCode }) => {
|
|
const editors = window.monaco?.editor?.getEditors?.();
|
|
const container = document.querySelector(sel);
|
|
const targetEditor = editors?.find(e => container?.contains(e.getContainerDomNode()));
|
|
return targetEditor?.getModel()?.getValue() === vrlCode;
|
|
}, { sel: editorSelector, vrlCode: code }, { timeout: 5000 });
|
|
|
|
// The editor's @update:query emit is DEBOUNCED (500ms) and flushed on blur.
|
|
// Blur the editor (focus the name field) so formData.function updates
|
|
// immediately — deterministic instead of racing the debounce timer. Clicking
|
|
// the inline-edit trigger moves focus off Monaco (and opens the name editor).
|
|
await this.functionNameTrigger.click();
|
|
await this.page.waitForTimeout(200);
|
|
}
|
|
|
|
async expectSuccessToast() {
|
|
testLogger.info('Waiting for success toast');
|
|
await this.toastSuccess.waitFor({ state: 'visible', timeout: 15000 });
|
|
await expect(this.toastSuccess).toBeVisible();
|
|
}
|
|
|
|
// ==================== Add Enrichment Table actions ====================
|
|
|
|
async openAddEnrichmentTableForm(org) {
|
|
await this.navigateToEnrichmentTables(org);
|
|
await this.enrichmentAddButton.waitFor({ state: 'visible', timeout: 15000 });
|
|
await this.enrichmentAddButton.click();
|
|
await this.enrichmentPage.waitFor({ state: 'visible', timeout: 15000 });
|
|
testLogger.info('Add Enrichment Table form opened');
|
|
}
|
|
|
|
async fillEnrichmentName(name) {
|
|
testLogger.info(`Filling enrichment table name: ${name}`);
|
|
await this.enrichmentNameField.waitFor({ state: 'visible' });
|
|
await this.enrichmentNameField.fill(name);
|
|
}
|
|
|
|
async clickEnrichmentSave() {
|
|
testLogger.info('Clicking enrichment table Save button');
|
|
await this.enrichmentSaveButton.waitFor({ state: 'visible' });
|
|
await this.enrichmentSaveButton.click();
|
|
}
|
|
|
|
async expectEnrichmentNameError(message) {
|
|
testLogger.info(`Expecting enrichment name error: ${message}`);
|
|
await this.enrichmentNameError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.enrichmentNameError).toBeVisible();
|
|
if (message) {
|
|
await expect(this.enrichmentNameError).toContainText(message);
|
|
}
|
|
}
|
|
|
|
async expectEnrichmentFileError(message) {
|
|
testLogger.info(`Expecting enrichment file error: ${message}`);
|
|
await this.enrichmentFileError.waitFor({ state: 'visible', timeout: 5000 });
|
|
await expect(this.enrichmentFileError).toBeVisible();
|
|
if (message) {
|
|
await expect(this.enrichmentFileError).toContainText(message);
|
|
}
|
|
}
|
|
|
|
// ==================== FunctionsToolbar assertion helpers ====================
|
|
|
|
async assertVrlRadioSelected() {
|
|
testLogger.info('Asserting the VRL language option is selected');
|
|
await this.vrlOption.waitFor({ state: 'visible', timeout: 10000 });
|
|
// OToggleGroupItem exposes selection via Reka-UI's `data-state="on|off"`
|
|
// (and mirrors it on aria-pressed).
|
|
await expect(this.vrlOption).toHaveAttribute('data-state', 'on');
|
|
}
|
|
|
|
// ==================== StreamRouting actions ====================
|
|
|
|
async openStreamRoutingForm(org) {
|
|
const targetOrg = org || process.env.ORGID;
|
|
testLogger.info('Opening StreamRouting form via pipeline page');
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/functions?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
// Attempt to open routing panel; fall back gracefully if not available in env
|
|
const routingBtn = this.addStreamRoutingButton;
|
|
const btnVisible = await routingBtn.isVisible({ timeout: 5000 }).catch(() => false);
|
|
if (btnVisible) {
|
|
await routingBtn.click();
|
|
await this.streamRoutingSection.waitFor({ state: 'visible', timeout: 10000 });
|
|
testLogger.info('StreamRouting panel opened via button');
|
|
} else {
|
|
// Navigate directly to routing view if the button is not available
|
|
await this.page.goto(
|
|
`${process.env.ZO_BASE_URL}/web/pipeline/stream-routing?org_identifier=${targetOrg}`
|
|
);
|
|
await this.page.waitForLoadState('networkidle', { timeout: 30000 }).catch(() => {});
|
|
await this.streamRoutingSection.waitFor({ state: 'visible', timeout: 15000 });
|
|
testLogger.info('StreamRouting panel opened via direct URL');
|
|
}
|
|
}
|
|
|
|
async fillStreamRoutingDestName(name) {
|
|
testLogger.info(`Filling stream routing destination name: ${name}`);
|
|
await this.streamRoutingDestNameField.waitFor({ state: 'visible', timeout: 10000 });
|
|
await this.streamRoutingDestNameField.fill(name);
|
|
await this.streamRoutingDestNameField.dispatchEvent('blur');
|
|
}
|
|
|
|
async clickStreamRoutingSave() {
|
|
testLogger.info('Clicking StreamRouting Save button');
|
|
await this.streamRoutingSaveBtn.waitFor({ state: 'visible' });
|
|
await this.streamRoutingSaveBtn.click();
|
|
}
|
|
|
|
async clickStreamRoutingClose() {
|
|
testLogger.info('Clicking StreamRouting close icon');
|
|
await this.streamRoutingCloseBtn.waitFor({ state: 'visible' });
|
|
await this.streamRoutingCloseBtn.click();
|
|
}
|
|
|
|
async assertStreamRoutingNameErrorVisible() {
|
|
testLogger.info('Asserting stream routing destination name error visible');
|
|
await expect(this.streamRoutingDestNameError).toBeVisible({ timeout: 5000 });
|
|
}
|
|
|
|
async assertStreamRoutingStreamTypeErrorVisible() {
|
|
testLogger.info('Asserting stream routing stream type error visible');
|
|
await expect(this.streamRoutingStreamTypeError).toBeVisible({ timeout: 5000 });
|
|
}
|
|
|
|
async selectUrlSource() {
|
|
testLogger.info('Selecting URL data source');
|
|
// OOptionGroup renders each option — click the "url" option
|
|
const urlOption = this.enrichmentSourceGroup.locator('[data-value="url"], [value="url"]').first();
|
|
// Fallback: click by visible text
|
|
const urlBtn = this.enrichmentSourceGroup.getByText('From URL').first();
|
|
await urlBtn.waitFor({ state: 'visible', timeout: 5000 }).catch(async () => {
|
|
await urlOption.click();
|
|
});
|
|
await urlBtn.click().catch(() => urlOption.click());
|
|
testLogger.info('URL source selected');
|
|
}
|
|
}
|
|
|
|
module.exports = FunctionsFormValidationPage;
|