mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-05 00:09:35 +00:00
ktx-akshay
62d5f2d9e2
### **PR Type**
Tests, Enhancement
___
### **Description**
- Add dashboard max query range UI test
- Introduce StreamSettingsPage page object
- Enhance ManagementPage with streaming toggles
- Include maxquery test in CI workflow
___
### Diagram Walkthrough
```mermaid
flowchart LR
spec["Add maxquery Playwright spec"] -- uses --> pm["PageManager utilities"]
spec -- updates --> streamPage["StreamSettingsPage (new)"]
spec -- verifies --> uiWarn["Max duration warning visible"]
pm -- ensures --> streamingDisabled["Streaming disabled via ManagementPage"]
ci["GitHub Actions workflow"] -- includes --> spec
```
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>streams.js</strong><dd><code>New StreamSettingsPage for
stream max query updates</code>
</dd></summary>
<hr>
tests/ui-testing/pages/dashboardPages/streams.js
<ul><li>Add StreamSettingsPage class<br> <li> Implement max query range
update flow<br> <li> Add stable locators and waits<br> <li> Handle modal
close after save</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/6813/files#diff-2f4da2122993aa2151d167a8b60db3ebe382cf4d420a20d18c2b0bc6f38ecab5">+57/-0</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>managementPage.js</strong><dd><code>ManagementPage
refactor and streaming toggle helpers</code>
</dd></summary>
<hr>
tests/ui-testing/pages/generalPages/managementPage.js
<ul><li>Refactor to modern style and quotes<br> <li> Add navigation
helpers with validation<br> <li> Add enable/disable streaming
utilities<br> <li> Improve selectors and waits</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/6813/files#diff-2e67acc9ff9099e14792ddeb7d0160268727fb064b85e6712f6434130cc23fdd">+162/-89</a></td>
</tr>
</table></td></tr><tr><td><strong>Tests</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>maxquery.spec.js</strong><dd><code>Playwright spec for
dashboard max query warning</code>
</dd></summary>
<hr>
tests/ui-testing/playwright-tests/dashboards/maxquery.spec.js
<ul><li>Add end-to-end test for max query limit<br> <li> Use PageManager
and StreamSettingsPage<br> <li> Validate warning visibility and API
response<br> <li> Restore stream setting after test</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/6813/files#diff-bfd34c3de558a41ff9397468dca4b855e2ee821b250087832f6f36fca8e2c36f">+107/-0</a>
</td>
</tr>
</table></td></tr><tr><td><strong>Configuration
changes</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>playwright.yml</strong><dd><code>CI includes max query
dashboard test</code>
</dd></summary>
<hr>
.github/workflows/playwright.yml
<ul><li>Add maxquery.spec.js to Dashboards-Core matrix<br> <li> Minor
YAML formatting adjustments<br> <li> Preserve existing test
matrices</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/6813/files#diff-7afcd2d8f7b49bda74843f209eefb7b2da45f7e7803bf2e4bd636699b76aa2d3">+75/-70</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___