mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 16:09:05 +00:00
## Summary
Comprehensive rework of the `tests/api-testing/` suite. 30+ commits
implementing all 6 phases of the [revamp
plan](../../tests/ui-testing/MD_Files/api%20tests%20revamp/API_TESTS_REVAMP.md).
**Before → After:**
| | Baseline | Final | Δ |
|---|---|---|---|
| passed | 421 | **443** | **+22 ✓** |
| failed | 3 | **2** | -1 (only same pre-existing) |
| skipped | 53 | 39 | -14 (unskipped dead tests now run) |
| xfailed | 1 | 2 | +1 (new visible backend-bug signal) |
| runtime | 588s | **387s** | **-201s (34% faster)** |
**Zero tests that passed in baseline are now failing.** The 2 remaining
failures are the exact pre-existing ones
(`test_enrichment_table_join.py` backend panic + `test_workflow.py` SMTP
env-miss).
## What's in the diff
- **New `support/` framework** — `OpenObserveClient`, endpoint wrappers
(`alerts`, `dashboards`, `streams`, `search`, etc.), `wait_until()`,
payload factories, pytest fixtures, SSE parser. 14 framework selfcheck
tests.
- **16 of 16 OLD-tier test files rewritten** — using the new framework,
unique-suffix names, body validation, `wait_until` instead of
`time.sleep`, parametrize where appropriate.
- **29 files moved into 12 feature folders** mirroring the UI suite
layout
(`tests/{alerts,dashboards,ingest,orgs,pipelines,regression,rum,search,streams,users,workflow}/`).
- **−6,500 LOC net** (copy-paste + dead code removal; new framework adds
back ~1,500).
- **Ruff config** in pyproject.toml: T201 ban on `print()`, PT pytest
rules, B bugbear, UP pyupgrade.
## CI workflow changes
- New job `api_regression_tests`: `strategy.matrix` over the 4 env-flag
combinations (UTF8_VIEW × JOIN_MATCH_ONE) — now runs in parallel instead
of as 4 sequential server reboots in the main job.
- New job `api_fuzz_tests`: schemathesis OpenAPI-driven fuzz against
`/api-doc/openapi.json` (214 endpoints tested). Informational
(`continue-on-error: true`). Each run surfaces **7–10 distinct 5xx
panics** (e.g., empty `sql` body returning 500 instead of 400, traces
endpoints crashing on unescaped path params that get interpolated into
SQL). Filed to backend team for separate triage.
- Server `o2_*.log` files uploaded as artifacts on failure (was:
silently lost).
- `api_tests_summary` now requires BOTH integration + regression to
pass.
### CI infrastructure fixes
A short hardening pass landed after the initial CI run surfaced several
issues:
- **pytest-sugar count inflation** — dropped `--force-sugar` from both
pytest invocations. The flag double-registered sugar on top of the
auto-loaded entry point, inflating the CI test counter ~3x (display
showed 1364 when collection was 486). Counter is now honest.
- **schemathesis 4.x flag migration** — `--base-url` → `-u`,
`--hypothesis-max-examples` → `-n`, `--hypothesis-deadline` →
`--request-timeout`, `--data-generation-method` → `-m`, dropped
`--auth-type basic`. The fuzz job was failing immediately on flag-parse
before this.
- **Regression matrix binary path** — used `${{ github.workspace
}}/target/debug/openobserve` so the absolute path resolves correctly
under `working-directory: tests/api-testing/` (was: every matrix job
failed with "No such file or directory").
- **`permissions: contents: read`** added to all 4 workflow jobs —
closes CodeQL alert #369.
- **Removed redundant server boot** in `api_integration_tests` (leftover
from main's structure after the regression matrix split; was silently
failing to bind to :5080 and getting masked by the first server).
## Backend bugs surfaced (for backend team to track)
The rework uncovered and visibly flagged these as `xfail`/documented
test comments:
1. `DELETE /api/organizations/{id}` returns 404 unconditionally even for
just-created orgs — endpoint appears unimplemented.
2. `test_dashboard_missing_required_fields` triggers backend panic
(returns 500 instead of 400/422).
3. JS `getEnrichmentTableData()` restricted to `_meta` org AND not
exposed in the `/functions/test` endpoint runtime — `ReferenceError`
even with explicit `enrichment_tables: [...]`.
4. Bulk API silently sanitizes invalid `_index` values (`****` → `_`)
without flagging — user data lands in unexpected index.
5. `AVG` of a single value drifts by ~1e-14 (likely float reduction
order; documented tolerance in `test_advanced_sql.py`).
6. Org name validation rejects hyphens (only
`A-Z/a-z/0-9/spaces/underscores`) — not in spec.
Plus 7–10 additional 5xx panics surfaced per fuzz run (input validation
gaps — separate triage list in fuzz job logs).
## Test bugs uncovered + fixed
- `test_pipeline.py`: had two function definitions named
`test_pipeline_creation_and_action_with_schedule` — Python's last-wins
meant the first test's body never executed for years.
- `test_alertsV2.py`: `assert alert_disabled == "False"` was indented
inside an `else:` branch that never executed because the response is
always a dict; AND `enabled` is a bool, not the string `"False"`. Two
layers of broken.
- `test_bulk.py`: variable typo (`valid_bulk_payload` reused on the POST
call) made the invalid-index test silently duplicate the valid case.
- `test_organisations.py`: `test_create_organization` used pre-pytest-4
`yield`-style fixtures — silently ignored by pytest 8.
- `test_js_result_array.py`: 8 tests skipped with `"Temporarily disabled
- failing test"` — the actual cause was that JS functions are restricted
to `_meta` org. One-line fix unskipped all 8.
- `test_fuzzy.py`: 4 tests `@pytest.mark.skip`-ed because they used a
1-minute time window against older static test data → 0 hits → flake →
skip. Wider window unskips them.
- 547 LOC of zombie commented-out test blocks deleted (15 commented `#
def test_` definitions, including one orphan case where the `def` was
commented but the indented body wasn't).
## Folder layout
```
tests/api-testing/
├── support/ # NEW framework
│ ├── client.py # OpenObserveClient
│ ├── endpoints/ # 7 per-resource wrappers
│ ├── factories.py # unique_name, time_window, *_payload
│ ├── wait.py # wait_until + WaitTimeout
│ ├── sse.py # read_sse_response
│ └── fixtures.py # client, temp_user_email, temp_stream_name, ...
├── helpers/ # Non-test shared code (was scattered in tests/)
│ ├── sourcemap_helpers.py
│ └── workflow/ # workflow chain + pages/ live here now
├── fixtures/
│ └── rum/ # Standalone RUM ingest scripts (was in tests/)
└── tests/
├── alerts/ # 3 files
├── dashboards/ # 4 files
├── ingest/ # 4 files
├── orgs/ # 2 files
├── pipelines/ # 10 files
├── regression/ # 2 files (env-flag matrix targets)
├── rum/ # 3 files
├── search/ # 8 files
├── streams/ # 1 file
├── users/ # 1 file
├── workflow/ # 3 files
├── conftest.py
└── test_framework_selfcheck.py
```
## Test plan
- [x] `rye run pytest --collect-only` — 486 tests discovered
- [x] Full default-set run (`--ignore=tests/regression`) — 443 pass / 2
fail / 39 skip / 2 xfail in 387s
- [x] `rye run pytest -m framework` — 14/14 selfcheck tests pass
- [x] `rye run ruff check support/ tests/test_framework_selfcheck.py` —
clean
- [x] CI run on this PR — `api_integration_tests` + all 4
`api_regression_tests` matrix jobs green
- [x] CI run — `api_fuzz_tests` runs cleanly (informational; surfaces
7–10 unique 5xx panics per run)
## Note on test count
The `test_streaming.py` rewrite folded 7 "tests" (`test_ingest_data`,
`test_ingest_join`, `test_disable_streaming`,
`test_update_max_query_range`, `test_enable_streaming`,
`test_delete_stream`, `test_delete_stream_join`) into pytest fixtures.
Each only checked `status_code == 200` of a setup/teardown operation —
they were imperative steps masquerading as tests. The fixtures still
perform the same operations and assert their success; they're just no
longer counted as discrete pytest items. **Functional coverage is
identical.**
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
161 lines
4.5 KiB
Python
161 lines
4.5 KiB
Python
"""Payload factory functions for API requests.
|
|
|
|
Each factory returns a dict that can be passed to `client.<resource>.create(...)`.
|
|
Sensible defaults are merged with caller-supplied overrides via `**kwargs`.
|
|
|
|
Pattern: small functions, named per the API resource. No classes — these are
|
|
just typed dict builders.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import uuid
|
|
from datetime import datetime, timedelta, UTC
|
|
from typing import Any
|
|
|
|
|
|
def _ms_epoch(dt: datetime) -> int:
|
|
"""OpenObserve time fields are microseconds-since-epoch as int."""
|
|
return int(dt.timestamp() * 1_000_000)
|
|
|
|
|
|
def time_window(*, minutes: int = 15) -> tuple[int, int]:
|
|
"""Return (start, end) microsecond-epoch ints for the last `minutes` minutes."""
|
|
now = datetime.now(UTC)
|
|
end = _ms_epoch(now)
|
|
start = _ms_epoch(now - timedelta(minutes=minutes))
|
|
return start, end
|
|
|
|
|
|
def unique_name(prefix: str = "pytest") -> str:
|
|
"""Generate a unique, lowercase, alphanumeric resource name.
|
|
|
|
Used to prevent cross-test resource collisions. The original suite had
|
|
fixed names like `pytests@gmail.com` that caused cascading failures and
|
|
blocked parallel runs.
|
|
"""
|
|
return f"{prefix}_{uuid.uuid4().hex[:8]}"
|
|
|
|
|
|
def unique_email(prefix: str = "pytest") -> str:
|
|
"""Generate a unique test email (using .invalid TLD per RFC 2606)."""
|
|
return f"{prefix}_{uuid.uuid4().hex[:8]}@test.invalid"
|
|
|
|
|
|
# ----- payload factories -----
|
|
|
|
|
|
def search_payload(
|
|
sql: str,
|
|
*,
|
|
start_time: int | None = None,
|
|
end_time: int | None = None,
|
|
size: int = 100,
|
|
from_: int = 0,
|
|
quick_mode: bool = False,
|
|
track_total_hits: bool = False,
|
|
) -> dict[str, Any]:
|
|
"""SQL search request body for POST /api/{org}/_search.
|
|
|
|
Note: `track_total_hits` defaults to **False**. When True, OO switches
|
|
to histogram-aggregate mode and returns `{"zo_sql_num": <count>}` instead
|
|
of raw hits, which surprises callers expecting individual records.
|
|
Callers that genuinely want the aggregate count can pass True explicitly.
|
|
"""
|
|
if start_time is None or end_time is None:
|
|
s, e = time_window(minutes=15)
|
|
start_time = start_time if start_time is not None else s
|
|
end_time = end_time if end_time is not None else e
|
|
return {
|
|
"query": {
|
|
"sql": sql,
|
|
"start_time": start_time,
|
|
"end_time": end_time,
|
|
"from": from_,
|
|
"size": size,
|
|
"quick_mode": quick_mode,
|
|
"track_total_hits": track_total_hits,
|
|
}
|
|
}
|
|
|
|
|
|
def user_payload(
|
|
*,
|
|
email: str | None = None,
|
|
password: str = "Complexpass#123",
|
|
first_name: str = "Pytest",
|
|
last_name: str = "User",
|
|
role: str = "admin",
|
|
organization: str = "default",
|
|
) -> dict[str, Any]:
|
|
"""User create/update body."""
|
|
return {
|
|
"email": email or unique_email(),
|
|
"password": password,
|
|
"first_name": first_name,
|
|
"last_name": last_name,
|
|
"role": role,
|
|
"organization": organization,
|
|
}
|
|
|
|
|
|
def dashboard_payload(
|
|
*,
|
|
title: str | None = None,
|
|
description: str = "",
|
|
folder_id: str = "default",
|
|
version: int = 8,
|
|
tabs: list | None = None,
|
|
) -> dict[str, Any]:
|
|
"""Dashboard create body."""
|
|
return {
|
|
"version": version,
|
|
"title": title or unique_name("dashboard"),
|
|
"description": description,
|
|
"folder_id": folder_id,
|
|
"tabs": tabs if tabs is not None else [],
|
|
}
|
|
|
|
|
|
def alert_template_payload(
|
|
*,
|
|
name: str | None = None,
|
|
body: str | None = None,
|
|
type_: str = "http",
|
|
title: str = "",
|
|
) -> dict[str, Any]:
|
|
"""Alert template create body."""
|
|
return {
|
|
"name": name or unique_name("template"),
|
|
"body": body or '{"text": "alert {alert_name} on {stream_name} active"}',
|
|
"type": type_,
|
|
"title": title,
|
|
}
|
|
|
|
|
|
def webhook_destination_payload(
|
|
*,
|
|
name: str | None = None,
|
|
url: str = "http://localhost:0/sink", # test default — override per test
|
|
method: str = "post",
|
|
template: str,
|
|
headers: dict | None = None,
|
|
skip_tls_verify: bool = False,
|
|
) -> dict[str, Any]:
|
|
"""Webhook destination create body."""
|
|
return {
|
|
"name": name or unique_name("dest"),
|
|
"url": url,
|
|
"method": method,
|
|
"template": template,
|
|
"headers": headers or {},
|
|
"skip_tls_verify": skip_tls_verify,
|
|
}
|
|
|
|
|
|
def folder_payload(*, name: str | None = None, description: str = "") -> dict[str, Any]:
|
|
"""Folder create body (alerts or dashboards)."""
|
|
return {
|
|
"name": name or unique_name("folder"),
|
|
"description": description,
|
|
}
|