From d688421f60c0d2c1ba2ca2113c7d2f7a7dbe2399 Mon Sep 17 00:00:00 2001
From: Albrecht Lohofener <albrechtloh@gmx.de>
Date: Wed, 8 Jan 2025 12:46:09 +0100
Subject: [PATCH] Some minor fixes

---
 Dockerfile         | 3 ++-
 readme.md          | 2 +-
 src/run_openwrt.sh | 6 ++++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index ac467f1..e92e775 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -67,7 +67,8 @@ RUN echo "Building for platform '$TARGETPLATFORM'" \
         usbutils \
         openssh-client \
         util-linux-misc \
-        iproute2 \
+        iproute2  \
+    # It seems that PROFINET packages are not forwarded correctly without the package iproute2. The reason is unknown. \
     && mkdir -p /usr/share/novnc \
     && wget https://github.com/novnc/noVNC/archive/refs/tags/v${NOVNC_VERSION}.tar.gz -O /tmp/novnc.tar.gz -q \
     && tar -xf /tmp/novnc.tar.gz -C /tmp/ \
diff --git a/readme.md b/readme.md
index c344110..9f12b8e 100644
--- a/readme.md
+++ b/readme.md
@@ -9,7 +9,7 @@ This Docker container brings you OpenWrt, a software-based router solution, in a
 ## Features
 
  - Supports all x86_64 and arm64 Linux based systems
-   - x86_64 tested on some Intel and AMD system
+   - x86_64 tested on some Intel and AMD systems
    - arm64 tested on a [Raspberry Pi 5](https://www.raspberrypi.com/products/raspberry-pi-5/) and Weidmueller [UC20-M4000](https://eshop.weidmueller.com/en/uc20-m4000/p/2839160000)
  - Uses official x86_64 and armsr (arm64) OpenWrt builds
  - Full system virtualization with qemu
diff --git a/src/run_openwrt.sh b/src/run_openwrt.sh
index fa14d2c..b6f1537 100755
--- a/src/run_openwrt.sh
+++ b/src/run_openwrt.sh
@@ -55,14 +55,16 @@ attach_eth_if () {
   QEMU_IF_MAC=${QEMU_MAC_OUI}${MAC:8} # Replaces the 8 first characters of the original MAC
 
   # Deacticate host interface
-  # Ensure the interface is down to reliably change the MAC address without issues
+  # Ensure the interface is down to reliably change the MAC address without issues.
+  # Especially on Weidmueller UC20-M4000 this is necessary
   ip link set $CONTAINER_IF down
 
   # Change MAC address of new interface
   ip link set $QEMU_IF address $QEMU_IF_MAC
 
   # Reactivate interfaces
-  ip link set $QEMU_IF up && ip link set $CONTAINER_IF up
+  ip link set $QEMU_IF up
+  ip link set $CONTAINER_IF up
 }
 
 # Create veth pairs between host system and Docker container