From 0628bd1e94444dcde268bb8198fcebf635a7c39f Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Sun, 26 Jul 2026 15:08:25 -0700 Subject: [PATCH] fix(terminal): log pane recovery at warn, not error STA-2373 made this path routine: every daemon death now remounts each live pane, so error level floods logs and crash telemetry with a message that reports recovery *succeeding*. The breadcrumb right below is what diagnostics actually consume. --- .../src/components/terminal-pane/terminal-pane-recovery.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/renderer/src/components/terminal-pane/terminal-pane-recovery.ts b/src/renderer/src/components/terminal-pane/terminal-pane-recovery.ts index 791234b232b..146dc82a6e2 100644 --- a/src/renderer/src/components/terminal-pane/terminal-pane-recovery.ts +++ b/src/renderer/src/components/terminal-pane/terminal-pane-recovery.ts @@ -261,7 +261,10 @@ export async function requestTerminalPaneRecovery(request: RecoveryRequest): Pro // A remount replaces every pane xterm in the tab; a previously scheduled // retry would only re-remount the fresh, healthy panes. cancelPendingRecoveryRetry(request.tabId) - console.error( + // warn, not error: this is the recovery succeeding, and the breadcrumb below is + // what diagnostics actually read. STA-2373 made this path routine (every daemon + // death remounts each live pane), so error level just floods logs and telemetry. + console.warn( `[terminal] recovering pane tab ${request.tabId} — ${request.reason} with a live PTY (${request.ptyId ?? 'unbound'}); remounting to rebuild the renderer` ) recordRendererCrashBreadcrumb('terminal_pane_recovery_remount', {