From 06d487b428a2d87f303b7babb7a5debc8fa979de Mon Sep 17 00:00:00 2001 From: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Date: Sun, 15 Nov 2026 17:59:51 -0800 Subject: [PATCH] Re-announce identical retry results --- .../identity/AutoRenameFailedDialog.test.tsx | 20 +++++++++++++++++++ .../identity/AutoRenameFailedDialog.tsx | 10 ++++++++-- 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.test.tsx b/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.test.tsx index d1bc20fe5f2..17be2439479 100644 --- a/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.test.tsx +++ b/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.test.tsx @@ -398,4 +398,24 @@ describe('AutoRenameFailedDialog sessions and focus', () => { await act(async () => frames.splice(0).forEach((frame) => frame(0))) expect(document.activeElement?.getAttribute('aria-label')).toBe('Dismiss') }) + + it('re-announces an identical result by clearing the live region while naming runs', async () => { + await renderFailure() + const liveRegion = () => document.querySelector('[aria-live="polite"]')?.textContent ?? '' + retryBranchAutoRename.mockResolvedValueOnce({ + attemptId: 1, + outcome: { kind: 'nothing-yet' }, + finishedAt: 1 + }) + await act(async () => button('Try again')?.click()) + expect(liveRegion()).toBe('No changes to name this branch from yet.') + const second = Promise.withResolvers() + retryBranchAutoRename.mockReturnValueOnce(second.promise) + await act(async () => button('Try again')?.click()) + expect(liveRegion()).toBe('') + await act(async () => + second.resolve({ attemptId: 2, outcome: { kind: 'nothing-yet' }, finishedAt: 1 }) + ) + expect(liveRegion()).toBe('No changes to name this branch from yet.') + }) }) diff --git a/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.tsx b/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.tsx index b7d572f825c..43e7eca2621 100644 --- a/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.tsx +++ b/src/renderer/src/components/sidebar/workspace-card/identity/AutoRenameFailedDialog.tsx @@ -170,6 +170,7 @@ export function AutoRenameFailedDialog({ showFooterClose={false} reason={branchAutoRenameReasonText(retry.lastOutcome, t)} detailsFinishedAt={retry.lastFinishedAt} + announcementPaused={retry.running} action={ <>