From 072ed656fc949fd8635ed3000083eada94e4b766 Mon Sep 17 00:00:00 2001 From: Neil Date: Mon, 16 Nov 2026 02:25:55 -0800 Subject: [PATCH] fix(cloud): git-actor caveat says approvals happen on GitHub MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Approvals from inside a workspace are refused (#836) and sharing is held, so the source-control tooltip's "Approvals always go out as Orca bot, and so do merges in shared workspaces" was wrong. Now: "Approve pull requests on GitHub. Workspaces can’t approve." (en only; no other locale had the string). --- .../src/components/cloud-workspaces/cloud-git-acting-copy.ts | 4 ++-- src/renderer/src/i18n/locales/en.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/src/components/cloud-workspaces/cloud-git-acting-copy.ts b/src/renderer/src/components/cloud-workspaces/cloud-git-acting-copy.ts index 918225064eb..efbda9e4c6e 100644 --- a/src/renderer/src/components/cloud-workspaces/cloud-git-acting-copy.ts +++ b/src/renderer/src/components/cloud-workspaces/cloud-git-acting-copy.ts @@ -63,10 +63,10 @@ export function gitActingLine(answer: CloudGitActing | null, t: Translate): GitA } } -/** The caveat that holds whatever the line says. */ +/** The caveat that holds whatever the line says: approvals are refused inside a workspace. */ export function gitActingCaveat(t: Translate): string { return t( 'cloudGitActing.caveat', - 'Approvals always go out as Orca bot, and so do merges in shared workspaces.' + 'Approve pull requests on GitHub. Workspaces can’t approve.' ) } diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json index 384e9c726ca..767b9c0851d 100644 --- a/src/renderer/src/i18n/locales/en.json +++ b/src/renderer/src/i18n/locales/en.json @@ -29313,7 +29313,7 @@ "bot": "Pushes and PRs go out as Orca bot", "stale": "Pushes and PRs go out as Orca bot (no one has sent in the last hour)", "noSenderYet": "Pushes and PRs go out as whoever sends next, or Orca bot", - "caveat": "Approvals always go out as Orca bot, and so do merges in shared workspaces.", + "caveat": "Approve pull requests on GitHub. Workspaces can’t approve.", "connect": "Connect GitHub" }, "cloudFollow": {