From 07ff1fce75bd5ee3f17d9902c41efb361316ca18 Mon Sep 17 00:00:00 2001 From: Neil Date: Wed, 11 Nov 2026 06:22:00 -0800 Subject: [PATCH] fix(cloud): RR-c1 the links read as links at rest (underline), focus ring shown; test props --- .../run-on/OrcaCloudNeedsRepoLine.fixture.tsx | 8 ++++++++ .../new-workspace/run-on/OrcaCloudNeedsRepoLine.tsx | 9 ++++++--- .../new-workspace/run-on/OrcaCloudWallLine.tsx | 2 +- .../new-workspace/run-on/orca-cloud-needs-repo.test.tsx | 1 + 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.fixture.tsx b/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.fixture.tsx index 8d15d466d2f..27f61c40656 100644 --- a/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.fixture.tsx +++ b/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.fixture.tsx @@ -26,3 +26,11 @@ export const noGitHubRepositories = defineFixture({ ) }) +// Keyboard: the link shows its focus ring. +export const focused = defineFixture({ + ...withGitHubRepositories, + interact: async (frame: HTMLElement) => { + frame.querySelector('button')?.focus() + await new Promise((resolve) => setTimeout(resolve, 100)) + } +}) diff --git a/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.tsx b/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.tsx index 9e931968302..1e7dcb5f235 100644 --- a/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.tsx +++ b/src/renderer/src/components/new-workspace/run-on/OrcaCloudNeedsRepoLine.tsx @@ -39,9 +39,12 @@ export function OrcaCloudNeedsRepoLine({ size="statusAction" onClick={hasRepos ? onChooseRepository : onAddRepository} > - {hasRepos - ? t('components.newWorkspace.cloudOnly.chooseRepository', 'Choose repository') - : t('components.newWorkspace.cloudOnly.addRepository', 'Add a GitHub repository')} + {/* Reads as a link at rest, not only on hover (design-squad). */} + + {hasRepos + ? t('components.newWorkspace.cloudOnly.chooseRepository', 'Choose repository') + : t('components.newWorkspace.cloudOnly.addRepository', 'Add a GitHub repository')} + diff --git a/src/renderer/src/components/new-workspace/run-on/OrcaCloudWallLine.tsx b/src/renderer/src/components/new-workspace/run-on/OrcaCloudWallLine.tsx index 6a9363cdfe6..997b4754d7a 100644 --- a/src/renderer/src/components/new-workspace/run-on/OrcaCloudWallLine.tsx +++ b/src/renderer/src/components/new-workspace/run-on/OrcaCloudWallLine.tsx @@ -18,7 +18,7 @@ export function OrcaCloudWallLine({ wall }: { wall: OrcaCloudWallNotice }): Reac // statusAction pads its label by px-1; the wrapper's -mx-1 puts the text flush-left.
) : ( diff --git a/src/renderer/src/components/new-workspace/run-on/orca-cloud-needs-repo.test.tsx b/src/renderer/src/components/new-workspace/run-on/orca-cloud-needs-repo.test.tsx index 4ef5b782843..60d313e40d7 100644 --- a/src/renderer/src/components/new-workspace/run-on/orca-cloud-needs-repo.test.tsx +++ b/src/renderer/src/components/new-workspace/run-on/orca-cloud-needs-repo.test.tsx @@ -33,6 +33,7 @@ describe('Orca Cloud on a plain-folder project (RR-c1)', () => { const { getByRole } = render(