From 08faa01db5e4c45b64032f3c8e03fe1d0caab8e8 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Thu, 6 Aug 2026 13:51:06 -0700 Subject: [PATCH] =?UTF-8?q?docs(e2e):=20correct=2019a8d133db7=20=E2=80=94?= =?UTF-8?q?=20the=20Korean=20preedit=20spec=20has=20been=20executed?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit That commit said the landed form had never run and carried the probe's values as literals. It has now run on real hardware: 1 passed, 9.1s, rc=0, with the capture and log sealed under a verified hash manifest. The teeth check was also run rather than reasoned about, and it changes which assertion matters. Forcing the active overlay to max-width:0 with overflow:hidden — invisible on screen — leaves the active class, the textContent, display:block AND checkVisibility() all passing. Only during.rect.width fails. checkVisibility() is not sufficient against this defect; the bounding rect is the single load-bearing assertion, which the docblock already said and this run confirms. An earlier teeth attempt injected the CSS mid-run and tripped the hasActiveClass poll instead, failing at the wrong assertion. It is inconclusive and excluded from the seal rather than counted. --- .../terminal-macos-2set-korean-preedit-visibility.spec.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/e2e/terminal-macos-2set-korean-preedit-visibility.spec.ts b/tests/e2e/terminal-macos-2set-korean-preedit-visibility.spec.ts index 98344b7aade..b262cdeca91 100644 --- a/tests/e2e/terminal-macos-2set-korean-preedit-visibility.spec.ts +++ b/tests/e2e/terminal-macos-2set-korean-preedit-visibility.spec.ts @@ -30,6 +30,12 @@ * Values below were recorded from a live run under `com.apple.inputmethod.Korean.2SetKorean`; * see `11914-c3-live-preedit-visibility.txt` in the lane capture directory. That capture is * gitignored and is cited, never imported. + * + * Correction to this file's own landing commit (19a8d133db7), which said the spec had not been + * executed in this form: it has. It passes on real hardware — 1 passed, 9.1s, rc=0 — and the + * teeth check above was run against it rather than reasoned about. Both logs are sealed + * alongside the capture. An earlier teeth attempt that injected the CSS mid-run tripped the + * `hasActiveClass` poll instead of the rect assertion; it is inconclusive and excluded. */ import { execFileSync } from 'node:child_process' import path from 'node:path'