From 09645627864f0ef778662f05ec7fdd4fcd6e4797 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Thu, 22 Oct 2026 00:23:32 -0700 Subject: [PATCH] refactor(orcad): drop the toolchain probe's unread toolchainMissing verdict (#31875) --- src/main/orcad/build-toolchain-diagnosis.ts | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/main/orcad/build-toolchain-diagnosis.ts b/src/main/orcad/build-toolchain-diagnosis.ts index 3efacdeb1c3..1e7c9eb54e6 100644 --- a/src/main/orcad/build-toolchain-diagnosis.ts +++ b/src/main/orcad/build-toolchain-diagnosis.ts @@ -30,16 +30,6 @@ const PACKAGE_MANAGER_HINTS: readonly { bin: string; install: string }[] = [ type BuildToolchainStatus = { present: string[] packageManager: string | null - // A node-pty source build needs make, Python, and a C++ compiler. - toolchainMissing: boolean -} - -function hasCxxCompiler(present: ReadonlySet): boolean { - return present.has('g++') || present.has('c++') || present.has('clang++') -} - -function hasPython(present: ReadonlySet): boolean { - return present.has('python3') || present.has('python') } // POSIX-sh probe: echo a `HAVE ` line per resolvable build tool and a @@ -70,8 +60,7 @@ export function parseBuildToolchainProbe(output: string): BuildToolchainStatus { } return { present: PROBED_TOOLS.filter((tool) => present.has(tool)), - packageManager, - toolchainMissing: !present.has('make') || !hasCxxCompiler(present) || !hasPython(present) + packageManager } }