From 0bdf4af437e43a6b977b717ddaa3ea7dcfdcfda3 Mon Sep 17 00:00:00 2001 From: Neil Date: Tue, 10 Nov 2026 04:58:17 -0800 Subject: [PATCH] fix(cloud): D1 GitHub row drives the primary 'Give access and start' instead of an in-row button --- src/renderer/src/i18n/locales/en.json | 2 +- .../lib/orca-cloud/orca-cloud-github-setup-row.test.ts | 2 +- .../src/lib/orca-cloud/orca-cloud-github-setup-row.ts | 10 +++++++--- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json index 11695a0a184..f8f464ae045 100644 --- a/src/renderer/src/i18n/locales/en.json +++ b/src/renderer/src/i18n/locales/en.json @@ -27101,7 +27101,7 @@ "missing": "Orca Cloud can’t reach {{repo}} yet.", "neededStatus": "Needed", "missingNote": "It clones your code from GitHub. Give access to this repository once.", - "giveAccess": "Give access", + "giveAccessAndStart": "Give access and start", "public": "{{repo}} is public. Nothing to do.", "doneStatus": "Done" } diff --git a/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.test.ts b/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.test.ts index ca01a15e53c..7347b00269e 100644 --- a/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.test.ts +++ b/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.test.ts @@ -39,7 +39,7 @@ describe('orcaCloudGitHubSetupRow', () => { label: 'GitHub access', status: 'Needed', note: 'It clones your code from GitHub. Give access to this repository once.', - action: { kind: 'install' }, + primary: { kind: 'install', label: 'Give access and start' }, blocksStart: true }) }) diff --git a/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.ts b/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.ts index b73ce886d53..92715107e17 100644 --- a/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.ts +++ b/src/renderer/src/lib/orca-cloud/orca-cloud-github-setup-row.ts @@ -17,7 +17,10 @@ export type OrcaCloudGitHubSetupRow = { status?: string /** Second line under the detail (D1/D2). */ note?: string - action?: { kind: 'install'; label: string } | { kind: 'push-help'; label: string; url: string } + /** In-row button (D3's "How to push"). */ + action?: { kind: 'push-help'; label: string; url: string } + /** What the panel's primary (⌘↵) button becomes while this row is the blocker (D1). */ + primary?: { kind: 'install'; label: string } /** D3 outranks account and plan rows: buying can't fix a project that isn't on GitHub. */ blocksStart: boolean } @@ -86,9 +89,10 @@ export function orcaCloudGitHubSetupRow( 'orcaCloud.setup.github.missingNote', 'It clones your code from GitHub. Give access to this repository once.' ), - action: { + // D1: no button in the row; the panel's primary action opens GitHub's install page. + primary: { kind: 'install', - label: translate('orcaCloud.setup.github.giveAccess', 'Give access') + label: translate('orcaCloud.setup.github.giveAccessAndStart', 'Give access and start') }, blocksStart: true }