starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-11-04 11:07:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ci): ratchet raw repo connectionId host checks; migrate the cheap ones (#31096)

Browse Source 
* feat(ci): ratchet raw repo connectionId host reads; one drop-in resolver

Codex review 6 class fix (#4/#6/#7): host decisions read off a repo row's
legacy connectionId miss rows that name SSH only as executionHostId.

- getRepoRoutingConnectionId (shared/execution-host.ts): drop-in for a raw
  repo.connectionId routing check that also finds executionHostId-only SSH.
- check-repo-host-read-ratchet: per-file count of raw repo connectionId
  reads in src/main, src/shared, src/cli; counts may only shrink.
- Migrated 66 cheap reads: runtime GitHub/GitLab commands, PR/MR head ref
  fetches, preserved-branch cleanup, ref queries, base-ref IPC, worktree
  preparation, trash sweep, scan cache TTL, usage metadata.

* fix(ipc): PR base IPC routes executionHostId-only SSH rows; ratchet is a stated lower bound

Review follow-up (Opus on #31096):
- worktrees:resolvePrBase decided git/gh routing on the raw connectionId while
  its head-ref fetches already used the resolver; one resolved connectionId
  now drives all of it (test fails on main).
- getRepoRoutingConnectionId's contract is stated exactly: never local when the
  raw field is set; on a contradictory ssh row executionHostId wins.
- The ratchet regex no longer matches report.connectionId; header and docs
  say it is a lower bound.
- Regression tests for a runtime GitHub and GitLab command site.

* test(ci): pin the repo host-read ratchet step to the static phase

* fix(ci): repo host-read ratchet skips verbatim field copies into projected rows

A copy of connectionId into a projected row decides nothing; migrating it to
the resolver would change what the projection publishes. The sidebar feed
catalog's copy (added after the baseline) and two older projections no longer
count; baseline pruned to 91.
This commit is contained in:
Neil
2026-10-20 14:00:32 -07:00
committed by GitHub
parent 8a4ef49a4d
commit 12bf32836b
27 changed files with 478 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/runtime/runtime-worktree-scan-cache.ts
+5 -2
View File
@@ -1,11 +1,14 @@
import type { Repo } from '../../shared/repo-types'
import { isAgentScratchRepoRootPath } from '../../shared/agent-scratch-worktrees'
import { getRepoRoutingConnectionId } from '../../shared/execution-host'
const WORKTREE_SCAN_CACHE_TTL_MS = 30_000
const WORKTREE_SCAN_AGENT_SCRATCH_TTL_MS = 5 * 60_000
export function resolveWorktreeScanCacheTtlMs(repo: Pick<Repo, 'path' | 'connectionId'>): number {
return !repo.connectionId && isAgentScratchRepoRootPath(repo.path)
export function resolveWorktreeScanCacheTtlMs(
repo: Pick<Repo, 'path' | 'connectionId' | 'executionHostId'>
): number {
return !getRepoRoutingConnectionId(repo) && isAgentScratchRepoRootPath(repo.path)
? WORKTREE_SCAN_AGENT_SCRATCH_TTL_MS
: WORKTREE_SCAN_CACHE_TTL_MS
}