From 15ec98b2cfbe4e4879e18999b636463b075a73b6 Mon Sep 17 00:00:00 2001 From: brennanb2025 Date: Sat, 4 Jul 2026 15:26:19 -0700 Subject: [PATCH] Address review round 2: restore TEST_REPO_PATH_FILE import in split e2e helper MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - seeded-test-repo.ts: re-add the TEST_REPO_PATH_FILE import the round-1 split dropped (runtime-only ReferenceError on the worker's stale-repo fallback path — tests/e2e sits outside all typecheck configs), and drop the stray fixture JSDoc that came along with the extraction. Fallback verified by invoking createSeededTestRepo directly. - types.ts: qualify the two See-references to authority docs that ship with PR #7214 rather than this branch. Co-authored-by: Orca --- src/shared/types.ts | 4 ++-- tests/e2e/helpers/seeded-test-repo.ts | 10 +--------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/shared/types.ts b/src/shared/types.ts index 125ff61b6ac..9eab72a2dca 100644 --- a/src/shared/types.ts +++ b/src/shared/types.ts @@ -2717,7 +2717,7 @@ export type GlobalSettings = { * `pty:sideEffect` channel and renderer byte parsers stay unregistered for * those PTYs; `false` restores renderer byte parsing. This build ships it * false — no main emitter exists until PR #7214 (see constants.ts). - * See docs/reference/terminal-side-effect-authority.md. */ + * See docs/reference/terminal-side-effect-authority.md (ships with #7214). */ terminalMainSideEffectAuthority?: boolean /** Kill switch for main's hidden-delivery gate (Phase 4): when true AND * terminalMainSideEffectAuthority is on, main drops PTY byte delivery to @@ -2730,7 +2730,7 @@ export type GlobalSettings = { * (DA1/CPR/DECRPM, …) embedded in hidden-dropped chunks from the runtime * emulator. `false` silences the responder without changing drops. This * build ships it false — the responder arrives with PR #7214. - * See docs/reference/terminal-query-authority.md. */ + * See docs/reference/terminal-query-authority.md (ships with #7214). */ terminalModelQueryAuthority?: boolean /** Which agent to pre-select in the new-workspace composer. * - null: auto (first detected agent) diff --git a/tests/e2e/helpers/seeded-test-repo.ts b/tests/e2e/helpers/seeded-test-repo.ts index f551e592fee..362249eee93 100644 --- a/tests/e2e/helpers/seeded-test-repo.ts +++ b/tests/e2e/helpers/seeded-test-repo.ts @@ -4,6 +4,7 @@ * touching the developer's repos. Extracted from orca-app.ts (fixture host). */ import { execSync } from 'node:child_process' +import { TEST_REPO_PATH_FILE } from '../global-setup' import { existsSync, mkdirSync, mkdtempSync, realpathSync, writeFileSync } from 'node:fs' import { randomUUID } from 'node:crypto' import os from 'node:os' @@ -64,12 +65,3 @@ export function createSeededTestRepo(): string { writeFileSync(TEST_REPO_PATH_FILE, testRepoDir) return testRepoDir } - -/** - * Extended Playwright test with Orca-specific fixtures. - * - * `orcaPage` — the main Orca renderer window. - * - * Test-scoped: each test gets a fresh Electron instance and isolated - * userData directory so state cannot leak across specs through persistence. - */