From 2259e06ff65842ee680df3bb3c681922dd649b38 Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Sun, 30 Aug 2026 00:57:14 -0700 Subject: [PATCH] fix(tests): match showInactive() in paired-client-window-reveal spec (#17362) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #17347 switched the reveal helper from window.show() to window.showInactive() and updated the thrown message, but left the unit test's regex/title matching the old show() wording — failing deterministically in CI (which builds against current main) while passing on any stale checkout that predates #17347. --- tests/e2e/helpers/paired-client-window-reveal.unit.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/e2e/helpers/paired-client-window-reveal.unit.test.ts b/tests/e2e/helpers/paired-client-window-reveal.unit.test.ts index 2f5cf79be5c..dfb83e4c441 100644 --- a/tests/e2e/helpers/paired-client-window-reveal.unit.test.ts +++ b/tests/e2e/helpers/paired-client-window-reveal.unit.test.ts @@ -32,13 +32,13 @@ describe('assertPairedClientWindowRevealed', () => { ).toThrow(/no BrowserWindow/) }) - it('rejects a window that stays hidden after show()', () => { + it('rejects a window that stays hidden after showInactive()', () => { expect(() => assertPairedClientWindowRevealed({ isVisible: false, wasVisible: false, windowCount: 2 }) - ).toThrow(/stayed hidden after show\(\)/) + ).toThrow(/stayed hidden after showInactive\(\)/) }) })