Display private GitHub attachment images in fetched items (#39250)

* Display private GitHub attachment images in fetched items

* Keep attachment event identity aligned with committed renders

* Complete GitHub image response type contracts

* Return private image sources with accepted issue edits

* Keep issue edits successful without optional display data

* Cover unusable issue edit image responses

* Keep optional GitHub image parsing from failing accepted saves

* Fetch GitHub body images with the existing body read
This commit is contained in:
Brennan Benson
2026-11-08 11:58:15 -08:00
committed by GitHub
parent b4f198379a
commit 252b427dfd
54 changed files with 2130 additions and 216 deletions
+2
View File
@@ -21,6 +21,8 @@ export type PRComment = {
author: string
authorAvatarUrl: string
body: string
/** Transient display sources from the same body fetch; never submit or persist these URLs. */
bodyImageUrls?: Record<string, string>
createdAt: string
url: string
reactions?: GitHubReaction[]
+1 -1
View File
@@ -103,7 +103,7 @@ export type ProjectWorkItemDetailsBySlugResult =
| { ok: false; error: GitHubProjectViewError }
export type GitHubProjectMutationResult =
| { ok: true }
| { ok: true; bodyImageUrls?: Record<string, string> }
| { ok: false; error: GitHubProjectViewError }
export type GitHubProjectCommentMutationResult =
+1
View File
@@ -60,6 +60,7 @@ export type GitHubWorkItemDetails = {
// Main lacks Orca Repo.id; renderer stamps it when storing details.
item: Omit<GitHubWorkItem, 'repoId'>
body: string
bodyImageUrls?: Record<string, string>
comments: PRComment[]
/** Issue-only provider activity such as assignment, references, project moves, and state changes. */
timelineItems?: GitHubIssueTimelineItem[]