From 252df570f140c49a5b0c170696916d4e111b355c Mon Sep 17 00:00:00 2001 From: Merge Sim Date: Tue, 1 Sep 2026 14:15:42 -0700 Subject: [PATCH] fix(native-chat): make the structured close-failure toast provider-neutral The structuredSessionCloseFailed toast fires for any structured session, but its copy said 'Codex chat', so a Claude structured session that fails to close showed the wrong provider name. The launch-failure toast is only reachable behind the agent === 'codex' gate, so its copy stays as is. Claude-Session: https://claude.ai/code/session_013ugSpCx4AWkySaJb69BQax --- .../src/components/tab-group/useTabGroupTabCloseCommands.ts | 2 +- src/renderer/src/components/terminal/terminal-tab-actions.ts | 2 +- src/renderer/src/i18n/locales/en.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/src/components/tab-group/useTabGroupTabCloseCommands.ts b/src/renderer/src/components/tab-group/useTabGroupTabCloseCommands.ts index 5fe23b67927..be8460b2dbf 100644 --- a/src/renderer/src/components/tab-group/useTabGroupTabCloseCommands.ts +++ b/src/renderer/src/components/tab-group/useTabGroupTabCloseCommands.ts @@ -17,7 +17,7 @@ function reportStructuredSessionCloseError(error: unknown): void { toast.error( translate( 'components.native-chat.structuredSessionCloseFailed', - 'Could not close this Codex chat' + 'Could not close this chat session' ), { description: error instanceof Error ? error.message : String(error) } ) diff --git a/src/renderer/src/components/terminal/terminal-tab-actions.ts b/src/renderer/src/components/terminal/terminal-tab-actions.ts index 49bc3d11fef..92eb85b49e5 100644 --- a/src/renderer/src/components/terminal/terminal-tab-actions.ts +++ b/src/renderer/src/components/terminal/terminal-tab-actions.ts @@ -157,7 +157,7 @@ export function closeTerminalTab( toast.error( translate( 'components.native-chat.structuredSessionCloseFailed', - 'Could not close this Codex chat' + 'Could not close this chat session' ), { description: translate( diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json index a59cc41c520..4ba810c5842 100644 --- a/src/renderer/src/i18n/locales/en.json +++ b/src/renderer/src/i18n/locales/en.json @@ -16707,7 +16707,7 @@ "message": "Structured Chat blocks terminal prompts and sends. Orchestration messages remain queued; switch to Terminal, then check the Orca inbox with", "command": "orca orchestration check" }, - "structuredSessionCloseFailed": "Could not close this Codex chat", + "structuredSessionCloseFailed": "Could not close this chat session", "structuredSessionLaunchFailed": "Could not open Codex chat", "structuredSessionCloseFailedDescription": "The terminal stayed open so the provider remains recoverable.", "handoff": {