From 25e6ee8979218da22e31e44a33ed522d1a448e8a Mon Sep 17 00:00:00 2001 From: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Date: Thu, 12 Nov 2026 22:07:45 -0800 Subject: [PATCH] Fix browser extension reporting --- src/main/telemetry/browser-extensions-banner.ts | 5 ++--- .../use-browser-extensions-tour.mounted.test.tsx | 6 ++++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/main/telemetry/browser-extensions-banner.ts b/src/main/telemetry/browser-extensions-banner.ts index 950fcfca2d1..d41ed834506 100644 --- a/src/main/telemetry/browser-extensions-banner.ts +++ b/src/main/telemetry/browser-extensions-banner.ts @@ -142,14 +142,13 @@ export function recordBrowserExtensionInstalled(source: 'web_store' | 'unpacked' } } -/** Reported once per launch. */ +/** Reported once per launch; a refused report is retried on the next use. */ export function recordBrowserExtensionUsed(): void { if (usedThisSession) { return } - usedThisSession = true try { - track('browser_extension_used', {}) + usedThisSession = track('browser_extension_used', {}) } catch { // Telemetry never costs a click. } diff --git a/src/renderer/src/components/browser-pane/use-browser-extensions-tour.mounted.test.tsx b/src/renderer/src/components/browser-pane/use-browser-extensions-tour.mounted.test.tsx index 50f1486130f..8d5a7ca9b75 100644 --- a/src/renderer/src/components/browser-pane/use-browser-extensions-tour.mounted.test.tsx +++ b/src/renderer/src/components/browser-pane/use-browser-extensions-tour.mounted.test.tsx @@ -343,9 +343,11 @@ describe('useBrowserExtensionsTour banner assignment', () => { it('does not show once a dialog opened while main was answering', async () => { let answer: (reply: Reply) => void = () => {} - window.api.telemetryAssignBrowserExtensionsBanner = () => - new Promise((resolve) => (answer = resolve)) + const assign = vi.fn(() => new Promise((resolve) => (answer = resolve))) + window.api.telemetryAssignBrowserExtensionsBanner = assign renderHook(() => useBrowserExtensionsTour(true, true)) + await act(async () => vi.advanceTimersByTimeAsync(0)) + expect(assign).toHaveBeenCalledTimes(1) act(() => useAppStore.setState({ activeModal: 'add-repo' })) await act(async () => { answer({ status: 'not_enrolled' })