From 26307e63dc468b836bb4ac1fc34a1aa2b10c99f7 Mon Sep 17 00:00:00 2001
From: Neil <4138956+nwparker@users.noreply.github.com>
Date: Thu, 13 Aug 2026 23:36:38 -0700
Subject: [PATCH] docs(ssh): narrow why the E2E strengthening patch fails at
 runtime
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The verified patch that would close both stated E2E weaknesses applies cleanly
but fails locating the tab element. The attribute is not the problem —
SortableTab.tsx:220 renders data-tab-id={tab.id}. Terminal tabs carry both an id
and an entityId, and getTabBarOrder returns entityId, so a locator built from
that order can never match. The fix is to resolve tab.id before clicking.

Recorded in the spec beside the weakness it would close, so the next attempt
starts from the diagnosis rather than rediscovering it.
---
 tests/e2e/ssh-partition-upgrade-tab-restore.spec.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/e2e/ssh-partition-upgrade-tab-restore.spec.ts b/tests/e2e/ssh-partition-upgrade-tab-restore.spec.ts
index 989f115e246..fc97cc6ee4d 100644
--- a/tests/e2e/ssh-partition-upgrade-tab-restore.spec.ts
+++ b/tests/e2e/ssh-partition-upgrade-tab-restore.spec.ts
@@ -153,9 +153,11 @@ test.describe('an upgrading profile keeps the tabs its old build left in the ssh
       // panes, so this covers one of the three tabs — two could restore blank and this still
       // passes. Assertion 3 is weaker still: a bare shell count is satisfied by N killed and N
       // respawned, so it cannot show the panes reattached to the SAME shells. A verified patch
-      // exists that clicks each tab and compares ptyIds captured before quit; it did not apply
-      // cleanly here (its [data-tab-id] locator does not resolve in this tree) and is left for a
-      // follow-up rather than landed red.
+      // exists that clicks each tab and compares ptyIds captured before quit. It applies but fails
+      // at runtime here, and the cause is narrowed: the attribute is fine — SortableTab.tsx:220
+      // renders data-tab-id={tab.id} — so the mismatch is WHICH id the helper feeds it. Terminal
+      // tabs carry both an id and an entityId, and getTabBarOrder returns entityId, so a locator
+      // built from that order finds nothing. Resolve tab.id (not entityId) before clicking.
       await expect
         .poll(
           async () => {