diff --git a/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts b/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts index 8c76721cbd5..5e988e3fbd8 100644 --- a/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts +++ b/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts @@ -16,27 +16,27 @@ beforeEach(() => { }) describe('checks panel hosted review click routing', () => { - it('maps Shift+Cmd to forceSystemBrowser on macOS', () => { + it('maps Shift+Cmd to the routing modifier on macOS', () => { const event = { metaKey: true, ctrlKey: false, shiftKey: true } expect(isChecksPanelHostedReviewSystemBrowserModifier(event, true)).toBe(true) expect(resolveChecksPanelHostedReviewHttpOpenOptions(event, true, 'wt-1')).toEqual({ worktreeId: 'wt-1', - forceSystemBrowser: true + modifierHeld: true }) }) - it('maps Shift+Ctrl to forceSystemBrowser off macOS', () => { + it('maps Shift+Ctrl to the routing modifier off macOS', () => { const event = { metaKey: false, ctrlKey: true, shiftKey: true } expect(isChecksPanelHostedReviewSystemBrowserModifier(event, false)).toBe(true) expect(resolveChecksPanelHostedReviewHttpOpenOptions(event, false, 'wt-1')).toEqual({ worktreeId: 'wt-1', - forceSystemBrowser: true + modifierHeld: true }) }) - it('preserves the worktree id without forceSystemBrowser on plain clicks', () => { + it('preserves the worktree id without the modifier on plain clicks', () => { expect( resolveChecksPanelHostedReviewHttpOpenOptions( { metaKey: false, ctrlKey: false, shiftKey: false }, @@ -46,7 +46,7 @@ describe('checks panel hosted review click routing', () => { ).toEqual({ worktreeId: 'wt-1' }) }) - it('opens hosted review URLs without forceSystemBrowser on plain clicks', () => { + it('opens hosted review URLs without the modifier on plain clicks', () => { openChecksPanelHostedReviewUrl({ url: 'https://github.com/acme/widgets/pull/123', event: { metaKey: false, ctrlKey: false, shiftKey: false }, @@ -59,7 +59,7 @@ describe('checks panel hosted review click routing', () => { }) }) - it('opens hosted review URLs with forceSystemBrowser on Shift+Cmd clicks', () => { + it('opens hosted review URLs with the modifier on Shift+Cmd clicks', () => { openChecksPanelHostedReviewUrl({ url: 'https://github.com/acme/widgets/pull/123', event: { metaKey: true, ctrlKey: false, shiftKey: true }, @@ -69,7 +69,7 @@ describe('checks panel hosted review click routing', () => { expect(openHttpLinkMock).toHaveBeenCalledWith('https://github.com/acme/widgets/pull/123', { worktreeId: 'wt-1', - forceSystemBrowser: true + modifierHeld: true }) }) }) diff --git a/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.ts b/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.ts index 69954385abe..e3f1ea68c5b 100644 --- a/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.ts +++ b/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.ts @@ -14,8 +14,10 @@ export function resolveChecksPanelHostedReviewHttpOpenOptions( isMac: boolean, worktreeId: string | null | undefined ): OpenHttpLinkOptions { + // Why: same escape hatch as terminal and markdown links โ€” openHttpLink resolves + // whether it forces the system browser or inverts the Link Routing setting. if (isChecksPanelHostedReviewSystemBrowserModifier(event, isMac)) { - return { worktreeId, forceSystemBrowser: true } + return { worktreeId, modifierHeld: true } } return { worktreeId } } diff --git a/src/renderer/src/components/settings/browser-link-routing-modifier-copy.ts b/src/renderer/src/components/settings/browser-link-routing-modifier-copy.ts index 5581a17c289..b8f6e188c48 100644 --- a/src/renderer/src/components/settings/browser-link-routing-modifier-copy.ts +++ b/src/renderer/src/components/settings/browser-link-routing-modifier-copy.ts @@ -26,6 +26,14 @@ export function getLinkRoutingModifierDescription({ }): string { const chord = isMac ? 'โ‡งโŒ˜' : 'Shift+Ctrl' return openLinksInApp - ? `Links open in Orca, so ${chord}+click sends one to your system browser instead.` - : `Links open in your system browser, so ${chord}+click opens one in Orca's built-in browser instead.` + ? translate( + 'auto.components.settings.BrowserLinkRoutingModifierSetting.descriptionSystem', + 'Links open in Orca, so {{chord}}+click sends one to your system browser instead.', + { chord } + ) + : translate( + 'auto.components.settings.BrowserLinkRoutingModifierSetting.descriptionOrca', + "Links open in your system browser, so {{chord}}+click opens one in Orca's built-in browser instead.", + { chord } + ) } diff --git a/src/renderer/src/i18n/locales/en.json b/src/renderer/src/i18n/locales/en.json index 8d2a0486a2b..54d17a4b09e 100644 --- a/src/renderer/src/i18n/locales/en.json +++ b/src/renderer/src/i18n/locales/en.json @@ -9749,7 +9749,9 @@ "BrowserLinkRoutingModifierSetting": { "toggleLabel": "Toggle inverted link routing modifier", "titleSystem": "Hold Shift to open in your web browser", - "titleOrca": "Hold Shift to open in Orca" + "titleOrca": "Hold Shift to open in Orca", + "descriptionSystem": "Links open in Orca, so {{chord}}+click sends one to your system browser instead.", + "descriptionOrca": "Links open in your system browser, so {{chord}}+click opens one in Orca's built-in browser instead." } }, "right": { diff --git a/src/renderer/src/i18n/locales/es.json b/src/renderer/src/i18n/locales/es.json index 5d604009e32..7b050ab634b 100644 --- a/src/renderer/src/i18n/locales/es.json +++ b/src/renderer/src/i18n/locales/es.json @@ -9726,7 +9726,9 @@ "BrowserLinkRoutingModifierSetting": { "toggleLabel": "Toggle inverted link routing modifier", "titleSystem": "Hold Shift to open in your web browser", - "titleOrca": "Hold Shift to open in Orca" + "titleOrca": "Hold Shift to open in Orca", + "descriptionSystem": "Links open in Orca, so {{chord}}+click sends one to your system browser instead.", + "descriptionOrca": "Links open in your system browser, so {{chord}}+click opens one in Orca's built-in browser instead." } }, "right": { diff --git a/src/renderer/src/i18n/locales/ja.json b/src/renderer/src/i18n/locales/ja.json index a78ef3bd957..0ddc7a69638 100644 --- a/src/renderer/src/i18n/locales/ja.json +++ b/src/renderer/src/i18n/locales/ja.json @@ -9726,7 +9726,9 @@ "BrowserLinkRoutingModifierSetting": { "toggleLabel": "Toggle inverted link routing modifier", "titleSystem": "Hold Shift to open in your web browser", - "titleOrca": "Hold Shift to open in Orca" + "titleOrca": "Hold Shift to open in Orca", + "descriptionSystem": "Links open in Orca, so {{chord}}+click sends one to your system browser instead.", + "descriptionOrca": "Links open in your system browser, so {{chord}}+click opens one in Orca's built-in browser instead." } }, "right": { diff --git a/src/renderer/src/i18n/locales/ko.json b/src/renderer/src/i18n/locales/ko.json index ec7196f8a16..60583855af3 100644 --- a/src/renderer/src/i18n/locales/ko.json +++ b/src/renderer/src/i18n/locales/ko.json @@ -9726,7 +9726,9 @@ "BrowserLinkRoutingModifierSetting": { "toggleLabel": "Toggle inverted link routing modifier", "titleSystem": "Hold Shift to open in your web browser", - "titleOrca": "Hold Shift to open in Orca" + "titleOrca": "Hold Shift to open in Orca", + "descriptionSystem": "Links open in Orca, so {{chord}}+click sends one to your system browser instead.", + "descriptionOrca": "Links open in your system browser, so {{chord}}+click opens one in Orca's built-in browser instead." } }, "right": { diff --git a/src/renderer/src/i18n/locales/zh.json b/src/renderer/src/i18n/locales/zh.json index 355bffb9f2b..706ae0f3483 100644 --- a/src/renderer/src/i18n/locales/zh.json +++ b/src/renderer/src/i18n/locales/zh.json @@ -9726,7 +9726,9 @@ "BrowserLinkRoutingModifierSetting": { "toggleLabel": "Toggle inverted link routing modifier", "titleSystem": "Hold Shift to open in your web browser", - "titleOrca": "Hold Shift to open in Orca" + "titleOrca": "Hold Shift to open in Orca", + "descriptionSystem": "Links open in Orca, so {{chord}}+click sends one to your system browser instead.", + "descriptionOrca": "Links open in your system browser, so {{chord}}+click opens one in Orca's built-in browser instead." } }, "right": {