From 2a65206be8079b1143be3ebd361b35f118b91efe Mon Sep 17 00:00:00 2001 From: Neil <4138956+nwparker@users.noreply.github.com> Date: Fri, 7 Aug 2026 05:43:54 -0700 Subject: [PATCH] chore(lint): drop five unused no-console disable directives MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `check-changed-code-quality` reports unused eslint-disable directives as errors, and these five sat above diagnostic `console.log` calls in IME test and spec files where `no-console` is not enabled — so each suppressed nothing. This is the second of the two static-analysis steps. `c51c6b5837e` fixed "Enforce focused code-quality plugins" (duplicate test titles); this fixes "Enforce changed-code quality". Both had been red on this branch since 2026-08-06, and I mistook the first for the whole job. The diagnostic logs themselves are kept — they are what a failing IME arm prints for a reader to inspect. --- .../terminal-ime-xterm-composition-commit-lag.test.ts | 3 --- .../terminal-ime-xterm-preedit-overlay-committed-cell.test.ts | 1 - tests/e2e/issue-12164-korean-glyph-doubling.spec.ts | 1 - 3 files changed, 5 deletions(-) diff --git a/src/renderer/src/components/terminal-pane/terminal-ime-xterm-composition-commit-lag.test.ts b/src/renderer/src/components/terminal-pane/terminal-ime-xterm-composition-commit-lag.test.ts index ee9a692760a..b9938d974c4 100644 --- a/src/renderer/src/components/terminal-pane/terminal-ime-xterm-composition-commit-lag.test.ts +++ b/src/renderer/src/components/terminal-pane/terminal-ime-xterm-composition-commit-lag.test.ts @@ -129,9 +129,7 @@ describe('STA-3250 — continuous Korean typing, no Enter', () => { const snapshots = await typeSyllables(textarea, emitted, HANGUL_PHRASE) // Reported diagnostic: what onData holds once each syllable has been typed. - // eslint-disable-next-line no-console console.log('[STA-3250] per-syllable onData:', JSON.stringify(snapshots)) - // eslint-disable-next-line no-console console.log('[STA-3250] final onData:', JSON.stringify(emitted)) // After syllable 2 (글) has been typed, 한 was committed one syllable ago and @@ -157,7 +155,6 @@ describe('STA-3250 — continuous Korean typing, no Enter', () => { await nextEventLoop() snapshots.push([...emitted]) } - // eslint-disable-next-line no-console console.log('[STA-3250 ascii] per-key onData:', JSON.stringify(snapshots)) expect(snapshots.map((s) => s.join(''))).toEqual(['a', 'ab', 'abc', 'abcd']) }) diff --git a/src/renderer/src/components/terminal-pane/terminal-ime-xterm-preedit-overlay-committed-cell.test.ts b/src/renderer/src/components/terminal-pane/terminal-ime-xterm-preedit-overlay-committed-cell.test.ts index 60adf5d3e84..7bf7a799d13 100644 --- a/src/renderer/src/components/terminal-pane/terminal-ime-xterm-preedit-overlay-committed-cell.test.ts +++ b/src/renderer/src/components/terminal-pane/terminal-ime-xterm-preedit-overlay-committed-cell.test.ts @@ -273,7 +273,6 @@ describe('Korean preedit overlay against committed terminal content', () => { const samples = await typeKorean(rig) // Reported diagnostic, in the columns the capture recorded. - // eslint-disable-next-line no-console console.log( '[overlap] per-key cursorX/row/overlay:', JSON.stringify( diff --git a/tests/e2e/issue-12164-korean-glyph-doubling.spec.ts b/tests/e2e/issue-12164-korean-glyph-doubling.spec.ts index f9d8ebcd320..8edeeef1ffc 100644 --- a/tests/e2e/issue-12164-korean-glyph-doubling.spec.ts +++ b/tests/e2e/issue-12164-korean-glyph-doubling.spec.ts @@ -88,7 +88,6 @@ async function runProbe(orcaPage: Page, renderer: 'webgl' | 'dom'): Promise