From 2b133972fa63dcda9bc3b405e72d0dc37b26e48a Mon Sep 17 00:00:00 2001 From: "buf0-bot[bot]" <252831055+buf0-bot[bot]@users.noreply.github.com> Date: Sat, 9 May 2026 17:40:48 -0700 Subject: [PATCH] Revert "fix: pr-bug-scan findings from #1468" (#1559) (#1636) Co-authored-by: orca-bot --- src/renderer/src/components/TaskPage.tsx | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/renderer/src/components/TaskPage.tsx b/src/renderer/src/components/TaskPage.tsx index 4ca5d1990d2..04bd6348374 100644 --- a/src/renderer/src/components/TaskPage.tsx +++ b/src/renderer/src/components/TaskPage.tsx @@ -785,18 +785,14 @@ export default function TaskPage(): React.JSX.Element { } }, [pageData.taskSource]) - // Why: when settings hydrate after Tasks mounts, seed taskSource from - // defaultTaskSource — but only once. Re-running on every defaultTaskSource - // change would clobber an in-session manual source pick (e.g. the user - // clicked the Linear icon and then changed the default in Settings). - const defaultTaskSourceSeededRef = useRef(false) + // Why: settings.defaultTaskSource can change while Tasks is open (Settings + // panel is reachable without unmounting Tasks). The one-shot resume effect + // only seeds taskSource on first mount, so without this sync a mid-session + // change to the default would not propagate when no explicit page-level + // taskSource was passed. useEffect(() => { - if (defaultTaskSourceSeededRef.current) { - return - } if (!pageData.taskSource && settings?.defaultTaskSource) { setTaskSource(settings.defaultTaskSource) - defaultTaskSourceSeededRef.current = true } }, [settings?.defaultTaskSource, pageData.taskSource])