From 2d623d704fd18d460926a8bbf429bf0ddde50537 Mon Sep 17 00:00:00 2001 From: Neil Date: Tue, 15 Sep 2026 22:38:23 -0700 Subject: [PATCH] docs(windows): put the superseded export-only gate in the past tense It describes what used to pass a broken addon, so present tense reads as a description of the gate the same document then explains replacing it. --- docs/reference/windows-msys-job-breakaway.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/reference/windows-msys-job-breakaway.md b/docs/reference/windows-msys-job-breakaway.md index 1ae9bef025a..a4eeca9b117 100644 --- a/docs/reference/windows-msys-job-breakaway.md +++ b/docs/reference/windows-msys-job-breakaway.md @@ -75,12 +75,13 @@ to retry for it. That needs a helper that calls `CreateProcess` with the flag; ## A stale addon looks exactly like the bug -`config/scripts/node-pty-job-ownership.cjs` asserts only that `terminateJob`, -`listJobProcessIds` and `assignCurrentProcessToJob` are exported. All three -predate #19068, so a `conpty.node` built before it passes every gate, -`isPtyJobOwnershipAvailable()` returns true, `windows-pty-job.win32.test.ts` -passes 6/6 — and `windows-msys-job.win32.test.ts` fails with a two-pid job list -that reads as a source defect rather than a build-freshness one. +`config/scripts/node-pty-job-ownership.cjs` used to assert only that +`terminateJob`, `listJobProcessIds` and `assignCurrentProcessToJob` are +exported. All three predate #19068, so a `conpty.node` built before it passed +every gate: `isPtyJobOwnershipAvailable()` returned true and +`windows-pty-job.win32.test.ts` passed 6/6, while +`windows-msys-job.win32.test.ts` failed with a two-pid job list that read as a +source defect rather than a build-freshness one. When that test fails, check the binary before the code: