starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-30 16:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(github): name an unfiltered empty project view instead of blaming a filter (#20588)

Browse Source 
* fix(github): skip Projects search index for unfiltered views

Empty query still used items(query:\$q), which routes through GitHub's
Projects search index and can return totalCount 0 while the board is full
during index lag. Omit the query argument when the view filter is empty.

Fixes #12648.

* docs(github): drop the false stable-shape claim for empty project filters

Unfiltered item fetches omit items(query:) so boards skip search-index
lag. The View.filter field is still '' when GitHub returns null.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(github): name an unfiltered empty project view instead of blaming a filter

The search-index workaround in this branch was a no-op. Live introspection of
ProjectV2.items shows `query` is declared `String = ""`, so omitting the
argument and sending `$q = ""` coerce to the identical resolver input; GitHub
applies declared defaults for omitted args (verified against its own endpoint).
There is no non-search item field on ProjectV2 and ProjectV2View has no `items`
at all, so no request shape can dodge the index. Revert the branching query
construction and the module it added.

What the user actually reported in #12648 is the copy: a view with no filter
rendered "No items match this view's filter", which reads as data loss when a
freshly populated board momentarily comes back empty. Word the empty state from
the view's own filter — the filter message only when there is a filter, and an
honest "no items yet" plus a transience hint when there is not — and share the
one implementation between the table and roadmap surfaces.

Refs #12648.

---------

Co-authored-by: bbingz <zzb@gxsmjx.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Neil
2026-09-14 01:44:47 -07:00
committed by GitHub
co-authored by bbingz Cursor
parent 539d4d1f32
commit 2ed89b8781
12 changed files with 115 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/github/project-types.ts
+4 -3
View File
@@ -81,9 +81,10 @@ export type GitHubProjectView = {
number: number
name: string
layout: GitHubProjectViewLayout
/** Normalized to '' when GitHub returns null. Why: passing null through as
* `$q` in the items query would change the query shape between filtered
* and unfiltered views; the empty string keeps the GraphQL shape stable. */
/** Normalized to '' when GitHub returns null. `ProjectV2.items(query:)` is
* declared `String = ""`, so sending '' and omitting the argument are the
* same request — there is no non-search item field to fall back to. '' is
* therefore only a UI signal: it means "this view is unfiltered". */
filter: string
fields: GitHubProjectField[]
groupByFields: GitHubProjectField[]