From 2f20e9ac2911e1222268de2abf290b52b005bd2b Mon Sep 17 00:00:00 2001 From: Merge Sim Date: Mon, 7 Sep 2026 00:19:24 -0700 Subject: [PATCH] test(codex): retire the last comment this change falsified Review pass 3 found one more instance of the class commit 2 set out to purge, in a file this PR does not otherwise touch: the per-account mirror case said "a Windows host keeps the shared system-default mirror". That was true before this change and is false after it -- the mirror there comes from the host account selection on the line below, not from the platform. Also name which of the two toBeNull() cases the precheck comment points at; the file has one for a missing path and one for a launchEnv CODEX_HOME, and only the second is the launch-side refusal being cited. --- .../codex-accounts/runtime-home-per-account-homes.test.ts | 5 +++-- .../runtime-home-windows-profile-ownership.test.ts | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/codex-accounts/runtime-home-per-account-homes.test.ts b/src/main/codex-accounts/runtime-home-per-account-homes.test.ts index 7877482f355..dc8ca5526af 100644 --- a/src/main/codex-accounts/runtime-home-per-account-homes.test.ts +++ b/src/main/codex-accounts/runtime-home-per-account-homes.test.ts @@ -335,8 +335,9 @@ describe('CodexRuntimeHomeService', () => { }) it('surfaces per-account rollouts for session discovery on the mirror lane', async () => { - // A Windows host keeps the shared system-default mirror, but its managed - // accounts still launch from their own homes and accumulate rollouts there. + // A host ACCOUNT SELECTION keeps the shared system-default mirror (not the + // platform -- the win32 lane block is gone), while its managed accounts + // still launch from their own homes and accumulate rollouts there. const home1 = createManagedAuth( testState.userDataDir, 'account-1', diff --git a/src/main/codex-accounts/runtime-home-windows-profile-ownership.test.ts b/src/main/codex-accounts/runtime-home-windows-profile-ownership.test.ts index a2abda0a31c..a59faec0c6c 100644 --- a/src/main/codex-accounts/runtime-home-windows-profile-ownership.test.ts +++ b/src/main/codex-accounts/runtime-home-windows-profile-ownership.test.ts @@ -56,8 +56,9 @@ describe('Windows System Default Codex home ownership', () => { }) ).toBe(false) // Pins the eligibility PRECHECK, which takes no launchEnv. The migration - // launch itself does re-check it and refuses -- see the toBeNull() case in - // runtime-home-real-home-lane-routing.test.ts. Only the precheck is blind. + // launch itself does re-check it and refuses -- see the launchEnv-CODEX_HOME + // toBeNull() case in runtime-home-real-home-lane-routing.test.ts (not the + // missing-path one). Only the precheck is blind. expect(service.isHostSystemDefaultSessionMigrationEligible()).toBe(true) })