From 2f89c20d618f9492fa44e8439eef59c1c484a175 Mon Sep 17 00:00:00 2001 From: Wooseong Kim Date: Fri, 7 Aug 2026 08:20:36 +0900 Subject: [PATCH] docs(github-project): correct upstream host fallback comment Persistence now keeps non-empty upstream.host; originIdentityKey remains the host fallback for older records without one (CodeRabbit nit). --- src/renderer/src/lib/repo-slug-cache.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/renderer/src/lib/repo-slug-cache.ts b/src/renderer/src/lib/repo-slug-cache.ts index 503d800617a..cb6552aa572 100644 --- a/src/renderer/src/lib/repo-slug-cache.ts +++ b/src/renderer/src/lib/repo-slug-cache.ts @@ -21,11 +21,9 @@ export type RepoSlugMatches = { origin: Repo[]; upstream: Repo[] } * may legitimately match, since a contributor's clone has the personal fork as * `origin`. `null` when the repo is not a fork or the key cannot be trusted. * - * Why `originIdentityKey` is required: persistence strips `upstream.host` - * (`sanitizeRepoUpstream`), so the fork's own origin is the only evidence of - * which server its parent lives on. Without it the key falls into the - * github.com namespace, where a GHES row would never match and an unrelated - * public row would bind the Enterprise clone. */ + * Why `originIdentityKey` is required: when `upstream.host` is absent (older + * persisted forks), the fork's origin host is the fallback so GHES parents do + * not collapse into github.com. Unresolved origins refuse the alias. */ export function repoUpstreamIdentityKey( repo: Repo, originIdentityKey: string | null | undefined