From 36bd64e689df5443c8c8ba3746e0bc4f49ea7b22 Mon Sep 17 00:00:00 2001 From: Jinjing <6427696+AmethystLiang@users.noreply.github.com> Date: Fri, 13 Nov 2026 16:34:36 -0800 Subject: [PATCH] refactor(settings): narrow retained editor element types --- .../settings/agents/launch/AgentDetectionCatalog.test.tsx | 4 ++-- .../settings/agents/launch/agent-catalog-row-placement.ts | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/renderer/src/components/settings/agents/launch/AgentDetectionCatalog.test.tsx b/src/renderer/src/components/settings/agents/launch/AgentDetectionCatalog.test.tsx index dfaafc2746d..a01e77d170c 100644 --- a/src/renderer/src/components/settings/agents/launch/AgentDetectionCatalog.test.tsx +++ b/src/renderer/src/components/settings/agents/launch/AgentDetectionCatalog.test.tsx @@ -71,7 +71,7 @@ it('retains a focused unsaved command and selection across asynchronous membersh const save = vi.fn() const view = render(catalog(false, save)) fireEvent.click(screen.getByRole('button', { name: 'Claude' })) - const input = screen.getByDisplayValue('claude') as HTMLInputElement + const input = screen.getByDisplayValue('claude') input.focus() fireEvent.change(input, { target: { value: '/custom/unsaved-claude' } }) input.setSelectionRange(3, 9, 'backward') @@ -109,7 +109,7 @@ it('keeps a pending save attached to the same editor when membership changes', a ) const view = render(catalog(false, save)) fireEvent.click(screen.getByRole('button', { name: 'Claude' })) - const input = screen.getByDisplayValue('claude') as HTMLInputElement + const input = screen.getByDisplayValue('claude') fireEvent.change(input, { target: { value: '/custom/claude' } }) fireEvent.keyDown(input, { key: 'Enter' }) await waitFor(() => expect(input.readOnly).toBe(true)) diff --git a/src/renderer/src/components/settings/agents/launch/agent-catalog-row-placement.ts b/src/renderer/src/components/settings/agents/launch/agent-catalog-row-placement.ts index 1070a680746..432904e3de1 100644 --- a/src/renderer/src/components/settings/agents/launch/agent-catalog-row-placement.ts +++ b/src/renderer/src/components/settings/agents/launch/agent-catalog-row-placement.ts @@ -29,9 +29,8 @@ export function createAgentCatalogRowHost(): { } const atomic = element.isConnected && parent.isConnected && typeof parent.moveBefore === 'function' - const active = element.contains(document.activeElement) - ? (document.activeElement as HTMLElement) - : null + const focused = document.activeElement + const active = focused instanceof HTMLElement && element.contains(focused) ? focused : null const selection = active instanceof HTMLInputElement || active instanceof HTMLTextAreaElement ? {