From 37f0c1a61ccde26faa3310c2f2b797974e7a1bf4 Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Wed, 29 Jul 2026 17:22:32 -0700 Subject: [PATCH] fix(quick-open): support projects past 10k files --- src/shared/quick-open-readdir-budget.ts | 4 +++- src/shared/quick-open-readdir-walk.test.ts | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/shared/quick-open-readdir-budget.ts b/src/shared/quick-open-readdir-budget.ts index 991e02694f1..ced172a92a6 100644 --- a/src/shared/quick-open-readdir-budget.ts +++ b/src/shared/quick-open-readdir-budget.ts @@ -1,4 +1,6 @@ -export const QUICK_OPEN_READDIR_MAX_FILES = 10_000 +import { QUICK_OPEN_LISTING_MAX_RESULTS } from './quick-open-listing-limits' + +export const QUICK_OPEN_READDIR_MAX_FILES = QUICK_OPEN_LISTING_MAX_RESULTS export const QUICK_OPEN_READDIR_MAX_ENTRIES = 50_000 export const QUICK_OPEN_READDIR_MAX_DIRECTORIES = 25_000 export const QUICK_OPEN_READDIR_MAX_DEPTH = 256 diff --git a/src/shared/quick-open-readdir-walk.test.ts b/src/shared/quick-open-readdir-walk.test.ts index 1c3ae1adf34..f78f95136fc 100644 --- a/src/shared/quick-open-readdir-walk.test.ts +++ b/src/shared/quick-open-readdir-walk.test.ts @@ -392,7 +392,8 @@ describe('quick-open readdir walk', () => { ).rejects.toThrow('File listing exceeded') }) - it('keeps the default safety cap for a very large collapsed directory', async () => { + it('supports more than 10,000 files while keeping the default safety cap', async () => { + expect(QUICK_OPEN_READDIR_MAX_FILES).toBeGreaterThan(10_000) const root = await makeTempRoot() await mkdirRel(root, 'dist') opendirMock.mockResolvedValueOnce({ @@ -416,7 +417,7 @@ describe('quick-open readdir walk', () => { gitPaths: [], directoryPaths: ['dist/'] }) - ).rejects.toThrow('File listing exceeded 10000 files') + ).rejects.toThrow(`File listing exceeded ${QUICK_OPEN_READDIR_MAX_FILES} files`) }) it('identifies budget errors so callers can translate only those to install-rg guidance', () => {