mirror of
https://github.com/stablyai/orca.git
synced 2026-11-05 19:47:27 +00:00
fix(build): explain missing mobile/ deps instead of failing build:mobile-web (#24325)
mobile/ is a separate pnpm project, so the root pnpm install leaves mobile/node_modules empty and pnpm build failed in build:mobile-web with hundreds of unexplained esbuild "Could not resolve" errors. build-mobile-web-app-bundle now checks for mobile/node_modules first and exits with the one command that fixes it. The probe path is shared with the bundle tests' dependency check. CONTRIBUTING documents the install in Local Setup and points "Before Opening a PR" at it. Fixes #24324 Co-authored-by: Neil <neil@stably.ai>
This commit is contained in:
co-authored by
Neil
parent
daf806bb41
commit
3bfb2bd094
+10
-1
@@ -53,6 +53,15 @@ pnpm install
|
||||
pnpm dev
|
||||
```
|
||||
|
||||
`mobile/` is a separate pnpm project with its own lockfile, so the root `pnpm install` leaves its
|
||||
dependencies uninstalled. `pnpm build` (`build:mobile-web` fails without them) and the lint
|
||||
passes that cover `mobile/` need them. Install them before building or linting, and again
|
||||
when `mobile/pnpm-lock.yaml` changes:
|
||||
|
||||
```bash
|
||||
pnpm -C mobile install --frozen-lockfile
|
||||
```
|
||||
|
||||
### Dev Profiles and Parallel Instances
|
||||
|
||||
`pnpm dev` in a linked Git worktree uses its own userData profile, renderer port, and remote
|
||||
@@ -170,7 +179,7 @@ Avoid vague names like `test`, `misc`, or `changes`.
|
||||
|
||||
## Before Opening a PR
|
||||
|
||||
Run the same checks that CI runs:
|
||||
Run the same checks that CI runs, after the `mobile/` install from [Local Setup](#local-setup):
|
||||
|
||||
```bash
|
||||
pnpm lint
|
||||
|
||||
Reference in New Issue
Block a user