From 429c06c04776d1fa1ed1a62eed03278f220fb28b Mon Sep 17 00:00:00 2001 From: Brennan Benson <79079362+brennanb2025@users.noreply.github.com> Date: Mon, 27 Jul 2026 20:54:04 -0700 Subject: [PATCH] test(browser): pin the inert modifier hint when links already open in Orca --- .../checks-panel-hosted-review-click-routing.test.ts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts b/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts index c4dca6eada3..4f517517652 100644 --- a/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts +++ b/src/renderer/src/components/right-sidebar/checks-panel-hosted-review-click-routing.test.ts @@ -82,6 +82,17 @@ describe('checks panel hosted review modifier hint destination', () => { ) }) + // Why: inverting is inert while links already open in Orca — both meanings of the + // modifier land on the system browser, so checking inverts first would misname it. + it('names the system browser when inverting is on and links already open in Orca', () => { + expect( + resolveChecksPanelHostedReviewModifierDestination( + { openLinksInApp: true, openLinksInAppModifierInverts: true }, + true + ) + ).toBe('system-browser') + }) + // Why: this is the gesture the invert setting adds — without it the hint stays hidden // and the only way to reach Orca from this button is undiscoverable. it('names Orca when inverting is on and links open externally', () => {